Fullscreen mode broken, video is black |
|||||
Issue descriptionChrome Version: 62.0.3193.3 VrCore: 1.8.163477258 Platform: Pixel XL What steps will reproduce the problem? (1) go to m.youtube.com (2) enter Chrome VR (3) select a video and press play (4) Enter fullscreen mode What is the expected result? Video content should be shown What happens instead? In fullscreen, the video is black.
,
Aug 24 2017
On bing.com/videos, the videos are transparent through to the background mesh when fullscreened. Also depends on which video you watch, so something must have changed with respect to video surfaces.
,
Aug 24 2017
Broken by https://chromium-review.googlesource.com/c/chromium/src/+/604168 Not sure if we have any way of testing whether we're in VR in the renderer. Might need to add new hooks to disable this kind of overlay when in VR.
,
Aug 24 2017
i think that the right place to check would be the browser. the overlay system could refuse to provide an overlay / cancel an existing overlay if it's in VR mode. everything should fall back to SurfaceTexture composition automatically if it does that. as an aside, we might want to integrate VR into the overlay system better, so that we can provide secure gvr surfaces for L1 content. i built it with that in mind, based on some discussions with amp@ .
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5c4fef354a703f68a36de2725fcfd7e81a4a4d0 commit c5c4fef354a703f68a36de2725fcfd7e81a4a4d0 Author: Michael Thiessen <mthiesse@chromium.org> Date: Tue Aug 29 16:42:04 2017 Disable content DialogOverlays while in VR. Bug: 758285 Change-Id: Ie2936bdd3331eb1b5714bd30fdde6011f845a623 Reviewed-on: https://chromium-review.googlesource.com/634152 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#498139} [modify] https://crrev.com/c5c4fef354a703f68a36de2725fcfd7e81a4a4d0/content/browser/android/dialog_overlay_impl.cc
,
Aug 29 2017
,
Sep 5 2017
,
Sep 5 2017
verified in 63.0.3206.0
,
Jul 4
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mthiesse@chromium.org
, Aug 24 2017Status: Assigned (was: Untriaged)