New issue
Advanced search Search tips

Issue 758268 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 754515
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 596231



Sign in to add a comment

DCHECK in RenderFrameHostImpl::OnSuddenTerminationDisablerChanged

Project Member Reported by siggi@chromium.org, Aug 23 2017

Issue description

Crash a tab, as per e.g.  bug 758260 .
Click reload button.
Browser crashes.

void RenderFrameHostImpl::OnSuddenTerminationDisablerChanged(
    bool present,
    blink::WebSuddenTerminationDisablerType disabler_type) {
  DCHECK_NE(GetSuddenTerminationDisablerState(disabler_type), present);
  if (present) {
    sudden_termination_disabler_types_enabled_ |= disabler_type;
  } else {
    sudden_termination_disabler_types_enabled_ &= ~disabler_type;
  }
}

0:000> dv
           this = 0x3c4d8d68
        present = true
  disabler_type = 0x02 ''
 true_if_passed = class logging::CheckOpResult

 

Comment 1 by siggi@chromium.org, Aug 23 2017

Blocking: 596231

Comment 2 by siggi@chromium.org, Aug 23 2017

Components: UI>Browser

Comment 3 by siggi@chromium.org, Aug 23 2017

I can repro the termination by navigating to chrome://memory-exhaust, then reloading. For some reason chrome://crash doesn't repro the check.

Comment 4 by siggi@chromium.org, Aug 23 2017

Owner: fmea...@chromium.org
Looks like this code was added here: https://chromium-review.googlesource.com/c/chromium/src/+/562616. Fadi, can you take a look?
Mergedinto: 754515
Status: Duplicate (was: Untriaged)

Comment 7 by siggi@chromium.org, Aug 24 2017

Labels: Hotlist-dcheck

Sign in to add a comment