Leveldatabase memory dump appears to double-count |
||
Issue descriptionLooking at LevelDatabase dumps from a recent build (attached), it appears that each consumer is using ~512KB, with a total of 10 consumers this results in ~5MB reported usage. Previously, chrishtr@ made changes to: a) Limit leveldb block cache size to 512KB b) Cause all components to share a block cache See https://chromium-review.googlesource.com/c/chromium/src/+/567583 Given that this seemed to be working with the previous memory dump logic, I'm wondering if the updates to the dump logic have caused each component to report their ~512KB block cache as their own, rather than aliasing these.
,
Sep 13 2017
,
Oct 11 2017
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c9ac4a4e74219b922eec1eef132047470c03e1a commit 7c9ac4a4e74219b922eec1eef132047470c03e1a Author: Siddhartha <ssid@chromium.org> Date: Wed Oct 18 03:35:58 2017 Add leveldb block cache memory dumps with appropriate sizes The block cache is shared across multiple databases. So, calculate the correct sizes of each leveldb database for the memory dumps. Bug: 758267 Change-Id: I4ca76422754c0a7fce46354f79631362d5553cdc Reviewed-on: https://chromium-review.googlesource.com/667916 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by: Michael Nordman <michaeln@chromium.org> Reviewed-by: Dmitry Skiba <dskiba@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Chris Mumford <cmumford@chromium.org> Reviewed-by: Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#509677} [modify] https://crrev.com/7c9ac4a4e74219b922eec1eef132047470c03e1a/base/trace_event/memory_infra_background_whitelist.cc [modify] https://crrev.com/7c9ac4a4e74219b922eec1eef132047470c03e1a/content/browser/dom_storage/session_storage_database.cc [modify] https://crrev.com/7c9ac4a4e74219b922eec1eef132047470c03e1a/content/browser/indexed_db/leveldb/leveldb_database.cc [modify] https://crrev.com/7c9ac4a4e74219b922eec1eef132047470c03e1a/extensions/browser/value_store/leveldb_value_store.cc [modify] https://crrev.com/7c9ac4a4e74219b922eec1eef132047470c03e1a/third_party/leveldatabase/env_chromium.cc [modify] https://crrev.com/7c9ac4a4e74219b922eec1eef132047470c03e1a/third_party/leveldatabase/env_chromium.h [modify] https://crrev.com/7c9ac4a4e74219b922eec1eef132047470c03e1a/third_party/leveldatabase/env_chromium_unittest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by cmumford@chromium.org
, Aug 23 2017