New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 758265 link

Starred by 3 users
Status: Fixed
Owner:
█ meganlindsay@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task
Proj-XR



Sign in to add a comment

Add M62 WebVR origin trial

Project Member Reported by meganlindsay@chromium.org, Aug 23 2017 
Need to add our new M62 origin trial to Chrome.

From amp@ who did this with previous trials:
I think it might have changed a bit recently (some parts of the origin trial setup were automated), probably start with search for our trial name: https://cs.chromium.org/search/?q=WebVR1.1  My the changes from the last iteration are here (they should have been together, but we missed that the second file needed to be updated which may not be the case anymore): https://codereview.chromium.org/2830123002, https://codereview.chromium.org/2839753004

Comment 1 by mthiesse@chromium.org, Aug 23 2017

Owner: mthiesse@chromium.org
Status: Assigned (was: Available)

Comment 2 by mthiesse@chromium.org, Aug 23 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3485378ec4a469e9c0f7aba89b93f7cfb9995cd6

commit 3485378ec4a469e9c0f7aba89b93f7cfb9995cd6
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Thu Aug 24 16:15:29 2017

Rename WebVR origin trial for M62

Bug:  758265 
Change-Id: I811105f90d987186d529f593c1b48e2b49aa1d0d
Reviewed-on: https://chromium-review.googlesource.com/630136
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497073}
[modify] https://crrev.com/3485378ec4a469e9c0f7aba89b93f7cfb9995cd6/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Comment 4 by mthiesse@chromium.org, Aug 24 2017

Owner: meganlindsay@chromium.org
Back over to Megan for the OT signup work.

Comment 5 by meganlindsay@chromium.org, Sep 8 2017

Status: Fixed (was: Started)

Comment 6 by btebbs@chromium.org, Jul 4

Components: Blink>WebXR
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c87a0a4aaa5076c66a51b6010a8d1d87573848a

commit 5c87a0a4aaa5076c66a51b6010a8d1d87573848a
Author: Bill Orr <billorr@chromium.org>
Date: Fri Jul 20 00:59:24 2018

Remove the WebVR Origin Trial.

As previously announced (https://groups.google.com/a/chromium.org/d/msg/blink-dev/-s4pWwshKhI/M78h2_scBwAJ), the WebVR Origin Trial is ending after M68 as WebVR is replaced by the WebXR Device API and Origin Trial.

WebVR can still be manually enabled through chrome://flags.

BUG= 758265 

Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I752ac8d61c8436abd80a511cc66d4aad502d0245
Reviewed-on: https://chromium-review.googlesource.com/1144278
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576732}
[modify] https://crrev.com/5c87a0a4aaa5076c66a51b6010a8d1d87573848a/third_party/blink/renderer/modules/gamepad/gamepad.idl
[modify] https://crrev.com/5c87a0a4aaa5076c66a51b6010a8d1d87573848a/third_party/blink/renderer/modules/gamepad/gamepad_pose.idl
[modify] https://crrev.com/5c87a0a4aaa5076c66a51b6010a8d1d87573848a/third_party/blink/renderer/modules/gamepad/navigator_gamepad.cc
[modify] https://crrev.com/5c87a0a4aaa5076c66a51b6010a8d1d87573848a/third_party/blink/renderer/modules/modules_initializer.cc
[modify] https://crrev.com/5c87a0a4aaa5076c66a51b6010a8d1d87573848a/third_party/blink/renderer/modules/vr/navigator_vr.idl
[modify] https://crrev.com/5c87a0a4aaa5076c66a51b6010a8d1d87573848a/third_party/blink/renderer/modules/vr/vr_display.idl
[modify] https://crrev.com/5c87a0a4aaa5076c66a51b6010a8d1d87573848a/third_party/blink/renderer/modules/vr/vr_display_capabilities.idl
[modify] https://crrev.com/5c87a0a4aaa5076c66a51b6010a8d1d87573848a/third_party/blink/renderer/modules/vr/vr_display_event.idl
[modify] https://crrev.com/5c87a0a4aaa5076c66a51b6010a8d1d87573848a/third_party/blink/renderer/modules/vr/vr_eye_parameters.idl
[modify] https://crrev.com/5c87a0a4aaa5076c66a51b6010a8d1d87573848a/third_party/blink/renderer/modules/vr/vr_frame_data.idl
[modify] https://crrev.com/5c87a0a4aaa5076c66a51b6010a8d1d87573848a/third_party/blink/renderer/modules/vr/vr_pose.idl
[modify] https://crrev.com/5c87a0a4aaa5076c66a51b6010a8d1d87573848a/third_party/blink/renderer/modules/vr/vr_stage_parameters.idl
[modify] https://crrev.com/5c87a0a4aaa5076c66a51b6010a8d1d87573848a/third_party/blink/renderer/platform/runtime_enabled_features.json5
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef7c3e6709840afb9f1aec93534cca56240708c2

commit ef7c3e6709840afb9f1aec93534cca56240708c2
Author: Bill Orr <billorr@chromium.org>
Date: Tue Oct 02 21:04:35 2018

Revert "Remove the WebVR Origin Trial."

This reverts commit 5c87a0a4aaa5076c66a51b6010a8d1d87573848a.

Reason for revert: Re-enabling processing of WebVR Origin Trial tokens.

BUG=891425

Original change's description:
> Remove the WebVR Origin Trial.
>
> As previously announced (https://groups.google.com/a/chromium.org/d/msg/blink-dev/-s4pWwshKhI/M78h2_scBwAJ), the WebVR Origin Trial is ending after M68 as WebVR is replaced by the WebXR Device API and Origin Trial.
>
> WebVR can still be manually enabled through chrome://flags.
>
> BUG= 758265 
>
> Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I752ac8d61c8436abd80a511cc66d4aad502d0245
> Reviewed-on: https://chromium-review.googlesource.com/1144278
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Brandon Jones <bajones@chromium.org>
> Reviewed-by: David Dorwin <ddorwin@chromium.org>
> Commit-Queue: Bill Orr <billorr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576732}

TBR=ddorwin@chromium.org,dcheng@chromium.org,bajones@chromium.org,billorr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  758265 
Change-Id: Ic1be18fa173aa9a5ec90c3f5c8b388cc610c76d1
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1257670
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595977}
[modify] https://crrev.com/ef7c3e6709840afb9f1aec93534cca56240708c2/third_party/blink/renderer/modules/gamepad/gamepad.idl
[modify] https://crrev.com/ef7c3e6709840afb9f1aec93534cca56240708c2/third_party/blink/renderer/modules/gamepad/gamepad_pose.idl
[modify] https://crrev.com/ef7c3e6709840afb9f1aec93534cca56240708c2/third_party/blink/renderer/modules/gamepad/navigator_gamepad.cc
[modify] https://crrev.com/ef7c3e6709840afb9f1aec93534cca56240708c2/third_party/blink/renderer/modules/modules_initializer.cc
[modify] https://crrev.com/ef7c3e6709840afb9f1aec93534cca56240708c2/third_party/blink/renderer/modules/vr/navigator_vr.idl
[modify] https://crrev.com/ef7c3e6709840afb9f1aec93534cca56240708c2/third_party/blink/renderer/modules/vr/vr_display.idl
[modify] https://crrev.com/ef7c3e6709840afb9f1aec93534cca56240708c2/third_party/blink/renderer/modules/vr/vr_display_capabilities.idl
[modify] https://crrev.com/ef7c3e6709840afb9f1aec93534cca56240708c2/third_party/blink/renderer/modules/vr/vr_display_event.idl
[modify] https://crrev.com/ef7c3e6709840afb9f1aec93534cca56240708c2/third_party/blink/renderer/modules/vr/vr_eye_parameters.idl
[modify] https://crrev.com/ef7c3e6709840afb9f1aec93534cca56240708c2/third_party/blink/renderer/modules/vr/vr_frame_data.idl
[modify] https://crrev.com/ef7c3e6709840afb9f1aec93534cca56240708c2/third_party/blink/renderer/modules/vr/vr_pose.idl
[modify] https://crrev.com/ef7c3e6709840afb9f1aec93534cca56240708c2/third_party/blink/renderer/modules/vr/vr_stage_parameters.idl
[modify] https://crrev.com/ef7c3e6709840afb9f1aec93534cca56240708c2/third_party/blink/renderer/platform/runtime_enabled_features.json5
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 2

Labels: merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87d8452408c5b674c670f1c1406ee7113f9b3c33

commit 87d8452408c5b674c670f1c1406ee7113f9b3c33
Author: Bill Orr <billorr@chromium.org>
Date: Tue Oct 02 22:43:32 2018

Revert "Remove the WebVR Origin Trial."

This reverts commit 5c87a0a4aaa5076c66a51b6010a8d1d87573848a.

Reason for revert: Re-enabling processing of WebVR Origin Trial tokens.

BUG=891425

Original change's description:
> Remove the WebVR Origin Trial.
>
> As previously announced (https://groups.google.com/a/chromium.org/d/msg/blink-dev/-s4pWwshKhI/M78h2_scBwAJ), the WebVR Origin Trial is ending after M68 as WebVR is replaced by the WebXR Device API and Origin Trial.
>
> WebVR can still be manually enabled through chrome://flags.
>
> BUG= 758265 
>
> Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I752ac8d61c8436abd80a511cc66d4aad502d0245
> Reviewed-on: https://chromium-review.googlesource.com/1144278
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Brandon Jones <bajones@chromium.org>
> Reviewed-by: David Dorwin <ddorwin@chromium.org>
> Commit-Queue: Bill Orr <billorr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576732}

TBR=ddorwin@chromium.org,dcheng@chromium.org,bajones@chromium.org,billorr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  758265 
Change-Id: Ic1be18fa173aa9a5ec90c3f5c8b388cc610c76d1
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1257670
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#595977}(cherry picked from commit ef7c3e6709840afb9f1aec93534cca56240708c2)
Reviewed-on: https://chromium-review.googlesource.com/c/1258308
Cr-Commit-Position: refs/branch-heads/3538@{#831}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/87d8452408c5b674c670f1c1406ee7113f9b3c33/third_party/blink/renderer/modules/gamepad/gamepad.idl
[modify] https://crrev.com/87d8452408c5b674c670f1c1406ee7113f9b3c33/third_party/blink/renderer/modules/gamepad/gamepad_pose.idl
[modify] https://crrev.com/87d8452408c5b674c670f1c1406ee7113f9b3c33/third_party/blink/renderer/modules/gamepad/navigator_gamepad.cc
[modify] https://crrev.com/87d8452408c5b674c670f1c1406ee7113f9b3c33/third_party/blink/renderer/modules/modules_initializer.cc
[modify] https://crrev.com/87d8452408c5b674c670f1c1406ee7113f9b3c33/third_party/blink/renderer/modules/vr/navigator_vr.idl
[modify] https://crrev.com/87d8452408c5b674c670f1c1406ee7113f9b3c33/third_party/blink/renderer/modules/vr/vr_display.idl
[modify] https://crrev.com/87d8452408c5b674c670f1c1406ee7113f9b3c33/third_party/blink/renderer/modules/vr/vr_display_capabilities.idl
[modify] https://crrev.com/87d8452408c5b674c670f1c1406ee7113f9b3c33/third_party/blink/renderer/modules/vr/vr_display_event.idl
[modify] https://crrev.com/87d8452408c5b674c670f1c1406ee7113f9b3c33/third_party/blink/renderer/modules/vr/vr_eye_parameters.idl
[modify] https://crrev.com/87d8452408c5b674c670f1c1406ee7113f9b3c33/third_party/blink/renderer/modules/vr/vr_frame_data.idl
[modify] https://crrev.com/87d8452408c5b674c670f1c1406ee7113f9b3c33/third_party/blink/renderer/modules/vr/vr_pose.idl
[modify] https://crrev.com/87d8452408c5b674c670f1c1406ee7113f9b3c33/third_party/blink/renderer/modules/vr/vr_stage_parameters.idl
[modify] https://crrev.com/87d8452408c5b674c670f1c1406ee7113f9b3c33/third_party/blink/renderer/platform/runtime_enabled_features.json5
►

Sign in to add a comment