New issue
Advanced search Search tips

Issue 758263 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 618368



Sign in to add a comment

L3 should fall back to surfacetexture more often

Project Member Reported by liber...@chromium.org, Aug 23 2017

Issue description

faliure to promote l3 to an overlay should fall back to SurfaceTexture rather than not be displayed.  prior to M62, it was always using SurfaceTexture anyway, so we don't want to break existing things.

separately, we should enable "must promote" overlays for android in the compositor.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca1b457a481d067c3014f62820d1b25fb4b3da86

commit ca1b457a481d067c3014f62820d1b25fb4b3da86
Author: liberato@chromium.org <liberato@chromium.org>
Date: Mon Aug 28 21:27:20 2017

Let L3 video fall back to SurfaceTexture.

Previously, L3 video would use an overlay, even if the compositor
would refuse to promote the overlay.  This would cause the video to
disappear in those cases.

To avoid changing the existing behavior too much, we now fall back
to SurfaceTexture in those cases.

Bug:  758263 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0a0c9e54f8a80abd1c8ac6154fda9580c33c4561
Reviewed-on: https://chromium-review.googlesource.com/629356
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497882}
[modify] https://crrev.com/ca1b457a481d067c3014f62820d1b25fb4b3da86/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/ca1b457a481d067c3014f62820d1b25fb4b3da86/media/gpu/android_video_surface_chooser.h
[modify] https://crrev.com/ca1b457a481d067c3014f62820d1b25fb4b3da86/media/gpu/android_video_surface_chooser_impl.cc
[modify] https://crrev.com/ca1b457a481d067c3014f62820d1b25fb4b3da86/media/gpu/android_video_surface_chooser_impl_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment