New issue
Advanced search Search tips

Issue 758252 link

Starred by 1 user
Status: Fixed
Owner:
michaeldo@chromium.org
Closed: Nov 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task
Team-Security-UX



Sign in to add a comment

Show url domain for iOS Captive Portal page

Project Member Reported by michaeldo@chromium.org, Aug 23 2017 
The iOS Captive Portal page should display the captive portal url domain.

From:
https://chromium-review.googlesource.com/c/chromium/src/+/591691/2/ios/chrome/browser/ui/ssl/captive_portal_login_view_controller.mm#1

In general we consider showing web contents without a URL as a low severity security bug (e.g. crbug.com/698906) so I think we should display the URL. In this case, just showing the origin and dropping the path should be sufficient. You can use url_formatter::FormatUrlForSecurityDisplay() for this. According to its documentation, this function should safely handle internationalized domain names and RTL.

Comment 1 by michaeldo@chromium.org, Oct 12 2017

Status: Started (was: Assigned)
I've started this and attached a sample screenshot of the current UI.
Simulator Screen Shot - iPhone 7 - 2017-10-12 at 14.31.33.png
159 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a10a6506912919c5dda60e3b8023b039c6065753

commit a10a6506912919c5dda60e3b8023b039c6065753
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Fri Oct 13 22:19:21 2017

Add landing URL to iOS Captive Portal Log In Page.

Bug:  758252 
Change-Id: I6719e921e5f48559c13c4fa9fdbc82ddd1e25389
Reviewed-on: https://chromium-review.googlesource.com/716873
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508843}
[modify] https://crrev.com/a10a6506912919c5dda60e3b8023b039c6065753/ios/chrome/browser/ui/captive_portal/BUILD.gn
[modify] https://crrev.com/a10a6506912919c5dda60e3b8023b039c6065753/ios/chrome/browser/ui/captive_portal/captive_portal_login_view_controller.mm
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66e5881e60de5d905202275ce1f7edb804e6c786

commit 66e5881e60de5d905202275ce1f7edb804e6c786
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Fri Nov 03 06:54:28 2017

Open Captive Portal Login page in a new tab instead of modal UI.

Using a new tab is consistent with other platforms, and solves security
concerns with the modal by eliminating a new UI surface. 

Bug:  779587 ,  758252 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I05d1db266fb93493c010661d567b3ae15a9929e9
Reviewed-on: https://chromium-review.googlesource.com/740365
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513714}
[modify] https://crrev.com/66e5881e60de5d905202275ce1f7edb804e6c786/ios/chrome/browser/ssl/BUILD.gn
[modify] https://crrev.com/66e5881e60de5d905202275ce1f7edb804e6c786/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/66e5881e60de5d905202275ce1f7edb804e6c786/ios/chrome/browser/ui/browser_view_controller.mm
[delete] https://crrev.com/b7c153bd16db1cffae948a57315df053531a530a/ios/chrome/browser/ui/captive_portal/BUILD.gn
[delete] https://crrev.com/b7c153bd16db1cffae948a57315df053531a530a/ios/chrome/browser/ui/captive_portal/captive_portal_login_coordinator.h
[delete] https://crrev.com/b7c153bd16db1cffae948a57315df053531a530a/ios/chrome/browser/ui/captive_portal/captive_portal_login_coordinator.mm
[delete] https://crrev.com/b7c153bd16db1cffae948a57315df053531a530a/ios/chrome/browser/ui/captive_portal/captive_portal_login_coordinator_unittest.mm
[delete] https://crrev.com/b7c153bd16db1cffae948a57315df053531a530a/ios/chrome/browser/ui/captive_portal/captive_portal_login_view_controller.h
[delete] https://crrev.com/b7c153bd16db1cffae948a57315df053531a530a/ios/chrome/browser/ui/captive_portal/captive_portal_login_view_controller.mm
[delete] https://crrev.com/b7c153bd16db1cffae948a57315df053531a530a/ios/chrome/browser/ui/captive_portal/captive_portal_login_view_controller_delegate.h
[modify] https://crrev.com/66e5881e60de5d905202275ce1f7edb804e6c786/ios/chrome/test/BUILD.gn

Comment 4 by michaeldo@chromium.org, Nov 3 2017

Status: Fixed (was: Started)
►

Sign in to add a comment