New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 758234 link

Starred by 1 user
Status: Verified
Owner:
xiy...@chromium.org
Closed: Aug 2017
Cc:
█ mlight@chromium.org
█ sduraisamy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Kiosk app launch splash screen layout issue when display size is changed

Project Member Reported by xiy...@chromium.org, Aug 23 2017 
Internal bug: b/64737751

Repro steps:
1. Have two displays connected to CfM device;
2. Set the smaller one as primary display;
3. Let the kiosk app run and look at the icon and title;

At step 3, the app icon/title is off the center of the screen.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7de60db9b64519befed7d27e7644420a682fbfe

commit d7de60db9b64519befed7d27e7644420a682fbfe
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Wed Aug 23 18:05:50 2017

kiosk: Update splash screen size on display size change

When display size changes, Oobe.updateScreenSize should be
called again to update app launch screen with new width/height
so that icon, status divs are properly placed.

BUG= 758234 , b/64737751

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie23cea9681794fe10d2bd37b588ecefcd728d317
Reviewed-on: https://chromium-review.googlesource.com/627599
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496736}
[modify] https://crrev.com/d7de60db9b64519befed7d27e7644420a682fbfe/chrome/browser/resources/chromeos/login/screen_app_launch_splash.js

Comment 2 by xiy...@chromium.org, Aug 23 2017

Labels: Merge-Request-61
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 23 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by keta...@chromium.org, Aug 23 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 23 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0df28d7873577c51a00eb428f8c4f714d0831fd7

commit 0df28d7873577c51a00eb428f8c4f714d0831fd7
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Wed Aug 23 19:43:55 2017

Merge M61 "kiosk: Update splash screen size on display size change"

> When display size changes, Oobe.updateScreenSize should be
> called again to update app launch screen with new width/height
> so that icon, status divs are properly placed.
>
> BUG= 758234 , b/64737751
>
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: Ie23cea9681794fe10d2bd37b588ecefcd728d317
> Reviewed-on: https://chromium-review.googlesource.com/627599
> Reviewed-by: Jenny Zhang <jennyz@chromium.org>
> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#496736}
> (cherry picked from commit d7de60db9b64519befed7d27e7644420a682fbfe)

TBR=xiyuan@chromium.org

Change-Id: I66d4edeb445c9d1b9e1cdf2df3923ba23fb6aea7
Reviewed-on: https://chromium-review.googlesource.com/629736
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#833}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/0df28d7873577c51a00eb428f8c4f714d0831fd7/chrome/browser/resources/chromeos/login/screen_app_launch_splash.js

Comment 6 by xiy...@chromium.org, Aug 23 2017

Status: Fixed (was: Assigned)

Comment 7 by krishna...@chromium.org, Aug 29 2017

Cc: mlight@chromium.org

Comment 8 by mlight@chromium.org, Sep 7 2017

Status: Verified (was: Fixed)
Verified in M61 Beta build 9765.53.0.
►

Sign in to add a comment