New issue
Advanced search Search tips

Issue 758232 link

Starred by 1 user
Status: Fixed
Owner:
tzik@chromium.org
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: ----
Type: ----



Sign in to add a comment

ObfuscatedFileUtilTest.TestRevokeUsageCache is flaky

Project Member Reported by iclell...@chromium.org, Aug 23 2017 
The ObfuscatedFileUtilTest.TestRevokeUsageCache seems to fail quite often -- the test runner automatically reruns it, so *most* of the time it will pass. Very occsaionally it will fail four times in a row though, and show up as a test failure.

storage_unittests failing on chromium.chromiumos/Linux ChromiumOS Tests (1)

Builders failed on: 
- Linux ChromiumOS Tests (1): 
  https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29


Flakiness dashboard results:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=storage_unittests&tests=ObfuscatedFileUtilTest.TestRevokeUsageCache

Failures (mostly of the form "FAIL FAIL PASS") appear on all platforms. The actual symptom seems to be that QuotaManager::GetUsageAndQuota is returning kQuotaStatusUnknown rather than kQuotaStatusOK, but I haven't traced it through to see why that could happen)

Disabling the test as flaky until there's at least some idea why this could happen.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4cf2cdf40309bde8ffbb542d7808421a4ff378a

commit a4cf2cdf40309bde8ffbb542d7808421a4ff378a
Author: Ian Clelland <iclelland@google.com>
Date: Wed Aug 23 16:54:50 2017

Disable flaky ObfuscatedFileUtilTest.TestRevokeUsageCache

The test is much flakier than the build status suggests, as it
frequently fails one to three times before succeeding within a single
build.

Bug:  758232 
Change-Id: I815bea6ea3a72ea383d41728dfb18301118b0af4
TBR: tzik@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/629045
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496715}
[modify] https://crrev.com/a4cf2cdf40309bde8ffbb542d7808421a4ff378a/storage/browser/fileapi/obfuscated_file_util_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c07ef7afe838f5b9d983cb7907b9cb082963da14

commit c07ef7afe838f5b9d983cb7907b9cb082963da14
Author: tzik <tzik@chromium.org>
Date: Fri Aug 25 05:22:47 2017

Deflake ObfuscatedFileUtilTest..TestRevokeUsageCache

AsyncFileTestHelper::GetUsageAndQuota waits for QuotaManager to complete
its GetUsageAndQuota until the current message loop is idle. However,
it may post a job to other thread, and the idle loop doesn't imply the
task completion.

After this change, AsyncFileTestHelper waits for the completion until
the completion callback runs.

Bug:  758232 
Change-Id: I9a6bd65b14affa1a322ae447dd315b6f8e95a439
Reviewed-on: https://chromium-review.googlesource.com/634087
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497328}
[modify] https://crrev.com/c07ef7afe838f5b9d983cb7907b9cb082963da14/storage/browser/fileapi/obfuscated_file_util_unittest.cc
[modify] https://crrev.com/c07ef7afe838f5b9d983cb7907b9cb082963da14/storage/browser/test/async_file_test_helper.cc

Comment 3 by tzik@chromium.org, Aug 25 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment