New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758225 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

searchbox placeholder text should be centered.

Project Member Reported by newcomer@chromium.org, Aug 23 2017

Issue description

The searchbox placeholder text is not perfectly centered.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 23 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: warx@chromium.org
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.

Comment 4 by warx@chromium.org, Aug 24 2017

Issue 758614 has been merged into this issue.

Comment 5 by warx@chromium.org, Aug 24 2017

Cc: warx@chromium.org
Owner: hejq@chromium.org
Assigned to hejq@ for work triage.

This is because we centered in the textfield, which is laid out beside the search icon. I think it happened after we removed the mic icon.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cfbef66aba08e14528f202298ccc4df38c0eafe

commit 3cfbef66aba08e14528f202298ccc4df38c0eafe
Author: Jiaquan He <hejq@google.com>
Date: Fri Aug 25 19:43:01 2017

Center the searchbox placeholder.

Bug:  758225 
Change-Id: Ie0a730d8c05351716d9fa8d3578827166fe29001
Reviewed-on: https://chromium-review.googlesource.com/633859
Commit-Queue: Jiaquan He <hejq@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497502}
[modify] https://crrev.com/3cfbef66aba08e14528f202298ccc4df38c0eafe/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/3cfbef66aba08e14528f202298ccc4df38c0eafe/ui/app_list/views/search_box_view.h

Comment 7 by hejq@chromium.org, Aug 25 2017

Status: Fixed (was: Assigned)
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 28 2017

Cc: keta...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 30 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24b68072c33876c6c01dca4078380106fe1d2039

commit 24b68072c33876c6c01dca4078380106fe1d2039
Author: Maajid <maajid@chromium.org>
Date: Wed Aug 30 22:34:49 2017

Center the searchbox placeholder.

TBR=hejq@google.com

(cherry picked from commit 3cfbef66aba08e14528f202298ccc4df38c0eafe)

Bug:  758225 
Change-Id: Ie0a730d8c05351716d9fa8d3578827166fe29001
Reviewed-on: https://chromium-review.googlesource.com/633859
Commit-Queue: Jiaquan He <hejq@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497502}
Reviewed-on: https://chromium-review.googlesource.com/644569
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1014}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/24b68072c33876c6c01dca4078380106fe1d2039/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/24b68072c33876c6c01dca4078380106fe1d2039/ui/app_list/views/search_box_view.h

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment