Assigning to the single owner in chrome/browser/ui/views/bookmarks

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/377e89cec43661b085c3541cdbce1148e616390c

commit 377e89cec43661b085c3541cdbce1148e616390c
Author: Ian Clelland <iclelland@google.com>
Date: Wed Aug 23 16:06:49 2017

Disable flaking BookmarkBarViewTest5.DND on ChromeOS

This test has failed 6 times in the last 150 or so runs, so it's
*mostly* stable, but occasionally fails with a message like:

[FATAL:env.cc(74)] Check failed: env. Env::CreateInstance must be called
before getting the instance of Env.

Bug: 758210
Change-Id: Ia5b9c441c34971e05ba3053fd556d7c61515a1c7
TBR: pkotwicz@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/628582
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496698}
[modify] https://crrev.com/377e89cec43661b085c3541cdbce1148e616390c/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

**UI mass Triage**

Assuming the issue may be fixed since there is no activity, hence closing.If you feel this issue should still be addressed, please to reopen it or to file a new issue.

Thanks..!!

Test is still disabled, so not fixed.

Setting default priority

Also flaky on non-ASAN, latest logs indicate a threading issue ui::ViewProp::Data::Get with kWindowTreeHostForAcceleratedWidget as the key. I suspect gpu.cc::FinishOnMain() -> Gpu::OnEstablishedGpuChannel() --- (invokes MusContextFactory::OnEstablishedGpuChannel() posted by MusContextFactory::CreateLayerTreeFrameSink()) --> MusContextFactory::OnEstablishedGpuChannel() -> WindowTreeHost::GetForAcceleratedWidget().

gpu.cc::FinishOnMain has two paths (one which isn't on |main_task_runner_|) and as such it ultimately invoking ViewProp::Data::Get can come on the wrong thread (thus doing an AddRef on the wrong sequence and DCHECKing when it's called from the right (UI) sequence later per the SequenceChecker having bound to the incorrect sequence).


[ RUN      ] BookmarkBarViewTest5.DND
Xlib:  extension "RANDR" missing on display ":100".
[16933:16940:0117/114750.331623:3350653077:FATAL:ref_counted.h(63)] Check failed: CalledOnValidSequence().
#0 0x7fcd33677e89 base::debug::StackTrace::StackTrace()
#1 0x7fcd334c0aa5 base::debug::StackTrace::StackTrace()
#2 0x7fcd334ff8c3 logging::LogMessage::~LogMessage()
#3 0x7fcd32c3524a base::subtle::RefCountedBase::AddRef()
#4 0x7fcd32c35035 base::RefCounted<>::AddRef()
#5 0x7fcd32c35015 scoped_refptr<>::AddRef()
#6 0x7fcd32c34d95 scoped_refptr<>::scoped_refptr()
#7 0x7fcd32c34e08 scoped_refptr<>::operator=()
#8 0x7fcd32c34bac ui::ViewProp::Data::Get()
#9 0x7fcd32c34a1c ui::ViewProp::GetValue()
#10 0x7fcd2a20938c aura::WindowTreeHost::GetForAcceleratedWidget()
#11 0x7fcd33e937d5 views::DesktopWindowTreeHostX11::GetContentWindowForXID()
#12 0x7fcd33e9d4ac std::__Cr::transform<>()
#13 0x7fcd33e938f7 views::DesktopWindowTreeHostX11::GetAllOpenWindows()
#14 0x558d7a099df2 views::test::(anonymous namespace)::UIControlsDesktopX11::RootWindowForPoint()
#15 0x558d7a099499 views::test::(anonymous namespace)::UIControlsDesktopX11::SendMouseMoveNotifyWhenDone()
#16 0x558d7a0993ea views::test::(anonymous namespace)::UIControlsDesktopX11::SendMouseMove()
#17 0x558d7c5abca1 ui_controls::SendMouseMove()
#18 0x558d7a04838d base::internal::FunctorTraits<>::Invoke<>()
#19 0x558d7a048337 base::internal::FunctorTraits<>::Invoke<>()
#20 0x558d7a0482e7 base::internal::InvokeHelper<>::MakeItSo<>()
#21 0x558d7a048293 _ZN4base8internal7InvokerINS0_9BindStateINS0_18IgnoreResultHelperIPFbllEEEJiiEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJiiEEEJLm0ELm1EEEEvOT_OT0_NSB_16integer_sequenceImJXspT1_EEEE
#22 0x558d7a04819e base::internal::Invoker<>::RunOnce()
#23 0x7fcd33497d4e _ZNO4base12OnceCallbackIFvvEE3RunEv
#24 0x7fcd334c1c4b base::debug::TaskAnnotator::RunTask()
#25 0x7fcd3351999b base::MessageLoopImpl::RunTask()
#26 0x7fcd33519c88 base::MessageLoopImpl::DeferOrRunPendingTask()
#27 0x7fcd3351a516 base::MessageLoopImpl::DoWork()
#28 0x7fcd3351e6c7 base::MessagePumpDefault::Run()
#29 0x7fcd335191ff base::MessageLoopImpl::Run()
#30 0x7fcd335723b1 base::RunLoop::Run()
#31 0x7fcd33619898 base::Thread::Run()
#32 0x7fcd33619ff8 base::Thread::ThreadMain()
#33 0x7fcd3369c13a base::(anonymous namespace)::ThreadFunc()
#34 0x7fcd148e3184 start_thread
#35 0x7fcd1172703d clone

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77c1ce0e8d6e3e4249ebfc99a42e4a73591b4b9e

commit 77c1ce0e8d6e3e4249ebfc99a42e4a73591b4b9e
Author: Gabriel Charette <gab@chromium.org>
Date: Fri Jan 18 18:27:23 2019

Disable flaky BookmarkBarViewTest5.DND on Linux; re-enable on Windows.

TBR=sky@chromium.org

Bug: 758210
Change-Id: I85e46623388adf3d3a2ef02463ef2241196af749
Reviewed-on: https://chromium-review.googlesource.com/c/1422161
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624204}
[modify] https://crrev.com/77c1ce0e8d6e3e4249ebfc99a42e4a73591b4b9e/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98fc6f195ceb0426f8e227df9248d55c1330aa13

commit 98fc6f195ceb0426f8e227df9248d55c1330aa13
Author: Gabriel Charette <gab@chromium.org>
Date: Fri Jan 18 21:44:20 2019

Disable BookmarkBarViewTest5.DND on all platforms

It's flaky on all views platforms.

TBR=sky@chromium.org

Bug: 758210
Change-Id: Icb4bf63cb68518b1ba34decefd241baa3a5810e6
Reviewed-on: https://chromium-review.googlesource.com/c/1422381
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624301}
[modify] https://crrev.com/98fc6f195ceb0426f8e227df9248d55c1330aa13/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

I'm working on this