Issue metadata
Sign in to add a comment
|
5.3% regression in thread_times.key_silk_cases at 494322:494622 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Aug 23 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8970460636468047312
,
Aug 23 2017
=== Auto-CCing suspected CL author mstensho@opera.com === Hi mstensho@opera.com, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Morten Stenshorne Commit : c1bb58b26ee6e0d792f6e8aff9a3126cc2fa29af Date : Tue Aug 15 19:20:31 2017 Subject: When main axis is logical y, lay out flex items before getting intrinsic size. Bisect Details Configuration: android_webview_nexus6_aosp_perf_bisect Benchmark : thread_times.key_silk_cases Metric : thread_total_fast_path_cpu_time_per_frame/inbox_app.html?toggle_drawer Change : 5.65% | 8.70500033516 -> 9.1965221223 Revision Result N chromium@494321 8.705 +- 0.144533 6 good chromium@494472 8.73553 +- 0.282965 6 good chromium@494482 8.63729 +- 0.167056 6 good chromium@494487 8.65596 +- 0.167363 6 good chromium@494488 9.1255 +- 0.338329 6 bad <-- chromium@494489 9.07589 +- 0.21019 6 bad chromium@494491 9.09145 +- 0.266135 6 bad chromium@494510 9.05031 +- 0.162114 6 bad chromium@494547 9.13253 +- 0.274768 6 bad chromium@494622 9.19652 +- 0.285791 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=inbox.app.html.toggle.drawer thread_times.key_silk_cases More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8970460636468047312 For feedback, file a bug with component Speed>Bisection
,
Aug 23 2017
Issue 758231 has been merged into this issue.
,
Aug 23 2017
Issue 758202 has been merged into this issue.
,
Aug 23 2017
I'm afraid that will have to be the new baseline, and that we simply have to accept this flexbox performance decrease. The bug was that we didn't re-layout as much as necessary, and the fix was to re-layout more. So we have become slightly slower in such scenarios.
,
Aug 29 2017
,
Aug 29 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Aug 23 2017