New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758191 link

Starred by 3 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Make the system_health.common_desktop benchmark to start only after initialization of critical sqlite databases

Project Member Reported by pasko@chromium.org, Aug 23 2017

Issue description

In  Issue 737394  we discovered that changing the order of initialization of (empty) sqlite databases may affect a non-startup benchmark system_health.common_desktop.

Looking closer revealed that db initialization continues for a few seconds _after_ the measurements start. In Telemetry the DesktopBrowserBackend._WaitForBrowserToComeUp polls every 100ms and hence tiny changes leading to that being triggered earlier will increase the measurements by up to a 100ms.

In the related Issue 726937 we see a proposal to also reduce the amount of background tasks when benchmarking. It should hopefully help reducing the overall time to run the benchmark.

Let's make _WaitForBrowserToComeUp to wait until Chrome is 'more idle'.

A highly speculative list of databases to wait for (based on a few examined traces) is:
* previews_opt_out_store_sql
* data_reduction_proxy_service
* model_type_store_impl
* top_sites_backend
* proto_database_impl
* web_database_service

Consequences:
* It is not clear how to maintain this list. Hopefully we can add things as we see wontfix-ed perf regressions?
* Increases the time to run this benchmark by a few seconds.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 23

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment