New issue
Advanced search Search tips

Issue 758189 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

9.8% regression in system_health.memory_mobile at 491973:492049

Project Member Reported by nzolghadr@chromium.org, Aug 23 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 23 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=758189

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=8f03a0ea418aa914867e680283e8c419d2feca84528445f5d5a272f2b2eecf38


Bot(s) for this bug's original alert(s):

android-webview-nexus5X
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 23 2017

Cc: agrieve@chromium.org
Owner: agrieve@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author agrieve@chromium.org ===

Hi agrieve@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Andrew Grieve
  Commit : 2ae3701ed1f5331e0cbc69bb2bd375c4d3375fe9
  Date   : Fri Aug 04 14:16:43 2017
  Subject: Reland of Android: Make all targets depend on specific play services targets

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_os:system_memory:java_heap:proportional_resident_size_avg/load_search/load_search_google
  Change       : 4.06% | 5182464.0 -> 4972202.66667

Revision             Result                  N
chromium@491972      5182464 +- 69027.0      6      good
chromium@492011      5275307 +- 85461.6      6      good
chromium@492016      5353131 +- 136793       6      good
chromium@492019      5388629 +- 143818       6      good
chromium@492020      5426176 +- 157550       6      good
chromium@492021      5047979 +- 71748.2      6      bad       <--
chromium@492030      5045248 +- 126745       6      bad
chromium@492049      4972203 +- 70865.9      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.search.google system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8970462426274201488


For feedback, file a bug with component Speed>Bisection
Cc: perezju@chromium.org
Owner: ----
Looks like agrieve's CL REDUCED memory, if the bisect can be trusted. perezju, any idea what may be going on here?
Status: WontFix (was: Assigned)
Yep, it's true. Java Heap actually went down after that change:

https://chromeperf.appspot.com/report?sid=753de46a1b479427a0f01ad9eb7a76bc62c4c00d26454efacee3f3b07c989aa4&rev=492049

(also see attached image from bisect data)

The "regression" and large noise in the waterfall is probably due to issue 690042, on which I'm actively working now.
java_heap_improves.png
27.5 KB View Download
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Aug 23 2017


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Andrew Grieve
  Commit : 2ae3701ed1f5331e0cbc69bb2bd375c4d3375fe9
  Date   : Fri Aug 04 14:16:43 2017
  Subject: Reland of Android: Make all targets depend on specific play services targets

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_os:system_memory:java_heap:proportional_resident_size_avg/load_news/load_news_wikipedia
  Change       : 3.24% | 6403754.66667 -> 6196224.0

Revision             Result                  N
chromium@491972      6403755 +- 41536.2      6      good
chromium@492011      6461099 +- 45764.1      6      good
chromium@492016      6553941 +- 53221.7      6      good
chromium@492019      6574763 +- 48931.1      6      good
chromium@492020      6604459 +- 40306.2      6      good
chromium@492021      6269952 +- 54262.3      6      bad       <--
chromium@492030      6227627 +- 58907.4      6      bad
chromium@492049      6196224 +- 36977.6      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.wikipedia system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8970459232592736944


For feedback, file a bug with component Speed>Bisection

Sign in to add a comment