Issue 758185 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	jlebel@chromium.org
Closed:	Sep 2017
Cc:	msarda@chromium.org ios-bugs@chromium.org
Components:	Services>SignInSSO
EstimatedDays:	----
NextAction:	----
OS:	iOS
Pri:	2
Type:	Bug

Replace use of NSUserDefault by base::Feature

Project Member Reported by noyau@chromium.org, Aug 23 2017

Issue description

SafariVCSignInDisabled uses user defaults to change its behavior, it should use base::Feature instead (especially in tests).

Comment 1 by jlebel@chromium.org, Aug 29 2017

This is to finish https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/437812
and crrev.com/c/628877

Comment 2 by jlebel@chromium.org, Sep 6 2017

Status: Started (was: Assigned)

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/b59470fa0bdba6ae3524173668eaf7c3a3e4eca9

commit b59470fa0bdba6ae3524173668eaf7c3a3e4eca9
Author: Jérôme Lebel <jlebel@google.com>
Date: Wed Sep 06 14:29:35 2017

Comment 4 by jlebel@chromium.org, Sep 6 2017

Status: Fixed (was: Started)

►

Issue 758185 link

Issue metadata

Replace use of NSUserDefault by base::Feature

Issue description

Comment 1 by jlebel@chromium.org, Aug 29 2017

Comment 1 Deleted

Comment 2 by jlebel@chromium.org, Sep 6 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Sep 6 2017

Comment 3 Deleted

Comment 4 by jlebel@chromium.org, Sep 6 2017

Comment 4 Deleted

Sign in to add a comment