[Password Manager] Switch back to INACTIVE state when the fallback for saving is disabled and there are no saved passwords |
||
Issue descriptionSwitch back to INACTIVE state when the fallback for saving is disabled and there are no saved passwords At this point, the UI switch back to MANAGE state (i.e. show empty list of passwords). Code references: * https://cs.chromium.org/chromium/src/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc?rcl=ec12b68f2df66c4759af7193fe9b2ae88ca06393&l=131 This line should be fixed: passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE); * New logic should look like this one https://cs.chromium.org/chromium/src/chrome/browser/ui/passwords/manage_passwords_state.cc?rcl=ec12b68f2df66c4759af7193fe9b2ae88ca06393&l=165
,
Aug 25 2017
CL https://chromium-review.googlesource.com/628498 |
||
►
Sign in to add a comment |
||
Comment 1 by battre@chromium.org
, Aug 23 2017I am currently looking at this approach. It seems to work. I am just checking that there are no unforeseen side-effects. void ManagePasswordsUIController::OnHideManualFallbackForSaving() { // ... save_fallback_timer_.Stop(); if (!passwords_data_.GetCurrentForms().empty()) passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE); else passwords_data_.OnInactive(); UpdateBubbleAndIconVisibility(); }