New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758158 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: For Passphrase, show all saved passwords suggestion is seen and remains when page is scrolled

Project Member Reported by divya.pa...@techmahindra.com, Aug 23 2017

Issue description

Chrome Version: 62.0.3194.0
OS:Ubuntu 14.04, Win

What steps will reproduce the problem?
(1)Launch chrome>> Navigate to chrome://settings/ >> Sign in
(2)Click on Sync>> choose Encrypt synced data with your own >> click on passphrase text field and scroll the page to the top and observe


Expected 
Show all saved passwords suggestion should not be seen for Passphrase
If it is intended, then the suggestion should not be seen when the page is scrolled to the top

Actual
Show all saved passwords suggestion is seen, when the page is scrolled to the top the suggestion does not disappear

This is a Regression issue broken in M-62

Below is the manual bisect info
==============================
Good Build: 62.0.3187.0
Bad Build:  62.0.3188.0

 
Actual_passphrase.ogv
5.0 MB View Download
Description: Show this description
Labels: OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on mac 10.12.6 using latest chrome stable #62.0.3194.0.
Labels: -Needs-Bisect hasbisect-per-revision
Owner: melandory@chromium.org
Status: Assigned (was: Untriaged)
Bisect Information:
-------------------
You are probably looking for a change made after 494753 (known good), but no later than 494754 (first known bad).

CHANGELOG URL:
--------------
https://chromium.googlesource.com/chromium/src/+log/e67e7aaea90131f684b1228d1e41c842e7111dea..ce9412c7f3092fad31ac060a00e52656c2cf66d6

@melandory: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!!
Status: Started (was: Assigned)
Yes, it's bug. I'll start fixing it.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fde878dacd6ced968921c04fe75c1975ca66ff9

commit 2fde878dacd6ced968921c04fe75c1975ca66ff9
Author: Tatiana Gornak <melandory@chromium.org>
Date: Thu Aug 24 15:25:55 2017

Do not show "Show all save passwords" fallback for chrome:// and about:// pages

BUG= 758158 

Change-Id: I6d6b2684d75a28461eeff7dcd3e15da6820c4aba
Reviewed-on: https://chromium-review.googlesource.com/628679
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497059}
[modify] https://crrev.com/2fde878dacd6ced968921c04fe75c1975ca66ff9/components/autofill/content/renderer/password_autofill_agent.cc

Labels: TE-Verified-62.0.3196.0 TE-Verified-M62
Tested the issue using #62 .0.3196.0 on Win 7, Linux Ubuntu 14.04 and Mac 10.12.6 as per the observations mentioned in comment #0. Observed show all saved passwords suggestion is not seen.

Please find the screen cast for the same. Hence adding Verified labels.

Thanks!!
758158.webm
3.4 MB View Download
Status: Fixed (was: Started)

Sign in to add a comment