In Manage Bubble of the password manager, long username overlaps x button |
||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.101 Safari/537.36 Steps to reproduce the problem: 1. Open any page with a username/password form 2. Have some credentials saved for that form. Make sure username is long. 3. Go back to the page with the form 4. Click on the key icon to see manage passwords bubble 5. You will see the overlap What is the expected behavior? No overlap What went wrong? Overlap Did this work before? N/A Chrome version: 60.0.3112.101 Channel: stable OS Version: Ubuntu 14.04 Trusty Flash Version:
,
Aug 23 2017
,
Aug 23 2017
,
Aug 24 2017
Credential set that leads to the overlap: "superlongusernamesolonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglong" - "1234567890123" "sdlfksdfkflsd " - "1234567" "some" - "1234"
,
Sep 4 2017
,
Sep 4 2017
The screenshots for different cases after the fix:
,
Sep 4 2017
I am using this bug for other bubbles with the same problem as well. Here are the screenshots for fixed save password bubble:
,
Sep 4 2017
the screenshots for fixed update password bubble:
,
Sep 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32610359311e5146a809dc73001746e1e9793cc8 commit 32610359311e5146a809dc73001746e1e9793cc8 Author: Irmak Kavasoglu <irmakk@google.com> Date: Mon Sep 04 17:40:38 2017 Fixed manage bubble overlap bug For long usernames, the username was overlapping the x button in the manage bubble. This was caused by a bug in the grid layout. This cl is a workaround for the spesific cases where the username and/or password is too long. For long username & short password: Username label's length is limited to the available space, that is, bubble width - paddings - close button. For short username & long password: Username label's length is the preferred length. The password label gets the available space left after the paddings, close button and username label's lenght are reduced from the bubble width. For other cases: The implementation before this fix is kept since it had no problems. Warning: This cl only covers the manage bubble and does not change the ui of save or update password cases. Those will be fixed in the following cls. Bug: 758157 Change-Id: I6f7c2c8e1c37b47654d2ab5dbb546717e440b819 Reviewed-on: https://chromium-review.googlesource.com/647717 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Irmak Kavasoğlu <irmakk@google.com> Cr-Commit-Position: refs/heads/master@{#499522} [modify] https://crrev.com/32610359311e5146a809dc73001746e1e9793cc8/chrome/browser/ui/views/passwords/manage_password_items_view.cc [modify] https://crrev.com/32610359311e5146a809dc73001746e1e9793cc8/chrome/browser/ui/views/passwords/manage_password_items_view.h [modify] https://crrev.com/32610359311e5146a809dc73001746e1e9793cc8/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
,
Sep 5 2017
Verified this issue on Windows 10, Ubuntu 14.04 with chrome #63.0.3206.0, observed the fix is working as intended. Hence adding TE-Verified labels. Attaching the screen-cast for reference.
,
Sep 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/823341de8a2daabb43753d50d82206348b2d61f6 commit 823341de8a2daabb43753d50d82206348b2d61f6 Author: Irmak Kavasoglu <irmakk@google.com> Date: Tue Sep 05 17:29:03 2017 Fixed ui problems in the update password bubble This is a follow-up cl to cl 647717. In that cl, the ui problem for the manage bubble was fixed. This cl focuses on the update bubble. Problem: If we have a super long password, we are not able to see the username in the bubble, it is off the visible bounds to the left. Solution: Exact same thing with the previous cl. The screenshots are added to the bug. Bug: 758157 Change-Id: I20f8fd3e5541265333205be5daef8816645804f7 Reviewed-on: https://chromium-review.googlesource.com/649550 Commit-Queue: Irmak Kavasoğlu <irmakk@google.com> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#499662} [modify] https://crrev.com/823341de8a2daabb43753d50d82206348b2d61f6/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
,
Sep 13 2017
Can we close this as fixed?
,
Sep 20 2017
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by vasi...@chromium.org
, Aug 23 2017Labels: -Via-Wizard-UI OS-Chrome OS-Windows