New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758132 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Weird behavior is seen while loading 'Google Play Terms of Service' page

Project Member Reported by rkalavakuntla@chromium.org, Aug 23 2017

Issue description

Chrome Version:62.0.3193.0/9869.0.0 dev-channel Minnie,Jerry
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign into user -> Launch chrome, Open Play store and Observe the text in 'Google Play Terms of Service' page 

Actual:Weird behavior is seen while loading 'Google Play Terms of Service' page 
Expected:Instead, no such weird behavior should  be seen

This is a Regression issue as same is working fine in 61.0.3147.0/9709.0.0 dev channel Minnie

Note: Issue is not applicable to Linux,Windows OS

 
Actual.jpg
43.6 KB View Download
Expected.png
163 KB View Download
Actual.webm
2.1 MB View Download

Comment 1 by uekawa@chromium.org, Aug 24 2017

Cc: khmel@chromium.org
+yury any ideas?

Comment 2 by khmel@chromium.org, Aug 24 2017

Status: Started (was: Untriaged)
I think re-skin causes this, will take a look.

Comment 3 by khmel@chromium.org, Aug 24 2017

Owner: khmel@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e94e3762c55e8098cb403b776b9818f4f4188985

commit e94e3762c55e8098cb403b776b9818f4f4188985
Author: khmel <khmel@google.com>
Date: Fri Aug 25 00:37:57 2017

arc: Fix ToS layout animation.

Webview has badly looking animation for initial layout. This easy
catches eyes. Based on previous ARC OptIn UI implementation, reliable
workaround is to provide fixed Webview width. The same trick applies to
OOBE ARC Optin which is also affected by this problem.

Bug:  758132 
Test: Manually.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I981e89c731375eed111439bc22b08a61cecbefe1
Reviewed-on: https://chromium-review.googlesource.com/633873
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#497269}
[modify] https://crrev.com/e94e3762c55e8098cb403b776b9818f4f4188985/chrome/browser/resources/chromeos/arc_support/main.css
[modify] https://crrev.com/e94e3762c55e8098cb403b776b9818f4f4188985/chrome/browser/resources/chromeos/arc_support/main.html
[modify] https://crrev.com/e94e3762c55e8098cb403b776b9818f4f4188985/chrome/browser/resources/chromeos/login/arc_terms_of_service.css

Comment 5 by khmel@chromium.org, Aug 25 2017

Cc: keta...@chromium.org
I nominate this as Release  blocker M61. Besides the problem described in header, we found and fixed one more visual regression, please see attached pic.
one_more_problem.png
99 KB View Download

Comment 6 by khmel@chromium.org, Aug 25 2017

Labels: -ReleaseBlock-Beta -M-62 ReleaseBlock-Stable M-61 Merge-Request-61
Changed milestone as in prev comment. Please revert to M62 or approve merge. Thanks!
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 25 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 10 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by ketakid@google.com, Aug 25 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 25 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67a2aa762bceb49c88ddf8170f024542206277a4

commit 67a2aa762bceb49c88ddf8170f024542206277a4
Author: khmel <khmel@google.com>
Date: Fri Aug 25 15:28:08 2017

[Merge M61] arc: Fix ToS layout animation.

Webview has badly looking animation for initial layout. This easy
catches eyes. Based on previous ARC OptIn UI implementation, reliable
workaround is to provide fixed Webview width. The same trick applies to
OOBE ARC Optin which is also affected by this problem.

Bug:  758132 
Test: Manually.
TBR=khmel@google.com, xiyuan@chromium.org

(cherry picked from commit e94e3762c55e8098cb403b776b9818f4f4188985)

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I981e89c731375eed111439bc22b08a61cecbefe1
Reviewed-on: https://chromium-review.googlesource.com/633873
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#497269}
Reviewed-on: https://chromium-review.googlesource.com/635907
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#888}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/67a2aa762bceb49c88ddf8170f024542206277a4/chrome/browser/resources/chromeos/arc_support/main.css
[modify] https://crrev.com/67a2aa762bceb49c88ddf8170f024542206277a4/chrome/browser/resources/chromeos/arc_support/main.html
[modify] https://crrev.com/67a2aa762bceb49c88ddf8170f024542206277a4/chrome/browser/resources/chromeos/login/arc_terms_of_service.css

Comment 10 by khmel@chromium.org, Aug 25 2017

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/234a4ebfea60319672f94f2fea0e1a92f8e4ae3c

commit 234a4ebfea60319672f94f2fea0e1a92f8e4ae3c
Author: lgcheng <lgcheng@google.com>
Date: Fri Aug 25 19:38:41 2017

Arc optin.

Add correct margin after removing mis-typed dot.

Bug:  758132 
Test: Manually.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4389b49bc64464fd81ff105dda16d31cfccd56df
Reviewed-on: https://chromium-review.googlesource.com/636283
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/heads/master@{#497496}
[modify] https://crrev.com/234a4ebfea60319672f94f2fea0e1a92f8e4ae3c/chrome/browser/resources/chromeos/arc_support/main.css

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/554bcf5e17ecab8ec2b87002d3cd80cd9a2b47ef

commit 554bcf5e17ecab8ec2b87002d3cd80cd9a2b47ef
Author: lgcheng <lgcheng@google.com>
Date: Fri Aug 25 19:44:53 2017

[Merge M61]Arc optin.

Add correct margin after removing mis-typed dot.

TBR=xiyuan@chromium.org

Bug:  758132 
Test: Manually.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4389b49bc64464fd81ff105dda16d31cfccd56df
Reviewed-on: https://chromium-review.googlesource.com/636283
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#497496}(cherry picked from commit 234a4ebfea60319672f94f2fea0e1a92f8e4ae3c)
Reviewed-on: https://chromium-review.googlesource.com/636226
Reviewed-by: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/branch-heads/3163@{#897}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/554bcf5e17ecab8ec2b87002d3cd80cd9a2b47ef/chrome/browser/resources/chromeos/arc_support/main.css

Comment 13 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment