Phone changes orientation momentarily after leaving Fullscreen |
||
Issue descriptionWith FullscreenActivity enabled: 1. Fullscreen a video when the phone is in portrait. 2. The video will enter fullscreen and change to landscape. 3. Leave fullscreen. 4. After fullscreen has been left, the phone will momentarily switch to landscape and then back to portrait. With rotate-to-fullscreen enabled, this will cause the video to reenter fullscreen. This reproduces sometimes (~50%) on my Pixel with Android O. This does not reproduce on my Nexus 5 with Android L.
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20998a13d080b8ac854f107145af6abd1e205aec commit 20998a13d080b8ac854f107145af6abd1e205aec Author: Peter E Conn <peconn@chromium.org> Date: Thu Oct 19 13:28:54 2017 📺 Reparent Tab after FullscreenActivity has started. In the current ChromeTabbedActivity to FullscreenActivity transition we detach the Tab from the CTA then launch the FA which reattaches the Tab. Since Activity creation takes time, the user gets a glimpse of a second Tab before the FA opens with the fullscreen Tab. Here we change the flow so the Tab is only detached and reattached once the FA has started. Bug: 757878, 758116 Change-Id: I8cd4afe80ff053ae2bf0bc89454a286429330440 Reviewed-on: https://chromium-review.googlesource.com/632686 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#510071} [modify] https://crrev.com/20998a13d080b8ac854f107145af6abd1e205aec/chrome/android/java/src/org/chromium/chrome/browser/FullscreenActivity.java [modify] https://crrev.com/20998a13d080b8ac854f107145af6abd1e205aec/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java [modify] https://crrev.com/20998a13d080b8ac854f107145af6abd1e205aec/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java [modify] https://crrev.com/20998a13d080b8ac854f107145af6abd1e205aec/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java [modify] https://crrev.com/20998a13d080b8ac854f107145af6abd1e205aec/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabReparentingParams.java [modify] https://crrev.com/20998a13d080b8ac854f107145af6abd1e205aec/chrome/android/javatests/src/org/chromium/chrome/browser/FullscreenActivityTest.java [modify] https://crrev.com/20998a13d080b8ac854f107145af6abd1e205aec/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java
,
Oct 19 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by peconn@chromium.org
, Aug 23 2017