New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758113 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Taskbar is not visible after switching into main profile from incognito window.

Reported by avsha...@etouch.net, Aug 23 2017

Issue description

Chrome version : 62.0.3194.0 (Official Build) c14400a94cb4f43e0e9b02e59e93cf5a082c6408-refs/heads/master@{#496533} 32/64 bit
OS : Windows 7

What steps will reproduce the problem?
1. Launch chrome, open NTP and press Ctrl + Shift + N keys to open incognito window.
2. In incognito window, press F11 to enter into full screen mode and click on 'Import bookmarks now..' link on bookmarks bar. (Main profile window appears)
3. Observe the Taskbar.

Actual Result : Taskbar is not visible after switching into main profile from incognito window.

Expected Result : Taskbar should be visible after switching into main profile from incognito window.

This is a regression issue broken in ‘M-61’, below is the manual regression range and will soon update bisect info.
Good build : 61.0.3150.0
Bad build : 61.0.3152.0

Note : This is Windows 7 specific issue and the same is working fine on Win(8,10), Mac(10.11.6, 10.12.3, 10.12.5) & Linux(14.04 LTS) OS.
 
Actual_Result.mp4
886 KB View Download
Expected_Result.mp4
1.1 MB View Download

Comment 1 by avsha...@etouch.net, Aug 23 2017

Correction: 
Chrome Version: 61.0.3163.59 (Official Build)9577e0b56f9184a32f33705fabfc6bf5c2d1d4a3-refs/branch-heads/3163@{#773} 32/64-bit.
Cc: pnangunoori@chromium.org
Labels: hasbisect-per-revision Needs-Triage-M61
Owner: ananta@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 61.0.3150.0
Bad build: 61.0.3152.0

You are probably looking for a change made after 484746 (known good), but no later than 484758 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+/9c35b80be7b82051abec46fabdcdef6be4b214a2

From the CL above, assigning the issue to the concern owner

@ananta: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-URL: https://codereview.chromium.org/2972963004

Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.126 and able to reproduce in latest Canary #62.0.3194.0
Labels: ReleaseBlock-Stable
Adding Blocker label, please remove if not the case.

Comment 4 by gov...@chromium.org, Aug 23 2017

Cc: pbomm...@chromium.org
URGENT - PTAL.
M61 Stable promotion is coming VERY soon and your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP. 

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label or move to M62. Thank you!

Note: Plan is to cut M61 Stable RC on 08/31/17.


Project Member

Comment 5 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f091c0c1b2a968a5f61dc15da2b35b87077d077a

commit f091c0c1b2a968a5f61dc15da2b35b87077d077a
Author: Anantanarayanan Iyengar <ananta@chromium.org>
Date: Fri Aug 25 23:30:55 2017

Fix a regression on Windows 7 which manifested in normal windows obscuring the taskbar when a fullscreen window is around.

This bug only occurs on Windows 7 and started with my change where we use the ITaskbarList2::MarkFullscreenWindow() API
to inform the taskbar about a window being fullsceen or not. As per docs calling this API when a window goes fullscreen is enough
for the taskbar to hide itself when that window is active and to show itself when the window is inactive. It appears that the behavior
is different on Windows 7.

The fix being tried here is to mark the window as fullscreen when it is active and inactive when it is not, i.e a manual process.
This works fine on Windows 7 and 10 and was verified by QA.

BUG= 758113 

Change-Id: Ibdeae0be10640559594fe97980b622d64ae6ae75
Reviewed-on: https://chromium-review.googlesource.com/634451
Commit-Queue: Ananta Iyengar <ananta@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497593}
[modify] https://crrev.com/f091c0c1b2a968a5f61dc15da2b35b87077d077a/ui/views/win/fullscreen_handler.cc
[modify] https://crrev.com/f091c0c1b2a968a5f61dc15da2b35b87077d077a/ui/views/win/fullscreen_handler.h
[modify] https://crrev.com/f091c0c1b2a968a5f61dc15da2b35b87077d077a/ui/views/win/hwnd_message_handler.cc

Comment 6 by avsha...@etouch.net, Aug 28 2017

Labels: TE-Verified-M62 TE-Verified-62.0.3198.0
Update : 
Retested above issue in latest chrome canary #62.0.3198.0 on Windows 7 OS and issue is not reproducible. Issue is fixed now and it is working as intended.
Kindly review an attached screen cast.

Thank you!
Canary_Behaviour.mp4
813 KB View Download

Comment 7 by ananta@chromium.org, Aug 28 2017

Labels: Merge-Request-61
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 28 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 7 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by gov...@chromium.org, Aug 28 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 branch 3163 based on comment #6 and per offline chat with Ananta & Prudhvi.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 29 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/854c089d7063043bc260865aeeb77dc6a1d1a793

commit 854c089d7063043bc260865aeeb77dc6a1d1a793
Author: Anantanarayanan Iyengar <ananta@chromium.org>
Date: Tue Aug 29 01:12:33 2017

Fix a regression on Windows 7 which manifested in normal windows obscuring the taskbar when a fullscreen window is around.

Merging to M61

This bug only occurs on Windows 7 and started with my change where we use the ITaskbarList2::MarkFullscreenWindow() API
to inform the taskbar about a window being fullsceen or not. As per docs calling this API when a window goes fullscreen is enough
for the taskbar to hide itself when that window is active and to show itself when the window is inactive. It appears that the behavior
is different on Windows 7.

The fix being tried here is to mark the window as fullscreen when it is active and inactive when it is not, i.e a manual process.
This works fine on Windows 7 and 10 and was verified by QA.

BUG= 758113 
TBR=ananta@chromium.org

(cherry picked from commit f091c0c1b2a968a5f61dc15da2b35b87077d077a)

Change-Id: Ibdeae0be10640559594fe97980b622d64ae6ae75
Reviewed-on: https://chromium-review.googlesource.com/634451
Commit-Queue: Ananta Iyengar <ananta@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497593}
Reviewed-on: https://chromium-review.googlesource.com/640070
Reviewed-by: Ananta Iyengar <ananta@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#961}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/854c089d7063043bc260865aeeb77dc6a1d1a793/ui/views/win/fullscreen_handler.cc
[modify] https://crrev.com/854c089d7063043bc260865aeeb77dc6a1d1a793/ui/views/win/fullscreen_handler.h
[modify] https://crrev.com/854c089d7063043bc260865aeeb77dc6a1d1a793/ui/views/win/hwnd_message_handler.cc

Labels: TE-Verified-M61 TE-Verified-61.0.3163.71
Tested the issue on Windows-7 using chrome latest Beta M61-61.0.3163.71 by following steps mentioned in the original comment. Observed that Task bar is visible after switching into main profile from incognito window. and its working as expected. Hence adding TE-Verified label.

Please find the screen shot for reference.

Thank you!
758113.mp4
1.4 MB View Download
Status: Fixed (was: Assigned)
marking the bug as fixed, given this been verified in Chrome Canary and Beta.

Sign in to add a comment