New issue
Advanced search Search tips

Issue 758090 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: shows 200 for 304 requests

Project Member Reported by pfeldman@chromium.org, Aug 23 2017

Issue description

Navigate to example.com and reload several times.
See net-internals showing 304 and devtools showing 200. We are not getting raw response details.

Bisect: https://chromium.googlesource.com/chromium/src/+log/29bce136d5f3a695b27b5bf03edb77b756576997..eb9ecc6340ddd547d7e999d4e8170d4345466bb1
 
For the record: Puppeteer bug and repro - https://github.com/GoogleChrome/puppeteer/issues/487
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4

commit 2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Thu Aug 31 17:00:52 2017

Get raw response headers using URLRequest::SetResponseHeadersCallback()

DevTools used to get actual response headers with NetLogObserver. Once we
removed NetLogObserver, we started using URLRequest::response_headers().
However, it returns the original cached headers in case of revalidation
requests, which is not what DevTools expect.
This adds SetResponseHeadersCallback() similar to SetRequestHeadersCallback()
to resolve the issue.

Bug:  758090 ,  721408 
Change-Id: I8d8a7a757601fe282a82b8a092148726cdab85e2
Reviewed-on: https://chromium-review.googlesource.com/631119
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498894}
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/chrome/browser/devtools/devtools_network_transaction.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/chrome/browser/devtools/devtools_network_transaction.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/content/browser/loader/resource_loader.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/content/common/loader_util.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/content/common/loader_util.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/content/network/url_loader_impl.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/content/network/url_loader_impl.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/http/failing_http_transaction_factory.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/http/http_cache_transaction.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/http/http_cache_transaction.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/http/http_network_transaction.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/http/http_network_transaction.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/http/http_response_headers.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/http/http_transaction.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/http/http_transaction_test_util.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/url_request/url_request.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/url_request/url_request.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/url_request/url_request_http_job.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/url_request/url_request_http_job.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/url_request/url_request_job.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/url_request/url_request_job.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/url_request/url_request_unittest.cc
[add] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/raw-response-headers-expected.txt
[add] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/raw-response-headers.js
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/third_party/WebKit/Source/devtools/front_end/Tests.js

Comment 3 by caseq@chromium.org, Sep 22 2017

Status: Fixed (was: Assigned)

Sign in to add a comment