New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit 16 days ago
Closed: Jan 25
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add 'autocomplete' IDL attribute to HTMLTextAreaElement and HTMLSelectElement

Project Member Reported by tkent@chromium.org, Aug 23 2017

Issue description

Chrome Version: 62 canary
OS: All but iOS

What steps will reproduce the problem?
(1) Open the following URL:
    data:text/html;charset=utf-8,<textarea%20autocomplete="on"></textarea><select%20autocomplete="on"></select><script>alert(document.querySelector('textarea').autocomplete%20+%20'%20/%20'%20+%20document.querySelector('select').autocomplete);</script>

What is the expected result?
Show show a dialog with "on / on".

What happens instead?
Show a dialog with "undefined / undefined".

Please use labels and text to provide additional information.
Safari implemented them. Edge and Firefox don't have.

Spec:
https://html.spec.whatwg.org/multipage/form-elements.html#the-select-element
https://html.spec.whatwg.org/multipage/form-elements.html#the-textarea-element
Test:
http://w3c-test.org/html/dom/reflection-forms.html

We already have autocomplete attribute support for SELECT and TEXTAREA. This issue is only for adding their IDL attributes.

 
Owner: shanmug...@samsung.com
Status: Assigned (was: Available)
Labels: -Needs-BlinkIntent
shanmuga.m@, what's the implementation status?

tkent@
Please check and give your comment.
https://chromium-review.googlesource.com/c/chromium/src/+/677144
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1c977ab2790547a3bab3aca362e137ab976e885

commit e1c977ab2790547a3bab3aca362e137ab976e885
Author: Shanmuga Pandi M <shanmuga.m@samsung.com>
Date: Wed Jan 24 11:49:17 2018

Add autoComplete IDL attribute to textArea and select element.

This patch just adding autoComplete attribute to idl files.
This will just make sure, setter/getter of that attribute to work fine.

Spec:
https://html.spec.whatwg.org/multipage/form-elements.html#the-select-element
https://html.spec.whatwg.org/multipage/form-elements.html#the-textarea-element

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/2tutRHmhwTE

Bug:  758078 
Change-Id: Ibb72aa7a616893c05e0fb224c95a54a6bd457e5a
Reviewed-on: https://chromium-review.googlesource.com/677144
Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531502}
[modify] https://crrev.com/e1c977ab2790547a3bab3aca362e137ab976e885/third_party/WebKit/LayoutTests/external/wpt/html/dom/reflection-forms-expected.txt
[modify] https://crrev.com/e1c977ab2790547a3bab3aca362e137ab976e885/third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/e1c977ab2790547a3bab3aca362e137ab976e885/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e1c977ab2790547a3bab3aca362e137ab976e885/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/e1c977ab2790547a3bab3aca362e137ab976e885/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e1c977ab2790547a3bab3aca362e137ab976e885/third_party/WebKit/Source/core/html/forms/HTMLSelectElement.idl
[modify] https://crrev.com/e1c977ab2790547a3bab3aca362e137ab976e885/third_party/WebKit/Source/core/html/forms/HTMLTextAreaElement.idl

Labels: M-66
Status: Fixed (was: Assigned)

Sign in to add a comment