Actually these tests were only added recently, in r496361 -> https://codereview.chromium.org/2943983003

So these tests started running only since 

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.12/builds/5651

But the tests pass there...

[3006/6607] MediaControlsImplInProductHelpTest.DownloadButtonInProductHelp_Button (2 ms)
[3007/6607] MediaControlsImplInProductHelpTest.DownloadButtonInProductHelp_ControlsVisibility (2 ms)
[3008/6607] MediaControlsImplInProductHelpTest.DownloadButtonInProductHelp_ButtonVisibility (2 ms)

Bizarre.

I tried reproing locally on 10.12.6 with and without asan and sadly have nothing to help.

However! An error is manifesting in one of the crashes for ControlsVisibility, which suggest this may be related to "[LayoutNG] Bring back native support for multicol."? Repeated below.

This problem on the bot isn't going away, so I'm disabling the test. But there may be something serious here.


MediaControlsImplInProductHelpTest.DownloadButtonInProductHelp_ControlsVisibility (run #1):
[ RUN      ] MediaControlsImplInProductHelpTest.DownloadButtonInProductHelp_ControlsVisibility
[8878:775:0822/221858.156637:211753025439:FATAL:partition_alloc.cc(934)] Check failed: page->num_allocated_slots != -1.
0   webkit_unit_tests                   0x0000000109a0ef0c base::debug::StackTrace::StackTrace(unsigned long) + 28
1   webkit_unit_tests                   0x0000000109a22370 logging::LogMessage::~LogMessage() + 224
2   webkit_unit_tests                   0x0000000109a9877b base::PartitionFreeSlowPath(base::PartitionPage*) + 523
3   webkit_unit_tests                   0x000000010b217661 blink::LayoutObject::operator delete(void*) + 193
4   webkit_unit_tests                   0x000000010ad8d680 blink::Node::DetachLayoutTree(blink::Node::AttachContext const&) + 80
5   webkit_unit_tests                   0x000000010ad22078 blink::ContainerNode::DetachLayoutTree(blink::Node::AttachContext const&) + 120
6   webkit_unit_tests                   0x000000010ad5ebf3 blink::Element::DetachLayoutTree(blink::Node::AttachContext const&) + 403
7   webkit_unit_tests                   0x000000010afa5a7e blink::HTMLInputElement::DetachLayoutTree(blink::Node::AttachContext const&) + 62
8   webkit_unit_tests                   0x000000010ad2205f blink::ContainerNode::DetachLayoutTree(blink::Node::AttachContext const&) + 95
9   webkit_unit_tests                   0x000000010ad5ebf3 blink::Element::DetachLayoutTree(blink::Node::AttachContext const&) + 403
10  webkit_unit_tests                   0x000000010ad8d550 blink::Node::ReattachLayoutTree(blink::Node::AttachContext&) + 48
11  webkit_unit_tests                   0x000000010ad5ff18 blink::Element::RebuildLayoutTree(blink::WhitespaceAttacher&) + 376
12  webkit_unit_tests                   0x000000010ad236eb blink::ContainerNode::RebuildChildrenLayoutTrees(blink::WhitespaceAttacher&) + 107
13  webkit_unit_tests                   0x000000010ad5fe86 blink::Element::RebuildLayoutTree(blink::WhitespaceAttacher&) + 230
14  webkit_unit_tests                   0x000000010ad236eb blink::ContainerNode::RebuildChildrenLayoutTrees(blink::WhitespaceAttacher&) + 107
15  webkit_unit_tests                   0x000000010ad5fe86 blink::Element::RebuildLayoutTree(blink::WhitespaceAttacher&) + 230
16  webkit_unit_tests                   0x000000010ad236eb blink::ContainerNode::RebuildChildrenLayoutTrees(blink::WhitespaceAttacher&) + 107
17  webkit_unit_tests                   0x000000010adb9de3 blink::ShadowRoot::RebuildLayoutTree(blink::WhitespaceAttacher&) + 35
18  webkit_unit_tests                   0x000000010ad5fe6b blink::Element::RebuildLayoutTree(blink::WhitespaceAttacher&) + 203
19  webkit_unit_tests                   0x000000010ad236eb blink::ContainerNode::RebuildChildrenLayoutTrees(blink::WhitespaceAttacher&) + 107
20  webkit_unit_tests                   0x000000010ad5fe86 blink::Element::RebuildLayoutTree(blink::WhitespaceAttacher&) + 230
21  webkit_unit_tests                   0x000000010ad236eb blink::ContainerNode::RebuildChildrenLayoutTrees(blink::WhitespaceAttacher&) + 107
22  webkit_unit_tests                   0x000000010ad5fe86 blink::Element::RebuildLayoutTree(blink::WhitespaceAttacher&) + 230
23  webkit_unit_tests                   0x000000010ad3791a blink::Document::UpdateStyle() + 538
24  webkit_unit_tests                   0x000000010ad34ee1 blink::Document::UpdateStyleAndLayoutTree() + 593
25  webkit_unit_tests                   0x000000010aefde32 blink::LocalFrameView::PerformPreLayoutTasks() + 370
26  webkit_unit_tests                   0x000000010aefc425 blink::LocalFrameView::UpdateLayout() + 293
27  webkit_unit_tests                   0x000000010af01f6d blink::LocalFrameView::ScrollbarExistenceMaybeChanged() + 109
28  webkit_unit_tests                   0x000000010af09b38 blink::LocalFrameView::AdjustScrollbarExistence(blink::LocalFrameView::ComputeScrollbarExistenceOption) + 40
29  webkit_unit_tests                   0x000000010aeff240 blink::LocalFrameView::UpdateScrollbars() + 816
30  webkit_unit_tests                   0x000000010af03a35 non-virtual thunk to blink::LocalFrameView::ScrollbarStyleChanged() + 53
31  webkit_unit_tests                   0x000000010a54648d blink::ScrollAnimatorMac::UpdateScrollerStyle() + 605
32  AppKit                              0x00007fffd3f3f253 +[NSScrollerImpPair _updateAllScrollerImpPairsForNewRecommendedScrollerStyle:] + 327
33  CoreFoundation                      0x00007fffd595d9fc __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 12
34  CoreFoundation                      0x00007fffd595d8fb _CFXRegistrationPost + 427
35  CoreFoundation                      0x00007fffd595d662 ___CFXNotificationPost_block_invoke + 50
36  CoreFoundation                      0x00007fffd591bd12 -[_CFXNotificationRegistrar find:object:observer:enumerator:] + 2018
37  CoreFoundation                      0x00007fffd591acfb _CFXNotificationPost + 667
38  Foundation                          0x00007fffd735ea37 -[NSNotificationCenter postNotificationName:object:userInfo:] + 66
39  CoreFoundation                      0x00007fffd596771c __CFRUNLOOP_IS_CALLING_OUT_TO_A_BLO
CK__ + 12
40  CoreFoundation                      0x00007fffd59489d4 __CFRunLoopDoBlocks + 356
41  CoreFoundation                      0x00007fffd594816b __CFRunLoopRun + 955
42  CoreFoundation                      0x00007fffd5947b54 CFRunLoopRunSpecific + 420
43  HIToolbox                           0x00007fffd4ed2acc RunCurrentEventLoopInMode + 240
44  HIToolbox                           0x00007fffd4ed2901 ReceiveNextEventCommon + 432
45  HIToolbox                           0x00007fffd4ed2736 _BlockUntilNextEventMatchingListInModeWithFilter + 71
46  AppKit                              0x00007fffd3478ae4 _DPSNextEvent + 1120
47  AppKit                              0x00007fffd3bf321f -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 2789
48  AppKit                              0x00007fffd346d465 -[NSApplication run] + 926
49  webkit_unit_tests                   0x0000000109a2f2ae base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 334
50  webkit_unit_tests                   0x0000000109a2dc2c base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 92
51  webkit_unit_tests                   0x0000000109a44ac3 base::RunLoop::Run() + 51
52  webkit_unit_tests                   0x0000000109ab8368 blink::testing::RunPendingTasks() + 232
53  webkit_unit_tests                   0x00000001087a7c34 blink::MediaControlsImplInProductHelpTest_DownloadButtonInProductHelp_ControlsVisibility_Test::TestBody() + 228
54  webkit_unit_tests                   0x00000001092833b6 testing::Test::Run() + 246
55  webkit_unit_tests                   0x0000000109283df0 testing::TestInfo::Run() + 288
56  webkit_unit_tests                   0x0000000109284357 testing::TestCase::Run() + 263
57  webkit_unit_tests                   0x000000010928a587 testing::internal::UnitTestImpl::RunAllTests() + 871
58  webkit_unit_tests                   0x000000010928a1f3 testing::UnitTest::Run() + 163
59  webkit_unit_tests                   0x0000000109aa2023 base::TestSuite::Run() + 163
60  webkit_unit_tests                   0x00000001079dc746 (anonymous namespace)::runHelper(base::TestSuite*) + 38
61  webkit_unit_tests                   0x0000000109aae5cb base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) + 139


The other tests just say

MediaControlsImplInProductHelpTest.DownloadButtonInProductHelp_ButtonVisibility (run #1):
[ RUN      ] MediaControlsImplInProductHelpTest.DownloadButtonInProductHelp_ButtonVisibility
Received signal 11 SEGV_MAPERR 000000000028
 [0x000111c03f0c]
 [0x000111c03e01]
 [0x7fffeb152bba]
 .. etc

or

MediaControlsImplInProductHelpTest.DownloadButtonInProductHelp_Button (run #1):
[ RUN      ] MediaControlsImplInProductHelpTest.DownloadButtonInProductHelp_Button
Received signal 11 SEGV_MAPERR 000000000028
 [0x000107ea2f0c]
 [0x000107ea2e01]
 [0x7fffeb152bba]

I also noticed there are a bunch of other DISABLED_ tests that seem to relate to column layout stuff, which still fail/CRASH/DCHECK when run with --gtest_also_run_disabled_tests

- NGBlockLayoutAlgorithmTest.DISABLED_ActualColumnCountGreaterThanSpecified
- NGBlockLayoutAlgorithmTest.DISABLED_BlockInOneColumn
- NGBlockLayoutAlgorithmTest.DISABLED_BlockInThreeColumns
- NGBlockLayoutAlgorithmTest.DISABLED_BlockInTwoColumns
- NGBlockLayoutAlgorithmTest.DISABLED_FloatInOneColumn
- NGBlockLayoutAlgorithmTest.DISABLED_TwoBlocksInTwoColumns
- NGBlockLayoutAlgorithmTest.DISABLED_TwoFloatsInOneColumn
- NGBlockLayoutAlgorithmTest.DISABLED_TwoFloatsInTwoColumns

mstensho@ - you might want to take a look in case they relate to r496446 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a92243bdb50a60d53415f81cf4b30e90173bb30

commit 3a92243bdb50a60d53415f81cf4b30e90173bb30
Author: Trent Apted <tapted@chromium.org>
Date: Wed Aug 23 08:15:14 2017

Disable MediaControlsImplInProductHelpTest.DownloadButtonInProductHelp_* on Mac

There's an elusive segfault that started on a single bot shortly after
landing. See bug for details.

TBR=khushalsagar@chromium.org

Bug:  758076 
Change-Id: I2321ff38cf5f73d462b7fce83816dfc426c155a2
Reviewed-on: https://chromium-review.googlesource.com/628002
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496622}
[modify] https://crrev.com/3a92243bdb50a60d53415f81cf4b30e90173bb30/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp

 Issue 758091  has been merged into this issue.

@tapted: I'm working on getting multicol back into LayoutNG. The disabled tests will be enabled once they start working again.

r496446 is reverted, FWIW. But I'm planning on relanding shortly.

The builder is green again.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.12/builds/5669

Does this need any further work?

The test is still disabled. If the issue that originally caused them to fail is fixed, we can just re-enable them.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/707dc947e6af811a8bc0fd9c7ef8c7332e7c893c

commit 707dc947e6af811a8bc0fd9c7ef8c7332e7c893c
Author: Khushal <khushalsagar@chromium.org>
Date: Fri Feb 23 11:57:16 2018

blink: Re-enable media download in-product-help tests on mac.

R=mlamouri@chromium.org

Bug:  758076 
Change-Id: I5e556c2f5f993ede2bd53de0c96e76b44ff80883
Reviewed-on: https://chromium-review.googlesource.com/933112
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538762}
[modify] https://crrev.com/707dc947e6af811a8bc0fd9c7ef8c7332e7c893c/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp