Dragging on the app grid should move the launcher |
||||||
Issue descriptionSomehow dragging on the app grid to move the launcher got disabled. This feels very strange on tablets, and the boundary between where a drag effects launcher position and where it does not is not clear. We should re-enable dragging through the grid.
,
Aug 23 2017
Is that related to the change making it impossible to click-through the launcher ? We should definitely re-enable dragging but make sure we still cannot tap/click through.
,
Aug 23 2017
Probably an unintended change related to that fix.
,
Aug 23 2017
Approving merge to M61 Chrome OS.
,
Aug 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae2854db0c5a5b53c7ed158f1370e0b165b586d8 commit ae2854db0c5a5b53c7ed158f1370e0b165b586d8 Author: Alex Newcomer <newcomer@chromium.org> Date: Sat Aug 26 01:00:32 2017 cros: Enable dragging of launcher through the AppsGridView Dragging over the AppsGridView should move the app list when the drag event would otherwise not result in moving the AppsGridView. Also, a scroll sequence should not be allowed to move both the AppListView and the AppsGridView. Bug: 758069 Change-Id: I15da8083064b95bea35ebfe1429390e953e2adb4 Reviewed-on: https://chromium-review.googlesource.com/631139 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#497619} [modify] https://crrev.com/ae2854db0c5a5b53c7ed158f1370e0b165b586d8/ui/app_list/pagination_controller.cc [modify] https://crrev.com/ae2854db0c5a5b53c7ed158f1370e0b165b586d8/ui/app_list/pagination_controller.h [modify] https://crrev.com/ae2854db0c5a5b53c7ed158f1370e0b165b586d8/ui/app_list/views/app_list_view.cc [modify] https://crrev.com/ae2854db0c5a5b53c7ed158f1370e0b165b586d8/ui/app_list/views/apps_grid_view.cc [modify] https://crrev.com/ae2854db0c5a5b53c7ed158f1370e0b165b586d8/ui/app_list/views/apps_grid_view_unittest.cc
,
Aug 28 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 28 2017
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9403d127ae66d6478700af5b742a3df4bf8d4e8a commit 9403d127ae66d6478700af5b742a3df4bf8d4e8a Author: Maajid <maajid@chromium.org> Date: Wed Aug 30 22:43:28 2017 cros: Enable dragging of launcher through the AppsGridView Dragging over the AppsGridView should move the app list when the drag event would otherwise not result in moving the AppsGridView. Also, a scroll sequence should not be allowed to move both the AppListView and the AppsGridView. TBR=newcomer@chromium.org (cherry picked from commit ae2854db0c5a5b53c7ed158f1370e0b165b586d8) Bug: 758069 Change-Id: I15da8083064b95bea35ebfe1429390e953e2adb4 Reviewed-on: https://chromium-review.googlesource.com/631139 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#497619} Reviewed-on: https://chromium-review.googlesource.com/644152 Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1015} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/9403d127ae66d6478700af5b742a3df4bf8d4e8a/ui/app_list/pagination_controller.cc [modify] https://crrev.com/9403d127ae66d6478700af5b742a3df4bf8d4e8a/ui/app_list/pagination_controller.h [modify] https://crrev.com/9403d127ae66d6478700af5b742a3df4bf8d4e8a/ui/app_list/views/app_list_view.cc [modify] https://crrev.com/9403d127ae66d6478700af5b742a3df4bf8d4e8a/ui/app_list/views/apps_grid_view.cc [modify] https://crrev.com/9403d127ae66d6478700af5b742a3df4bf8d4e8a/ui/app_list/views/apps_grid_view_unittest.cc
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sheriffbot@chromium.org
, Aug 23 2017