New issue
Advanced search Search tips

Issue 758062 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

HitTestQuery needs non-targeting API

Project Member Reported by sadrul@chromium.org, Aug 23 2017

Issue description

A target can be determined without using the HitTestQuery. For example, if there's a capture window, or there's a latched target, then that capture/latched window is used as the target, and HitTestQuery is not used for targeting. However, even in such cases, it is necessary to make sure the event-location is transformed correctly, with respect to the target window. To be able to do this correctly, it will be necessary to introduce new API in HitTestQuery (e.g. something like: gfx::Transform HitTestQuery::GetTranformForTarget(FrameSinkId target)).

HitTestQuery could likely cache some of this information as an optimization, but it would make sense to look at the caching separately.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/452ed8aad3c3b320634c57711ce124a739ce2c3a

commit 452ed8aad3c3b320634c57711ce124a739ce2c3a
Author: Ria Jiang <riajiang@chromium.org>
Date: Thu Sep 28 02:54:15 2017

Add HitTestQuery API to transform point to target's coord-space.

When a target window is already known, e.g. capture window, we simply
convert point to be in the coordinate space of that target window
without targeting.

Bug:  758062 
Test: viz_unittests
Change-Id: Ia727be8b00fdccad6fc78621e96a42413d856c88
Reviewed-on: https://chromium-review.googlesource.com/668164
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504877}
[modify] https://crrev.com/452ed8aad3c3b320634c57711ce124a739ce2c3a/components/viz/host/hit_test/hit_test_query.cc
[modify] https://crrev.com/452ed8aad3c3b320634c57711ce124a739ce2c3a/components/viz/host/hit_test/hit_test_query.h
[modify] https://crrev.com/452ed8aad3c3b320634c57711ce124a739ce2c3a/components/viz/host/hit_test/hit_test_query_unittest.cc

Status: Fixed (was: Started)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment