New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 810131

Blocking:
issue 809385



Sign in to add a comment
link

Issue 758057: Screen capture (snapshot or video) needs to be color space aware, and do the right things.

Reported by ccameron@chromium.org, Aug 23 2017 Project Member

Issue description

The results of the functions RenderWidgetHostView::CopyFromSurface and RenderWidgetHostView::CopyFromSurfaceToVideoFrame are impacted by the color space of the surface this is being copied from, but nowhere is the color space recorded or used.

This came up as a bug in  issue 756329 , where CopyFromSurface was used in the eyedropper color picker, and the result was affected by the output color space.

At the least, the callback from CopyFromSurface should report the backbuffer's color space (see the TODO in the fix for 753320).

Alternatively, both CopyFromSurface and CopyFromSurfaceToVideoFrame could take as arguments the expected output color space for the readback. This would involve more work.
 

Comment 1 by ccameron@chromium.org, Aug 23 2017

Description: Show this description

Comment 2 by m...@chromium.org, Aug 23 2017

My work on moving tab capture into VIZ is adding APIs/properties to pass color space information as well. The deeper issue, here, is what is happening in the GPU: The textures being copied are assumed to be in some RGB space (sRGB?) and mapped into BT.709. But, there is currently no code checking what the source RGB color space actually is, nor changing the color conversion matrix when the image format is changed to planar I420.

Comment 3 by bugdroid1@chromium.org, Sep 6 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9ad27a485e6c86c9a953686821492c6d8549e1e

commit b9ad27a485e6c86c9a953686821492c6d8549e1e
Author: Yuri Wiitala <miu@chromium.org>
Date: Wed Sep 06 19:13:50 2017

Tab Capture in VIZ: CopyOutputRequest/Result API changes.

Simplified creation of requests and sending of results to support the
effort to move tab/desktop capture into the VIZ component. The high-
level philosophy here is for clients to get exactly the result type they
ask for, matched to their use case. For example, one-off snapshots need
scaled SkBitmaps that are immediately ready for use, while layer
animations only need a texture reference to assign to an animated layer.
Furthermore, clients should not be burdened with having to deal with ALL
of the possible separate storage/access or ownership semantics that are
specific to whichever DirectRenderer happened to generate the results.

Summary of changes:

CopyOutputRequest: 1) Removed pre-C++11-style CreateXYZ() methods in
favor of a simple ctor. 2) Removed SendXYZ() methods in favor of a
single SendResult() method that works with the new polymorphic
CopyOutputResults. 3) Replaced CreateEmptyRequest() with
CreateStubForTesting(), since non-test code should never create empty
requests. 4) Add ResultFormat enum to allow clients to request exactly
what they should get, rather than be burdened with coding for all
possible result formats.

CopyOutputResult: Common accessor API, but each DirectRenderer impl that
executes copy requests can use their own subclass impl(s) to manage
their own special result storage/access and ownership semantics and
provide auto-format conversions where it makes sense.

Updated mojo IDL, struct traits, client code, and unit tests to match
the API changes.

Bug:  754872 , 758057, 644851,  759310 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia309e261a92e05a475a35732ba6df3497366478d
Reviewed-on: https://chromium-review.googlesource.com/637003
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Alexandre Elias <aelias@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500033}
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/ash/rotator/screen_rotation_animator.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/ipc/copy_output_result.mojom
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/ipc/copy_output_result_struct_traits.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/ipc/copy_output_result_struct_traits.h
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/ipc/struct_traits_unittest.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/layers/layer.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/layers/layer_unittest.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/output/direct_renderer.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/output/direct_renderer.h
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/output/software_renderer.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/output/software_renderer.h
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/output/software_renderer_unittest.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/output/vulkan_renderer.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/output/vulkan_renderer.h
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/quads/render_pass_unittest.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/test/layer_test_common.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/test/layer_tree_pixel_test.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/test/layer_tree_pixel_test.h
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/test/pixel_test.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/trees/layer_tree_host_pixeltest_readback.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/trees/layer_tree_host_unittest_copyrequest.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/cc/trees/occlusion_tracker_unittest.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/components/exo/pointer.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/components/viz/OWNERS
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/components/viz/common/quads/copy_output_request.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/components/viz/common/quads/copy_output_request.h
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/components/viz/common/quads/copy_output_result.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/components/viz/common/quads/copy_output_result.h
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/components/viz/service/display/display_unittest.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/components/viz/service/display/gl_renderer.h
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/components/viz/service/display/skia_renderer.h
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/components/viz/service/display/surface_aggregator.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/components/viz/service/surfaces/surface.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/components/viz/service/surfaces/surface_unittest.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/content/browser/compositor/surface_utils.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/content/browser/media/capture/aura_window_capture_machine.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/remoting/host/chromeos/aura_desktop_capturer.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/remoting/host/chromeos/aura_desktop_capturer_unittest.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/services/viz/public/cpp/compositing/copy_output_request_struct_traits.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/services/viz/public/cpp/compositing/copy_output_request_struct_traits.h
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/services/viz/public/interfaces/compositing/copy_output_request.mojom
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/ui/android/delegated_frame_host_android.h
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/ui/compositor/layer_unittest.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/ui/snapshot/snapshot_android.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/ui/snapshot/snapshot_async.cc
[modify] https://crrev.com/b9ad27a485e6c86c9a953686821492c6d8549e1e/ui/snapshot/snapshot_aura.cc

Comment 4 by bugdroid1@chromium.org, Sep 9 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97820e6103da716cc82c8d8cd1e11073c157c169

commit 97820e6103da716cc82c8d8cd1e11073c157c169
Author: Christopher Cameron <ccameron@chromium.org>
Date: Sat Sep 09 00:51:43 2017

Add color space info to CopyOutputResult

The data from CopyOutputResult is from a framebuffer that is in a
particular color space (specified by its RenderPass). That color
space information was not propagated to the CopyOutputResult.
Fix this.

For textures, populate the texture mailbox's color space.
Add pixel tests for all of this path.

Do not add support for the SkBitmap path yet. That will come in
a future patch.

R=enne, miu, dcheng
TBR=rockot

Bug: 758057
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic889c51660ff4af02e082eb2867c956fa2212001
Reviewed-on: https://chromium-review.googlesource.com/651691
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500766}
[modify] https://crrev.com/97820e6103da716cc82c8d8cd1e11073c157c169/cc/trees/layer_tree_host_pixeltest_readback.cc
[modify] https://crrev.com/97820e6103da716cc82c8d8cd1e11073c157c169/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/97820e6103da716cc82c8d8cd1e11073c157c169/components/viz/service/display/gl_renderer.h
[add] https://crrev.com/97820e6103da716cc82c8d8cd1e11073c157c169/components/viz/test/data/srgb_green_in_p3.png
[modify] https://crrev.com/97820e6103da716cc82c8d8cd1e11073c157c169/components/viz/test/test_layer_tree_frame_sink.cc
[modify] https://crrev.com/97820e6103da716cc82c8d8cd1e11073c157c169/components/viz/test/test_layer_tree_frame_sink.h
[modify] https://crrev.com/97820e6103da716cc82c8d8cd1e11073c157c169/services/viz/public/cpp/compositing/struct_traits_unittest.cc

Comment 5 by m...@chromium.org, Feb 7 2018

Components: Internals>Media>ScreenCapture

Comment 6 by m...@chromium.org, Feb 7 2018

Components: -Internals>Media>Capture

Comment 7 by m...@chromium.org, May 18 2018

Blockedon: 810131

Comment 8 by m...@chromium.org, May 18 2018

Blocking: 809385

Comment 9 by ccameron@chromium.org, Jun 6 2018

Owner: m...@chromium.org
Assigning to miu@ since they're driving color support for capture.

Comment 10 by bugdroid1@chromium.org, Jun 9 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d35ae16c1b4b3f2b6262b75cd271c79f3267b452

commit d35ae16c1b4b3f2b6262b75cd271c79f3267b452
Author: Yuri Wiitala <miu@chromium.org>
Date: Sat Jun 09 04:30:56 2018

Add gfx::ColorSpace(const SkColorSpace&) constructor.

gfx::ColorSpace can convert to a SkColorSpace, but there was no simple
way to convert the other way around. This change addresses that need.

Bug: 758057, 810131 
Change-Id: Id6bb1b079f17cc632ab04cddd162dc94ee50a287
Reviewed-on: https://chromium-review.googlesource.com/1090234
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565859}
[modify] https://crrev.com/d35ae16c1b4b3f2b6262b75cd271c79f3267b452/ui/gfx/color_space.cc
[modify] https://crrev.com/d35ae16c1b4b3f2b6262b75cd271c79f3267b452/ui/gfx/color_space.h
[modify] https://crrev.com/d35ae16c1b4b3f2b6262b75cd271c79f3267b452/ui/gfx/color_space_unittest.cc

Comment 11 by m...@chromium.org, Aug 15

Status: Started (was: Assigned)

Comment 12 by bugdroid1@chromium.org, Sep 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35735c3d318b33b6b71102c2cd70c4775153955e

commit 35735c3d318b33b6b71102c2cd70c4775153955e
Author: Yuri Wiitala <miu@chromium.org>
Date: Fri Sep 07 21:47:05 2018

Introduce new GLScaler (API only) to replace GLHelper+GLHelperScaler.

Introduces the "outer shell" API to for GLScaler, with upcoming patches
coming soon to fill-in the rest of the implementation. This is a major
refactoring of GLHelper+GLHelperScaler to: 1) fix dangerous memory
management issues, 2) provide a cleaner interface for client-side code,
3) unblock performance and color management efforts.

Bug: 870036,758057
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ib8f0ed9b988bfe914bd8983940b089262543e8c7
Reviewed-on: https://chromium-review.googlesource.com/1194783
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589674}
[modify] https://crrev.com/35735c3d318b33b6b71102c2cd70c4775153955e/components/viz/common/BUILD.gn
[modify] https://crrev.com/35735c3d318b33b6b71102c2cd70c4775153955e/components/viz/common/DEPS
[add] https://crrev.com/35735c3d318b33b6b71102c2cd70c4775153955e/components/viz/common/gl_scaler.cc
[add] https://crrev.com/35735c3d318b33b6b71102c2cd70c4775153955e/components/viz/common/gl_scaler.h
[add] https://crrev.com/35735c3d318b33b6b71102c2cd70c4775153955e/components/viz/common/gl_scaler_unittest.cc

Comment 13 by m...@chromium.org, Sep 25

Blocking: 884170
Summary: Screen capture (snapshot or video) needs to be color space aware, and do the right things. (was: RenderWidgetHostView::CopyFromSurface[ToVideoFrame] is color space unaware)

Comment 14 by m...@chromium.org, Sep 25

Labels: -Pri-3 M-71 Pri-2
Raising priority due to VIZ launch (and DevTools reliance on this functionality).

Comment 15 by bugdroid1@chromium.org, Nov 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82751409267d5f4bfc718aebb728ae42f04e2ba6

commit 82751409267d5f4bfc718aebb728ae42f04e2ba6
Author: Yuri Wiitala <miu@chromium.org>
Date: Tue Nov 27 06:16:51 2018

GLRendererCopier: Replace use of GLHelper with GLScaler/GLI420Converter.

Switches-over GLRendererCopier to use the new GLScaler and
GLI420Converter when scaling and/or format-converting images for
CopyOutputRequests. This change also addresses:

1. Simpler handling of cached GL resources (used across copy requests
having the same requester). Rather than separate methods for each of the
possible cached resources (with some duplicated logic), there is now one
"ReusableThings" struct to hold them all (and is passed around on the
stack).

2. Simplified the I420 code around handling of "packed textures" and
"aligned rects".

3. Simplified the detection/execution of whether to byte-swizzle on the
CPU (after readback) or GPU (before readback). Simplified the RGBA
bitmap copy-from-pixel-buffer code (w.r.t. upside-down row-by-row copy
and byte-swizzling).

Testing: Confirmed existing unit and pixel tests are thoroughly-testing
all possible code paths in GLRendererCopier. Manually confirmed tab and
desktop capture (incl. CrOS), and screenshots work.

Performance improvement: A local run of performance_browser_tests, on a
machine with a high-end nVidia GPU, has shown a ~20% improvement in
capture latency (i.e., the interval of time from when copy request was
issued until an SkBitmap result is ready in system memory).
http://chromeperf.appspot.com/ will reveal how other platform
configurations are affected.

Bug: 870036, 810131 , 781986 ,758057
Binary-Size: Increase is temporary (linking in new impl, future CLs will switch-over other clients to stop using old impl).
Change-Id: Ibcb16c1382ea0cffb00bc7605e0594b1fe28356a
Reviewed-on: https://chromium-review.googlesource.com/c/1343247
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611027}
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/components/viz/common/gl_scaler.cc
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/components/viz/common/gl_scaler_pixeltest.cc
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/components/viz/service/display/copy_output_scaling_pixeltest.cc
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/components/viz/service/display/gl_renderer_copier.cc
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/components/viz/service/display/gl_renderer_copier.h
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/components/viz/service/display/gl_renderer_copier_pixeltest.cc
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/components/viz/service/display/gl_renderer_copier_unittest.cc
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/content/browser/media/capture/fake_video_capture_stack.cc
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/content/browser/media/capture/frame_test_util.h
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/content/browser/media/capture/web_contents_video_capture_device_browsertest.cc
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/content/browser/renderer_host/render_widget_host_view_browsertest.cc

Comment 16 by bugdroid1@chromium.org, Dec 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e11bc0021526187e0ec0cf8e8875d232f5519fb2

commit e11bc0021526187e0ec0cf8e8875d232f5519fb2
Author: Yuri Wiitala <miu@chromium.org>
Date: Sat Dec 08 05:46:39 2018

Plumb color space into layer tree readback pixel tests.

A soon-upcoming change will complete the color space plumbing in the
viz::DirectRenderers' CopyOutputRequest execution pipelines. Tests will
require that the pixel test infrastructure pass a texture's color space
data through to its SkBitmap readback results.

Bug: 758057
Change-Id: Ica583cbc969e8da9316d1da65a12837f490657fb
Reviewed-on: https://chromium-review.googlesource.com/c/1368411
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614953}
[modify] https://crrev.com/e11bc0021526187e0ec0cf8e8875d232f5519fb2/cc/test/layer_tree_pixel_test.cc
[modify] https://crrev.com/e11bc0021526187e0ec0cf8e8875d232f5519fb2/cc/test/layer_tree_pixel_test.h
[modify] https://crrev.com/e11bc0021526187e0ec0cf8e8875d232f5519fb2/cc/trees/layer_tree_host_pixeltest_readback.cc

Comment 17 by bugdroid1@chromium.org, Dec 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fee454f21e59fed7415b692a542af225fd27d33

commit 6fee454f21e59fed7415b692a542af225fd27d33
Author: Yuri Wiitala <miu@chromium.org>
Date: Mon Dec 10 10:51:54 2018

Make ChromeDriver.testTakeElementScreenshot() color space friendly.

Uses the web engine itself to sanity-check the element snapshot PNG,
rather than doing an exact binary comparison of an expected PNG file's
content. This will unblock a soon-upcoming change where the screen
capture pipeline will become color space aware, and so the PNG file from
the snapshot API will start including different color space metadata
(even though its pixel values will be exactly the same).

An extra benefit to testing this way is that more of the browser will
be tested for color space awareness/correctness (i.e., its PNG image
decoder, and HTML Canvas drawing and readback).

Bug: 758057
Change-Id: Ibde9a18fe6b70b5c6532e1f888f8db2c4549eb9b
Reviewed-on: https://chromium-review.googlesource.com/c/1369037
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615078}
[modify] https://crrev.com/6fee454f21e59fed7415b692a542af225fd27d33/chrome/test/chromedriver/test/run_py_tests.py
[delete] https://crrev.com/d20372bed4393fc15612798427847dd7c9a7d1b0/chrome/test/data/chromedriver/goldenScreenshots/redboxScreenshot.png

Comment 18 by bugdroid1@chromium.org, Dec 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/046e446b56764939026ad97d198ff63410f629af

commit 046e446b56764939026ad97d198ff63410f629af
Author: Yuri Wiitala <miu@chromium.org>
Date: Tue Dec 11 18:57:51 2018

Implement SkColorSpace struct traits in skia.mojom.ImageInfo.

Completes the skia mojom struct traits implementation for ImageInfo by
using Skia's built-in SkColorSpace::serialize() functionality. This
allows for exact SkColorSpaces to be efficiently transmitted, alongside
things like SkBitmaps, through mojo message pipes.

Later work to improve color space management in Chromium will depend on
this change. (See crbugs for examples.)

Bug: 758057,  809385 
Change-Id: I1193f81c727d8663370fd6fd802edd9dd397abff
Reviewed-on: https://chromium-review.googlesource.com/c/1357633
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615611}
[modify] https://crrev.com/046e446b56764939026ad97d198ff63410f629af/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/046e446b56764939026ad97d198ff63410f629af/skia/public/interfaces/image_info.mojom
[modify] https://crrev.com/046e446b56764939026ad97d198ff63410f629af/skia/public/interfaces/image_info_struct_traits.cc
[modify] https://crrev.com/046e446b56764939026ad97d198ff63410f629af/skia/public/interfaces/image_info_struct_traits.h
[modify] https://crrev.com/046e446b56764939026ad97d198ff63410f629af/skia/public/interfaces/test/OWNERS
[modify] https://crrev.com/046e446b56764939026ad97d198ff63410f629af/skia/public/interfaces/test/struct_traits_unittest.cc

Comment 19 by bugdroid1@chromium.org, Dec 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed44fc45d0c3b3675efec4c550d28c5de1569c9d

commit ed44fc45d0c3b3675efec4c550d28c5de1569c9d
Author: Yuri Wiitala <miu@chromium.org>
Date: Sat Dec 15 03:14:24 2018

Complete the screen capture color space plumbing.

Adds all remaining "plumbing" of color space information, throughout the
CopyOutputRequest execution pipeline and the FrameSinkVideoCapturer
pipeline. This ensures the color space being used to draw the original
RenderPass within the compositor is being specified in the metadata for
all result images.

DevTools: Remove a hack from the color picker tool, now that the color
space information for the screen capture frame is being provided.

browser_tests/content_browsertests changes: Multilple browser tests were
fixed as a result of this change revealing pre-existing bugs in the
tests: the web page layout of the color regions, how pixels were being
selected for analysis, and YUV→RGB color space conversion inaccuracies.

Blink layout tests: Rebased a number of layout test expectations, as the
the layout tests utilize the screen capture pipeline. I examined all of
these changed expectations to confirm near 0% change: Meaning that just
a tiny number of pixels in an image were imperceivably different because
of adding the missing color space info.

Bug: 758057, 8510131,  809835 , 863103, 884170, 795132
Change-Id: I11056ddc4f501ee338dc3283397703747a395571
Reviewed-on: https://chromium-review.googlesource.com/c/1372894
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616936}
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/chrome/browser/devtools/devtools_eye_dropper.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/chrome/test/data/extensions/api_test/tab_capture/offscreen_end_to_end.js
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/common/frame_sinks/copy_output_result.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/common/frame_sinks/copy_output_result.h
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display/gl_renderer_copier.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display/skia_output_surface.h
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display/software_renderer.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display_embedder/skia_output_surface_impl.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display_embedder/skia_output_surface_impl.h
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.h
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/frame_sinks/video_capture/interprocess_frame_pool.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/frame_sinks/video_capture/interprocess_frame_pool.h
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/frame_sinks/video_capture/video_capture_overlay.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/frame_sinks/video_capture/video_capture_overlay.h
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/frame_sinks/video_capture/video_capture_overlay_unittest.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/aura_window_video_capture_device_browsertest.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/content_capture_device_browsertest_base.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/fake_video_capture_stack.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/frame_test_util.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/frame_test_util.h
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/lame_window_capturer_chromeos.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/web_contents_video_capture_device_browsertest.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/remoting/host/chromeos/aura_desktop_capturer_unittest.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/editing/selection/4402375-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/editing/selection/replaced-boundaries-1-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/editing/selection/replaced-boundaries-2-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/editing/selection/replaced-boundaries-3-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/editing/selection/transformed-selection-rects-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/paint/invalidation/svg/text-selection-text-05-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/foreignObject-text-clipping-bug-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/selection-doubleclick-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/selection-tripleclick-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-align-02-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-align-03-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-align-04-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-align-06-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-intro-05-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-path-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-spacing-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-text-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-text-03-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-text-06-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-text-08-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-ws-02-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/textPathBoundsBug-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac-mac10.10/editing/selection/replaced-boundaries-3-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac-mac10.11/editing/selection/replaced-boundaries-3-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/editing/selection/4402375-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/editing/selection/replaced-boundaries-1-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/editing/selection/replaced-boundaries-2-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/editing/selection/replaced-boundaries-3-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/editing/selection/transformed-selection-rects-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/paint/invalidation/svg/text-selection-text-05-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/foreignObject-text-clipping-bug-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/selection-doubleclick-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/selection-tripleclick-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-align-03-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-align-04-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-align-06-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-path-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-spacing-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-text-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-text-03-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-text-04-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-text-06-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-text-08-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-tselect-02-f-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-tspan-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-ws-01-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-ws-02-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/textPathBoundsBug-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/editing/selection/4402375-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/editing/selection/replaced-boundaries-1-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/editing/selection/replaced-boundaries-2-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/editing/selection/replaced-boundaries-3-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/editing/selection/transformed-selection-rects-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/paint/invalidation/svg/text-selection-text-05-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/foreignObject-text-clipping-bug-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/selection-tripleclick-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-align-02-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-align-03-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-align-04-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-align-05-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-align-06-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-path-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-spacing-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-text-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-text-03-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-text-06-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-text-08-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-tselect-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-tselect-02-f-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-tspan-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-ws-01-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-ws-02-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/textPathBoundsBug-expected.png
[delete] https://crrev.com/4c40f61f89ae4d0a196c2c7b14b696bb7b5e0430/third_party/blink/web_tests/platform/win7/editing/selection/replaced-boundaries-1-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win7/svg/text/text-selection-text-08-b-expected.png

Comment 20 by bugdroid1@chromium.org, Dec 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98a8f01a27f97ec27e6315fb006e61cd59192d29

commit 98a8f01a27f97ec27e6315fb006e61cd59192d29
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Mon Dec 17 11:41:19 2018

[LayoutNG] Rebaseline test expectations after color space changes.

https://chromium-review.googlesource.com/c/chromium/src/+/1372894 made
some invisible (to the naked eye) rebaselining to some test
expectations, but not for LayoutNG.

TBR=kojii@chromium.org

Bug: 758057, 8510131,  809835 , 863103, 884170, 795132
Change-Id: Ie6b626c66c0930b1c8c00b7b01a0f01ddd06dada
Reviewed-on: https://chromium-review.googlesource.com/c/1379953
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617089}
[modify] https://crrev.com/98a8f01a27f97ec27e6315fb006e61cd59192d29/third_party/blink/web_tests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/98a8f01a27f97ec27e6315fb006e61cd59192d29/third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/editing/selection/4402375-expected.png
[modify] https://crrev.com/98a8f01a27f97ec27e6315fb006e61cd59192d29/third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/editing/selection/transformed-selection-rects-expected.png
[modify] https://crrev.com/98a8f01a27f97ec27e6315fb006e61cd59192d29/third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/svg/text/foreignObject-text-clipping-bug-expected.png

Comment 21 by m...@chromium.org, Dec 18

Blocking: -884170

Comment 22 by m...@chromium.org, Dec 18

Status: Only remaining work on this is to clean-up the SetFormat() mojo API in viz::FrameSinkVideoCapturer. Meaning, remove color space from that because it is a better design to avoid color space conversion at all costs until the final display endpoint is reached (to avoid introducing excessive quantization and other rounding errors).

Sign in to add a comment