New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758048 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Fix display names for detected zeroconf printers

Project Member Reported by justincarlson@chromium.org, Aug 23 2017

Issue description

Right now they have protocol details appended to them, they should be clean for UI display.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f418c0fbf163db1a54b10cc11bd6d62a09a081ed

commit f418c0fbf163db1a54b10cc11bd6d62a09a081ed
Author: Justin Carlson <justincarlson@chromium.org>
Date: Wed Aug 23 02:06:38 2017

Fix printer deduplication for zeroconf printers.

Bug:  758048 
Change-Id: Ib6ca673fc324f1b6a0eace572c106fcb9f5f762d
Reviewed-on: https://chromium-review.googlesource.com/627524
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496553}
[modify] https://crrev.com/f418c0fbf163db1a54b10cc11bd6d62a09a081ed/chrome/browser/chromeos/printing/zeroconf_printer_detector.cc

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/252178c30ceccb8f5be3e89f4ba421a4d27ddda2

commit 252178c30ceccb8f5be3e89f4ba421a4d27ddda2
Author: Justin Carlson <justincarlson@chromium.org>
Date: Wed Aug 23 18:00:37 2017

Make zeroconf printer display names user readable

Bug:  758048 
Change-Id: If94ac3244d58a5030a72e60fdca7219b62b77f6b
Reviewed-on: https://chromium-review.googlesource.com/627244
Commit-Queue: Justin Carlson <justincarlson@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496734}
[modify] https://crrev.com/252178c30ceccb8f5be3e89f4ba421a4d27ddda2/chrome/browser/chromeos/printing/zeroconf_printer_detector.cc

Comment 4 by skau@chromium.org, Aug 23 2017

Labels: Merge-Request-61
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 23 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by skau@chromium.org, Aug 28 2017

Cc: weifangsun@chromium.org

Comment 7 by ketakid@google.com, Aug 30 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 31 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37c498bfa8dde698d1623c46163fef4e0098b993

commit 37c498bfa8dde698d1623c46163fef4e0098b993
Author: Sean Kau <skau@chromium.org>
Date: Thu Aug 31 01:06:11 2017

Fix printer deduplication for zeroconf printers.

TBR=justincarlson@chromium.org

(cherry picked from commit f418c0fbf163db1a54b10cc11bd6d62a09a081ed)

Bug:  758048 
Change-Id: Ib6ca673fc324f1b6a0eace572c106fcb9f5f762d
Reviewed-on: https://chromium-review.googlesource.com/627524
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496553}
Reviewed-on: https://chromium-review.googlesource.com/644165
Cr-Commit-Position: refs/branch-heads/3163@{#1024}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/37c498bfa8dde698d1623c46163fef4e0098b993/chrome/browser/chromeos/printing/zeroconf_printer_detector.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b0bd15517210b4a64705e8a3e5b58c2bb2fc6ab

commit 0b0bd15517210b4a64705e8a3e5b58c2bb2fc6ab
Author: Sean Kau <skau@chromium.org>
Date: Thu Aug 31 01:07:48 2017

Make zeroconf printer display names user readable

TBR=justincarlson@chromium.org

(cherry picked from commit 252178c30ceccb8f5be3e89f4ba421a4d27ddda2)

Bug:  758048 
Change-Id: If94ac3244d58a5030a72e60fdca7219b62b77f6b
Reviewed-on: https://chromium-review.googlesource.com/627244
Commit-Queue: Justin Carlson <justincarlson@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496734}
Reviewed-on: https://chromium-review.googlesource.com/644731
Cr-Commit-Position: refs/branch-heads/3163@{#1025}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/0b0bd15517210b4a64705e8a3e5b58c2bb2fc6ab/chrome/browser/chromeos/printing/zeroconf_printer_detector.cc

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment