New issue
Advanced search Search tips

Issue 758040 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 754872



Sign in to add a comment

Removing GLRenderer::pending_async_read_pixels_

Project Member Reported by m...@chromium.org, Aug 23 2017

Issue description

While async readpixels operations execute in GLRenderer, we create a PendingAsyncReadPixels struct and insert it into a side vector that is owned by the class. Then, later, when the callback is run, we scan the vector again and pull out the entry that matches the |buffer| argument in the callback function.

This seems totally unnecessary. We should remove the "side vector" and the PendingAsyncReadPixels struct, and just pass all needed variables in the base::Bind(...) to become arguments to the callback function.

Speculation: It's possible that, in the past, GLRenderer had to keep track of this stuff to provide a clean early shutdown. However, no other code seems to make use of the "side vector" anymore.
 

Comment 1 by m...@chromium.org, Nov 8 2017

Status: Fixed (was: Available)
This was done as part of work on  bug 760348 .

Sign in to add a comment