New issue
Advanced search Search tips

Issue 758039 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: 2017-11-10
OS: Windows
Pri: 3
Type: Bug
Launch-M-Target: 64-Beta



Sign in to add a comment

Harmony - uninstall confirmation dialog (needs mock)

Project Member Reported by bsep@chromium.org, Aug 23 2017

Issue description

This is UninstallView, pops up when the user tries to uninstall Chrome. I can't find an existing bug or mock for this dialog.
 
uninstall-view.PNG
26.4 KB View Download
Labels: -Pri-3 OS-Chrome OS-Linux OS-Mac Pri-2
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27dde4eb7c5f2db122a2d3e9167a2cec918e6ba9

commit 27dde4eb7c5f2db122a2d3e9167a2cec918e6ba9
Author: Bret Sepulveda <bsep@chromium.org>
Date: Thu Aug 24 01:10:46 2017

Add BrowserDialogTest for UninstallView.

Bug: 758039
Change-Id: I647bfd72eaa6873ad8fccee11e67f00b29253f69
Reviewed-on: https://chromium-review.googlesource.com/627044
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496904}
[add] https://crrev.com/27dde4eb7c5f2db122a2d3e9167a2cec918e6ba9/chrome/browser/ui/views/uninstall_view_browsertest.cc
[modify] https://crrev.com/27dde4eb7c5f2db122a2d3e9167a2cec918e6ba9/chrome/test/BUILD.gn

Comment 3 by bettes@chromium.org, Aug 29 2017

Instructions on how to get this? 

Comment 4 by bsep@chromium.org, Aug 29 2017

Labels: -OS-Linux -OS-Chrome -OS-Mac
Windows-only. Just try to uninstall Chrome.

Comment 5 by bettes@chromium.org, Aug 30 2017

Cc: hwi@chromium.org
Oh wow. This dialog just floats in the abyss without any Chrome window attached to it. 

How difficult would it be to remove this from views and just let the OS handle this (via native dialog)? 

Between open a new chrome window vs. show native OS dialog, I'd rather have the OS take care of this action. 


Screenshot (2).png
1.0 MB View Download

Comment 6 by bsep@chromium.org, Aug 30 2017

As far as I'm aware the Windows uninstall just invokes an exe... the "native" uninstall dialog is a standard software package that we don't use. So to answer your question directly, it would be very very difficult.
Labels: Launch-M-Target-64-Beta
NextAction: 2017-11-10
My recommendation is to move this to a P3 and focus this for next phase.
Cc: bettes@chromium.org
Labels: -Pri-2 Pri-3
Owner: ----
Status: Available (was: Assigned)
The NextAction date has arrived: 2017-11-10
Project Member

Comment 12 by sheriffbot@chromium.org, Oct 22

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment