PaymentRequestDataURLEGTest/testCanMakePaymentDataURL is disabled. |
|||
Issue descriptionPaymentRequestDataURLEGTest/testCanMakePaymentDataURL in the ios_chrome_payments_egtest target is broken on all configurations. https://chromium-review.googlesource.com/c/chromium/src/+/617022 is the culprit.
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f19e0e3d0d30b7c9613a2e02ff39212f87cae5c0 commit f19e0e3d0d30b7c9613a2e02ff39212f87cae5c0 Author: Gregory Chatzinoff <gchatz@chromium.org> Date: Wed Aug 23 01:38:59 2017 Disable PaymentRequestDataURLEGTest/testCanMakePaymentDataURL. TBR=mahmadi Bug: 758038 Change-Id: I5db7b82f8b9117d8731c62c4910619121caa9593 Reviewed-on: https://chromium-review.googlesource.com/627046 Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#496548} [modify] https://crrev.com/f19e0e3d0d30b7c9613a2e02ff39212f87cae5c0/ios/chrome/browser/ui/payments/payment_request_data_url_egtest.mm
,
Aug 23 2017
Moe: Seems this test need fixing. Do you have any suggestions?
,
Aug 23 2017
PaymentRequestDataURLEGTest.testShowDataURL and PaymentRequestDataURLEGTest.testCanMakePaymentDataURL should be removed as they're not valid anymore after https://chromium-review.googlesource.com/c/chromium/src/+/617022 However I'm wondering why only one is failing.
,
Aug 23 2017
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/644477920ef1dbce3cc9f6390bf9cc23ec2d6afb commit 644477920ef1dbce3cc9f6390bf9cc23ec2d6afb Author: Mohamad Ahmadi <mahmadi@chromium.org> Date: Wed Aug 23 15:16:18 2017 [Payment Request] Removes EG tests that are not valid any longer PaymentRequestDataURLEGTest.testShowDataURL and PaymentRequestDataURLEGTest.testCanMakePaymentDataURL are no longer valid tests after https://chromium-review.googlesource.com/617022 which does a more robust context security check in JS and therefore prevents the Payment Request object from being created. Bug: 758038 Change-Id: I548474d4c3a2c81fc7353adeb70774da29a73135 Reviewed-on: https://chromium-review.googlesource.com/628977 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: mahmadi (Moe) <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#496689} [modify] https://crrev.com/644477920ef1dbce3cc9f6390bf9cc23ec2d6afb/ios/chrome/browser/ui/payments/payment_request_data_url_egtest.mm
,
Aug 23 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by gch...@chromium.org
, Aug 23 2017