New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758033 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Add a link to the sanity build failure in the alert message.

Project Member Reported by pho...@chromium.org, Aug 23 2017

Issue description

we could emit a gauge like /chrome/infra/chromeos/cbuildbot/build/sanity_build_completed_id

It would have a StringField('config') and BooleanField("success"), and its value would be the latest sanity build for that config which returned that status.

Then we could do an align with a 1h lookback to try to find the latest build id that failed for a given config, and we could construct the link from the fields of the matched points.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/819eae32c13b7bb9cc040ac2655f79ef6fd0e316

commit 819eae32c13b7bb9cc040ac2655f79ef6fd0e316
Author: Paul Hobbs <phobbs@google.com>
Date: Sat Aug 26 02:54:12 2017

report_stages: Add a sanity_build_id metric

This will be useful to generate a link to the last failing sanity build when we
send and alert.

BUG= chromium:758033 
TEST=None

Change-Id: I5a35bfefe6faa326686a0e3b4c8426c2f43a5aa4
Reviewed-on: https://chromium-review.googlesource.com/631038
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/819eae32c13b7bb9cc040ac2655f79ef6fd0e316/lib/constants.py
[modify] https://crrev.com/819eae32c13b7bb9cc040ac2655f79ef6fd0e316/cbuildbot/stages/report_stages.py

Comment 2 by pho...@chromium.org, Aug 28 2017

Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/1bceeda81eeffd4309c7d8c8e14e347cf477de57

commit 1bceeda81eeffd4309c7d8c8e14e347cf477de57
Author: Paul Hobbs <phobbs@google.com>
Date: Fri Sep 01 01:05:50 2017

report_stages: Add builder_name to sanity_build_id metric.

We need the builder name to get a link to the waterfall in our alert.

BUG= chromium:758033 
TEST=None

Change-Id: I7727169059100dd3ba1a24cc44a6ab9433a46883
Reviewed-on: https://chromium-review.googlesource.com/642191
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/1bceeda81eeffd4309c7d8c8e14e347cf477de57/cbuildbot/stages/report_stages.py

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/826dddcb6f32a9030bf55865cef6dfab4228cd7f

commit 826dddcb6f32a9030bf55865cef6dfab4228cd7f
Author: Paul Hobbs <phobbs@google.com>
Date: Sat Sep 16 04:25:43 2017

report_stages: build_number for sanity builds

To recover the link to the sanity build failure in an alert, we need the
buildnumber, not the build_id (which is the id of the build in cidb).

BUG= chromium:758033 
TEST=None

Change-Id: I43ad6a949868348a973f243f4f94649b392d4fba
Reviewed-on: https://chromium-review.googlesource.com/664222
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/826dddcb6f32a9030bf55865cef6dfab4228cd7f/cbuildbot/stages/report_stages.py

Components: Infra>Client>ChromeOS>CI
Components: -Infra>Client>ChromeOS

Comment 7 by pho...@chromium.org, Apr 21 2018

Status: Fixed (was: Started)

Sign in to add a comment