New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758032 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 757517



Sign in to add a comment

[Findit] Look for any successful build after the failed build before revert or send notifications

Project Member Reported by chanli@chromium.org, Aug 23 2017

Issue description

Currently before Findit reverts or sends notifications, it'll check if the latest build is green. But For a case the builds are:
Failed -> Succeeded -> Failed, Findit should bail out as well.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7092a625e66f54445ea53d867b9cb436c3340acb

commit 7092a625e66f54445ea53d867b9cb436c3340acb
Author: Chan <chanli@chromium.org>
Date: Mon Aug 28 17:11:08 2017

[Findit] Look for any successful build after the failed build before revert or send notifications

Bug:  758032 
Change-Id: Ib705bf680a25a0030234e75c6509b2e2a69d59ed
Reviewed-on: https://chromium-review.googlesource.com/627584
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/7092a625e66f54445ea53d867b9cb436c3340acb/appengine/findit/waterfall/revert_and_notify_culprit_pipeline.py
[modify] https://crrev.com/7092a625e66f54445ea53d867b9cb436c3340acb/appengine/findit/waterfall/test/revert_and_notify_culprit_pipeline_test.py

Comment 2 by chanli@chromium.org, Aug 28 2017

Status: Fixed (was: Assigned)

Sign in to add a comment