New issue
Advanced search Search tips

Issue 758027 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug


Participants' hotlists:
ExternalNavigationIssues


Sign in to add a comment

Open in a new tab launches an intent

Project Member Reported by mariakho...@chromium.org, Aug 22 2017

Issue description

On low-end device:

1) Search for a music video
2) click on youtube result "open in a new tab"
3) Use tabswitcher to switch to the new tab
4) Youtube app gets opened
 
Components: Mobile>Intents
Owner: thildebr@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7caff8106afc4ca187dc158551698107eb7a001e

commit 7caff8106afc4ca187dc158551698107eb7a001e
Author: Troy Hildebrandt <thildebr@chromium.org>
Date: Fri Mar 09 22:20:40 2018

[Android] Avoid overriding with intent when lazy loading a frozen tab.

Opening a link in a new tab on low end devices freezes the tab to be
lazily loaded when the tab is used for the first time. Opening links
with intents from a frozen state causes us to override the URL handling
with the external intent which results in an app being launched on
selecting that tab, or the picker being shown, instead of seeing the
contents at the URL displayed in the tab.

This patch treats the page transition type sent to #loadUrl as RELOAD
whenever we're loading a URL for the first time in a frozen tab which
avoids starting another activity.

Bug:  758027 
Change-Id: I89e63fb51b00d1c62b12c8f6d827e3e907e463b1
Reviewed-on: https://chromium-review.googlesource.com/956558
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542250}
[modify] https://crrev.com/7caff8106afc4ca187dc158551698107eb7a001e/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

Status: Fixed (was: Assigned)

Sign in to add a comment