New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758020 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Task



Sign in to add a comment

Add Answer Card UMA

Project Member Reported by newcomer@chromium.org, Aug 22 2017

Issue description

Currently opening an answer card is not recorded in UMA.

This should be fixed so that answer cards are recorded like other search results.
 
Components: UI>Shell>Launcher
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 22 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by gov...@chromium.org, Aug 23 2017

Pls apply appropriate OSs. Thank you.
Labels: OS-Chrome
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a68f77c2447925cb46732110a3f26aa75ca1026f

commit a68f77c2447925cb46732110a3f26aa75ca1026f
Author: Alex Newcomer <newcomer@chromium.org>
Date: Wed Aug 23 20:08:12 2017

cros:Added UMA for an answer card result being opened.

Added a call to RecordHistogram on an answer card being opened.

Bug:  758020 
Change-Id: I31888026d9096b3fbefe148c014598cb0563abbf
Reviewed-on: https://chromium-review.googlesource.com/627660
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496781}
[modify] https://crrev.com/a68f77c2447925cb46732110a3f26aa75ca1026f/chrome/browser/ui/app_list/search/answer_card/answer_card_result.cc
[modify] https://crrev.com/a68f77c2447925cb46732110a3f26aa75ca1026f/chrome/browser/ui/app_list/search/search_util.h
[modify] https://crrev.com/a68f77c2447925cb46732110a3f26aa75ca1026f/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 28 2017

Cc: keta...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 30 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34a1c8cd4f8fd7bb9af24416a96baa72d7f5bd9c

commit 34a1c8cd4f8fd7bb9af24416a96baa72d7f5bd9c
Author: Maajid <maajid@chromium.org>
Date: Wed Aug 30 02:02:01 2017

cros:Added UMA for an answer card result being opened.

Added a call to RecordHistogram on an answer card being opened.

TBR=newcomer@chromium.org

(cherry picked from commit a68f77c2447925cb46732110a3f26aa75ca1026f)

Bug:  758020 
Change-Id: I31888026d9096b3fbefe148c014598cb0563abbf
Reviewed-on: https://chromium-review.googlesource.com/627660
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496781}
Reviewed-on: https://chromium-review.googlesource.com/642177
Cr-Commit-Position: refs/branch-heads/3163@{#988}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/34a1c8cd4f8fd7bb9af24416a96baa72d7f5bd9c/chrome/browser/ui/app_list/search/answer_card/answer_card_result.cc
[modify] https://crrev.com/34a1c8cd4f8fd7bb9af24416a96baa72d7f5bd9c/chrome/browser/ui/app_list/search/search_util.h
[modify] https://crrev.com/34a1c8cd4f8fd7bb9af24416a96baa72d7f5bd9c/tools/metrics/histograms/enums.xml

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment