New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758013 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Settings UI incorrectly shows a PIN unlock dialog when a PUK is required

Project Member Reported by benchan@chromium.org, Aug 22 2017

Issue description

When a PUK is required to unlock a SIM, clicking the "Unlock" button on the settings UI currently pops up a PIN unlock dialog, instead of a PUK unlock dialog.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62a532d02ae7c3f21d1b6405d82a4371a670e44e

commit 62a532d02ae7c3f21d1b6405d82a4371a670e44e
Author: Ben Chan <benchan@chromium.org>
Date: Wed Aug 23 22:30:44 2017

Show PUK unlock dialog if a PUK is required to unlock the SIM.

This CL updates the SIM unlock UI to show a PUK unlock dialog, instead
of a PIN unlock dialog, if a PUK is required to unlock the SIM.

BUG= 758013 
TEST=Tested the following:
- When a PIN is required to unlock the SIM, verify that a PIN unlock
  dialog is shown by clicking the "Unlock" button on the settings UI.
- When a PUK is required to unlock the SIM, verify that a PUK unlock
  dialog is shown by clicking the "Unlock" button on the settings UI.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5a45929394c540170d026a1f040f25009ee02eb3
Reviewed-on: https://chromium-review.googlesource.com/627644
Commit-Queue: Ben Chan <benchan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496835}
[modify] https://crrev.com/62a532d02ae7c3f21d1b6405d82a4371a670e44e/chrome/browser/resources/settings/internet_page/network_siminfo.js

Status: Fixed (was: Started)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment