New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758007 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 772529

Blocking:
issue 468053



Sign in to add a comment

Milo: Need blamelist / build diff functionality

Project Member Reported by iannucci@chromium.org, Aug 22 2017

Issue description

In order to let Milo replace buildbot, it's missing the blamelist feature that buildbot currently has. The source manifest work that we've done already should enable this in Milo cleanly.

I think we'll want to evolve this in three phases:
  * Manifest display (observe and print all the manifests associated with a given build)
  * Build diff (given two builds diff the manifests and display gerrit oneline logs for them).
  * Blamelist (observe the "previous" build based on the current state of the console for this builder and then use that as the diff target for this build).
 

Comment 1 by s...@google.com, Aug 31 2017

Status: Available (was: Untriaged)
Cc: iannucci@chromium.org mknyszek@google.com hinoka@chromium.org
 Issue 764483  has been merged into this issue.
Blocking: 468053

Comment 4 by efoo@chromium.org, Sep 13 2017

Labels: LUCI-M3-S8 REQBY-LUCI-M5-Migration LUCI-M3-ClosedBeta
Assigning to M3-S8

Comment 5 by efoo@chromium.org, Sep 13 2017

LUCI planning lists the following tasks related to blamelists. Please when each of these are tackled. Thanks!

Add bot_update/gclient export source manifest 
Add git.checkout export source manifest
Add recipe.cfg export source manifest 
Inject data in milo from recipe engine 
Integrate source manifest proto with chromium_checkout module 

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/0a6b1814f0646d43ec63cd77fc5f16f9e0b9ac29

commit 0a6b1814f0646d43ec63cd77fc5f16f9e0b9ac29
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Sep 13 23:26:36 2017

[milo] Add get+cache api for source manifests.

This pulls source manifests using a ManifestLink. If Milo has a cached
version tagged with the optional SHA256, it'll return that, otherwise it
will ingest and cache the manifest from the given logdog url.

R=hinoka@chromium.org, mknyszek@chromium.org

Bug:  758007 
Change-Id: If8d3abb3d37d2611b5b9ffb1301e9e63371f1ffb
Reviewed-on: https://chromium-review.googlesource.com/663789
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/0a6b1814f0646d43ec63cd77fc5f16f9e0b9ac29/milo/api/proto/manifest/generate.go
[delete] https://crrev.com/c451901e422a7a06a932de76736ea9abd33b3ee5/milo/api/proto/manifest/proto_gae.gen.go
[modify] https://crrev.com/0a6b1814f0646d43ec63cd77fc5f16f9e0b9ac29/milo/buildsource/rawpresentation/build.go
[modify] https://crrev.com/0a6b1814f0646d43ec63cd77fc5f16f9e0b9ac29/milo/buildsource/rawpresentation/html.go
[add] https://crrev.com/0a6b1814f0646d43ec63cd77fc5f16f9e0b9ac29/milo/srcman/doc.go
[add] https://crrev.com/0a6b1814f0646d43ec63cd77fc5f16f9e0b9ac29/milo/srcman/get.go
[add] https://crrev.com/0a6b1814f0646d43ec63cd77fc5f16f9e0b9ac29/milo/srcman/get_test.go
[add] https://crrev.com/0a6b1814f0646d43ec63cd77fc5f16f9e0b9ac29/milo/srcman/model.go

Comment 7 by hinoka@chromium.org, Sep 14 2017

Owner: iannucci@chromium.org
Status: Assigned (was: Available)
Robbie I'm assuming you're working on this, unassign yourself if you're not.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/0d0456a9c4df1a39a190b0efea94efd1aa6bac30

commit 0d0456a9c4df1a39a190b0efea94efd1aa6bac30
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Sep 20 00:28:17 2017

[milo] add simple diff function for source manifests.

R=hinoka@chromium.org, nodir@chromium.org

Bug:  758007 
Change-Id: I942f3fd7b0fb4452561c1f88fb931a6d4c6b3bbb
Reviewed-on: https://chromium-review.googlesource.com/671807
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[add] https://crrev.com/0d0456a9c4df1a39a190b0efea94efd1aa6bac30/milo/srcman/diff.go
[add] https://crrev.com/0d0456a9c4df1a39a190b0efea94efd1aa6bac30/milo/srcman/diff_test.go

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/5040ef006fc0e97eb542a2777b647dee7846f9c1

commit 5040ef006fc0e97eb542a2777b647dee7846f9c1
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Sep 26 17:43:31 2017

[milo] Move source_manifest.proto to common/proto/milo.

Since the source manifests are a mechanism of communicating with milo, it
makes more sense to put them along-side the annotation proto definition,
not off on their own.

R=hinoka@chromium.org, nodir@chromium.org

Bug:  758007 
Change-Id: I4a9d8fa9a67af489bf8845a3fe4b41a15bb8e3de
Reviewed-on: https://chromium-review.googlesource.com/683658
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/5040ef006fc0e97eb542a2777b647dee7846f9c1/common/proto/milo/annotations.pb.go
[rename] https://crrev.com/5040ef006fc0e97eb542a2777b647dee7846f9c1/common/proto/milo/manifest.pb.go
[rename] https://crrev.com/5040ef006fc0e97eb542a2777b647dee7846f9c1/common/proto/milo/manifest.proto
[delete] https://crrev.com/69cf6dc7d044074ad09eb72cadcd2921b2d421d3/milo/api/proto/manifest/README.md
[delete] https://crrev.com/69cf6dc7d044074ad09eb72cadcd2921b2d421d3/milo/api/proto/manifest/generate.go
[modify] https://crrev.com/5040ef006fc0e97eb542a2777b647dee7846f9c1/milo/srcman/diff.go
[modify] https://crrev.com/5040ef006fc0e97eb542a2777b647dee7846f9c1/milo/srcman/diff_test.go
[modify] https://crrev.com/5040ef006fc0e97eb542a2777b647dee7846f9c1/milo/srcman/get.go
[modify] https://crrev.com/5040ef006fc0e97eb542a2777b647dee7846f9c1/milo/srcman/get_test.go
[modify] https://crrev.com/5040ef006fc0e97eb542a2777b647dee7846f9c1/milo/srcman/model.go

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/d8f1c7fbc33d74e2e318463b10aae2480f3f01ed

commit d8f1c7fbc33d74e2e318463b10aae2480f3f01ed
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Oct 02 23:28:25 2017

[common|gitiles] Add protoized form of Git log data.

This was split off from:
  https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/678241

The idea here is that we'll need to embed git commit data in a consistent
form in protobufs (such as the upcoming manifest diff protobuf). Having a
singular definition for what 'git log' looks like in proto format, and having
the common gitiles library handle the manipulation of that format will help
write code that consistently handles git log data in LUCI.

R=dnj@chromium.org, nodir@chromium.org, tandrii@chromium.org, vadimsh@chromium.org

Bug:  758007 
Change-Id: I8b707d4b1e26f91c2b2c15ecc627e77aa5358348
Reviewed-on: https://chromium-review.googlesource.com/688297
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[add] https://crrev.com/d8f1c7fbc33d74e2e318463b10aae2480f3f01ed/common/api/gitiles/proto.go
[add] https://crrev.com/d8f1c7fbc33d74e2e318463b10aae2480f3f01ed/common/api/gitiles/proto_test.go
[add] https://crrev.com/d8f1c7fbc33d74e2e318463b10aae2480f3f01ed/common/proto/git/commit.pb.go
[add] https://crrev.com/d8f1c7fbc33d74e2e318463b10aae2480f3f01ed/common/proto/git/commit.proto
[add] https://crrev.com/d8f1c7fbc33d74e2e318463b10aae2480f3f01ed/common/proto/git/generate.go

Comment 11 by efoo@chromium.org, Oct 3 2017

Labels: LUCI-M3-S9
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/e8149bfc4467321ddfbd8fe9043281ca6671330d

commit e8149bfc4467321ddfbd8fe9043281ca6671330d
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Oct 05 00:57:41 2017

[milo] Refactor source manifest proto and diff support.

Since some services (like findit) are going to need to consume the
diff information in whole or in part, it makes sense to
make the diff structure externally supplied as a proto too.

The initial diff implementation was also too simplistic to be useful to
callers, so I've embellished it somewhat, and moved it to live along-side
the protos themselves, so that Go programs can locally compute the
diff without importing any code from Milo, or being forced to make an
RPC.

R=hinoka@chromium.org, nodir@chromium.org, tandrii@chromium.org

Bug:  758007 
Change-Id: Ic2cf3f9af70b4d8ef1dd51e8ba40c0d184877c07
Reviewed-on: https://chromium-review.googlesource.com/678241
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/e8149bfc4467321ddfbd8fe9043281ca6671330d/common/proto/milo/annotations.pb.go
[modify] https://crrev.com/e8149bfc4467321ddfbd8fe9043281ca6671330d/common/proto/milo/annotations.proto
[add] https://crrev.com/e8149bfc4467321ddfbd8fe9043281ca6671330d/common/proto/milo/diff.go
[add] https://crrev.com/e8149bfc4467321ddfbd8fe9043281ca6671330d/common/proto/milo/diff_test.go
[modify] https://crrev.com/e8149bfc4467321ddfbd8fe9043281ca6671330d/common/proto/milo/manifest.pb.go
[modify] https://crrev.com/e8149bfc4467321ddfbd8fe9043281ca6671330d/common/proto/milo/manifest.proto
[add] https://crrev.com/e8149bfc4467321ddfbd8fe9043281ca6671330d/common/proto/milo/manifest_diff.pb.go
[add] https://crrev.com/e8149bfc4467321ddfbd8fe9043281ca6671330d/common/proto/milo/manifest_diff.proto
[modify] https://crrev.com/e8149bfc4467321ddfbd8fe9043281ca6671330d/logdog/client/annotee/annotation/annotation.go
[delete] https://crrev.com/27e71ec0c506c4c213ea853e12a4af503e2d8988/milo/srcman/diff.go
[delete] https://crrev.com/27e71ec0c506c4c213ea853e12a4af503e2d8988/milo/srcman/diff_test.go
[modify] https://crrev.com/e8149bfc4467321ddfbd8fe9043281ca6671330d/milo/srcman/get.go
[modify] https://crrev.com/e8149bfc4467321ddfbd8fe9043281ca6671330d/milo/srcman/get_test.go

Project Member

Comment 14 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/3e09a61a1ad7c8f21e2ce2afd7240855c318d7ce

commit 3e09a61a1ad7c8f21e2ce2afd7240855c318d7ce
Author: Ryan Tseng <hinoka@google.com>
Date: Fri Oct 06 00:03:01 2017

Update source_manifest to e8149bf in luci-go

This updates the source_manifest proto to match the version in luci-go
since https://chromium-review.googlesource.com/678241

Bug:  758007 
Change-Id: Ib4c537398c848cd75b8729163bd5a7545aabcbf4
Reviewed-on: https://chromium-review.googlesource.com/701579
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/3e09a61a1ad7c8f21e2ce2afd7240855c318d7ce/recipe_engine/source_manifest.proto
[modify] https://crrev.com/3e09a61a1ad7c8f21e2ce2afd7240855c318d7ce/recipe_engine/source_manifest_pb2.py

Blockedon: 772529

Comment 16 by efoo@chromium.org, Oct 7 2017

Labels: LUCI-Blocker-M4
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/d553fce8291d13f0b77410de249e8b31783e8ad0

commit d553fce8291d13f0b77410de249e8b31783e8ad0
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 10 00:15:54 2017

[milo] Add backend code for blamelist calculation and caching.

R=nodir@chromium.org, tandrii@chromium.org

Bug:  758007 
Change-Id: I231ad98e94e5c4a2183e6369b36803eb7df8f101
Reviewed-on: https://chromium-review.googlesource.com/689143
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[add] https://crrev.com/d553fce8291d13f0b77410de249e8b31783e8ad0/milo/srcman/blamelist.go
[modify] https://crrev.com/d553fce8291d13f0b77410de249e8b31783e8ad0/milo/srcman/get.go

Comment 18 by efoo@chromium.org, Oct 17 2017

Labels: LUCI-M3-S10
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/eef799ece9d738cb04c30d3a92d5616bd4e4d7e5

commit eef799ece9d738cb04c30d3a92d5616bd4e4d7e5
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 18 01:15:21 2017

[milo] summarize the buildbot builds in buildbot/buildstore.

This is the first step towards making the milo middleware pipeline generic
(by having buildsource.ID's interface return model.BuildSummary instead
of resp.MiloBuild).

R=hinoka@chromium.org, nodir@chromium.org

Bug:  758007 
Change-Id: Idbddb67cf2691a7bd0935ee4d5cee54cdcc91088
Reviewed-on: https://chromium-review.googlesource.com/720103
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/eef799ece9d738cb04c30d3a92d5616bd4e4d7e5/milo/api/buildbot/time.go
[modify] https://crrev.com/eef799ece9d738cb04c30d3a92d5616bd4e4d7e5/milo/api/resp/build.go
[modify] https://crrev.com/eef799ece9d738cb04c30d3a92d5616bd4e4d7e5/milo/buildsource/buildbot/build_test.go
[modify] https://crrev.com/eef799ece9d738cb04c30d3a92d5616bd4e4d7e5/milo/buildsource/buildbot/builder_test.go
[modify] https://crrev.com/eef799ece9d738cb04c30d3a92d5616bd4e4d7e5/milo/buildsource/buildbot/buildstore/build.go
[modify] https://crrev.com/eef799ece9d738cb04c30d3a92d5616bd4e4d7e5/milo/buildsource/buildbot/pubsub.go
[modify] https://crrev.com/eef799ece9d738cb04c30d3a92d5616bd4e4d7e5/milo/buildsource/buildbot/pubsub_test.go
[modify] https://crrev.com/eef799ece9d738cb04c30d3a92d5616bd4e4d7e5/milo/common/config.go
[modify] https://crrev.com/eef799ece9d738cb04c30d3a92d5616bd4e4d7e5/milo/common/model/build_summary.go

Project Member

Comment 20 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/679e324d6e5a7c75db9356ddf134577b8d1b504e

commit 679e324d6e5a7c75db9356ddf134577b8d1b504e
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Oct 19 03:13:18 2017

[milo] Remove unused fields from BuildSummary.

R=hinoka@chromium.org, nodir@chromium.org

Bug:  758007 
Change-Id: I3354da57f5c81c04a0533dc5c3afe4c88a26709b
Reviewed-on: https://chromium-review.googlesource.com/727475
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/679e324d6e5a7c75db9356ddf134577b8d1b504e/milo/common/model/build_summary.go

Project Member

Comment 21 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/745a35515677635ef5328b717dfcba80dfaf4184

commit 745a35515677635ef5328b717dfcba80dfaf4184
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Oct 19 08:52:58 2017

[milo] Track Project in BuildSummary.

Also refactor buildset manifest key attachment to use common funcion...
missed this in a previous CL.

R=hinoka@chromium.org, nodir@chromium.org

Bug:  758007 
Change-Id: I845d43ae1df56a870206acbc6ec808ba9f035e83
Reviewed-on: https://chromium-review.googlesource.com/727522
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/745a35515677635ef5328b717dfcba80dfaf4184/milo/buildsource/buildbucket/pubsub.go
[modify] https://crrev.com/745a35515677635ef5328b717dfcba80dfaf4184/milo/common/model/build_summary.go

Project Member

Comment 22 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/78f4f98cd55742c20cb2200b2de767ab03251f14

commit 78f4f98cd55742c20cb2200b2de767ab03251f14
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 20 00:47:41 2017

remove swarming_run_id

swarming_run_id is not used for any current builds, and all builds which
use logdog specify the log_location swarming tag.

R=hinoka@chromium.org, nodir@chromium.org, robertocn@chromium.org

Bug:  758007 ,  718191 
Change-Id: I87772113efd46cfc256449ba3aa7a78da4fcf00e
Reviewed-on: https://chromium-review.googlesource.com/727546
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/78f4f98cd55742c20cb2200b2de767ab03251f14/appengine/findit/infra_api_clients/logdog_util.py
[modify] https://crrev.com/78f4f98cd55742c20cb2200b2de767ab03251f14/go/src/infra/tools/kitchen/cook_mode.go
[modify] https://crrev.com/78f4f98cd55742c20cb2200b2de767ab03251f14/go/src/infra/tools/kitchen/cook_test.go

Project Member

Comment 23 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/c36425282c9d1e704cda2ef7bb24861ee6277936

commit c36425282c9d1e704cda2ef7bb24861ee6277936
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 20 01:00:00 2017

[milo] Cleanup buildbucket pubsub handling.

This also makes the buildbucket BuildSummary's use the new
project-oriented buildbucket build page for the SelfLink.

R=hinoka@chromium.org, nodir@chromium.org

Bug:  758007 
Change-Id: I5ef61e2ee1dec51202b666aa783602590d5808c1
Reviewed-on: https://chromium-review.googlesource.com/727532
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/c36425282c9d1e704cda2ef7bb24861ee6277936/milo/buildsource/buildbucket/pubsub.go
[modify] https://crrev.com/c36425282c9d1e704cda2ef7bb24861ee6277936/milo/frontend/routes.go

Project Member

Comment 24 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/74366d3656b1a44c3a2daad3fe6bb8356fadc2d2

commit 74366d3656b1a44c3a2daad3fe6bb8356fadc2d2
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 20 21:32:30 2017

[milo] remove swarming_run_id, implicit log_location.

swarming_run_id is not used for any current builds, and all builds which
use logdog specify the log_location swarming tag.

R=hinoka@chromium.org, nodir@chromium.org

Bug:  758007 ,  718191 
Change-Id: Id43924603ebe3465bf0baccfd39ef91adfea0fce
Reviewed-on: https://chromium-review.googlesource.com/727545
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/74366d3656b1a44c3a2daad3fe6bb8356fadc2d2/milo/buildsource/swarming/build.go
[modify] https://crrev.com/74366d3656b1a44c3a2daad3fe6bb8356fadc2d2/milo/buildsource/swarming/buildLog.go
[modify] https://crrev.com/74366d3656b1a44c3a2daad3fe6bb8356fadc2d2/milo/buildsource/swarming/buildinfo.go
[modify] https://crrev.com/74366d3656b1a44c3a2daad3fe6bb8356fadc2d2/milo/buildsource/swarming/buildinfo_test.go
[modify] https://crrev.com/74366d3656b1a44c3a2daad3fe6bb8356fadc2d2/milo/buildsource/swarming/testdata/build-finished-logdog-expired-stream.swarm
[modify] https://crrev.com/74366d3656b1a44c3a2daad3fe6bb8356fadc2d2/milo/buildsource/swarming/testdata/build-running-logdog-no-annotation-stream.swarm
[modify] https://crrev.com/74366d3656b1a44c3a2daad3fe6bb8356fadc2d2/milo/buildsource/swarming/testdata/build-running-logdog.swarm
[delete] https://crrev.com/693482d5251b2ef49a3f52177448ac336b15bbb0/swarming/tasktemplate/template.go
[delete] https://crrev.com/693482d5251b2ef49a3f52177448ac336b15bbb0/swarming/tasktemplate/template_test.go

Project Member

Comment 25 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/bf320943c9bbc850f8d46bd300ca85dd7fa1313a

commit bf320943c9bbc850f8d46bd300ca85dd7fa1313a
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Nov 02 19:00:36 2017

[milo] Add Context URIs to BuildSummary.

This will be useful for displaying context links when rendering HTML from
a BuildSummary, and will also be useful for doing e.g. correlation of bots
across builds, etc.

R=hinoka@chromium.org, jchinlee@chromium.org, nodir@chromium.org

Bug:  758007 
Change-Id: I5f35b6f2cf20036ccce5134dc07e129e5890ec02
Reviewed-on: https://chromium-review.googlesource.com/750271
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/bf320943c9bbc850f8d46bd300ca85dd7fa1313a/milo/buildsource/buildbot/buildstore/build.go
[modify] https://crrev.com/bf320943c9bbc850f8d46bd300ca85dd7fa1313a/milo/buildsource/buildbucket/pubsub.go
[modify] https://crrev.com/bf320943c9bbc850f8d46bd300ca85dd7fa1313a/milo/common/model/build_summary.go

Project Member

Comment 26 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/7dd5eec49417b02c608d023a578af0b78cc06028

commit 7dd5eec49417b02c608d023a578af0b78cc06028
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Nov 02 20:18:47 2017

[milo] Fix typo in buildbucket ContextURI calculation.

TBR=hinoka@chromium.org, jchinlee@chromium.org, nodir@chromium.org

Bug:  758007 
Change-Id: Id466a3be12365a15f773fd013584878b1dca45b9
Reviewed-on: https://chromium-review.googlesource.com/752036
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/7dd5eec49417b02c608d023a578af0b78cc06028/milo/buildsource/buildbucket/pubsub.go

Project Member

Comment 27 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/0fb30ad480912db2c7fdaaab3185cc2e35a9c265

commit 0fb30ad480912db2c7fdaaab3185cc2e35a9c265
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Nov 02 22:28:37 2017

[milo] Use BuildSummary for rendering buildbucket builds.

This avoids a redundant RPC out to buildbucket.

R=hinoka@chromium.org, jchinlee@chromium.org, nodir@chromium.org

Bug:  758007 
Change-Id: Ifa88279bf97403ab23af372c2e29b362dc8daba2
Reviewed-on: https://chromium-review.googlesource.com/750336
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/0fb30ad480912db2c7fdaaab3185cc2e35a9c265/milo/buildsource/buildbucket/build.go
[modify] https://crrev.com/0fb30ad480912db2c7fdaaab3185cc2e35a9c265/milo/rpc/buildinfo.go

Project Member

Comment 28 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/6947887f6f604d453ca96f0e1768fd5fc28d05c1

commit 6947887f6f604d453ca96f0e1768fd5fc28d05c1
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Nov 02 23:10:27 2017

Revert "[milo] Use BuildSummary for rendering buildbucket builds."

This reverts commit 0fb30ad480912db2c7fdaaab3185cc2e35a9c265
temporarially.

TBR=hinoka@chromium.org, jchinlee@chromium.org, nodir@chromium.org

Bug:  758007 
Change-Id: I37caa1acdde0e8b32aaa911b186eb63b6d258828
Reviewed-on: https://chromium-review.googlesource.com/752009
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/6947887f6f604d453ca96f0e1768fd5fc28d05c1/milo/buildsource/buildbucket/build.go
[modify] https://crrev.com/6947887f6f604d453ca96f0e1768fd5fc28d05c1/milo/rpc/buildinfo.go

Project Member

Comment 29 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/1f61c58b6b8f31060bbba5f0fc5324c0ea8dffe0

commit 1f61c58b6b8f31060bbba5f0fc5324c0ea8dffe0
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Nov 03 23:04:11 2017

Reland: [milo] Use BuildSummary for rendering buildbucket builds.

This avoids the extra RPC to buildbucket when the BuildSummary
contains a swarming://host/task/task_id ContextURI. However, if it fails
to find this on BuildSummary, it will fall back to the extra RPC before
failing.

This includes a deprecation note for the fallback codepath to be removed
after ~1 month.

R=hinoka@chromium.org, jchinlee@chromium.org, nodir@chromium.org

Bug:  758007 
Change-Id: Id09fe5951388d8817174982bb60d9e8ef8b0c3b7
Reviewed-on: https://chromium-review.googlesource.com/753009
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/1f61c58b6b8f31060bbba5f0fc5324c0ea8dffe0/milo/buildsource/buildbucket/build.go
[modify] https://crrev.com/1f61c58b6b8f31060bbba5f0fc5324c0ea8dffe0/milo/rpc/buildinfo.go

Project Member

Comment 30 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/0fddde7ed00c0ea77c97574a6aa9da283ce51316

commit 0fddde7ed00c0ea77c97574a6aa9da283ce51316
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Nov 06 19:59:26 2017

[milo] Implement simplistic blamelist support for buildbucket builds.

This doesn't use source manifests or get multi-repo blame, but it
gets us pairity with buildbot, which should be enough to get us
unblocked.

R=hinoka@chromium.org, jchinlee@chromium.org, nodir@chromium.org

Bug:  758007 
Change-Id: I18ed1c1d21557d7c8e8feeb3f555dd98b76575c7
Reviewed-on: https://chromium-review.googlesource.com/750109
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/0fddde7ed00c0ea77c97574a6aa9da283ce51316/milo/buildsource/buildbucket/build.go
[modify] https://crrev.com/0fddde7ed00c0ea77c97574a6aa9da283ce51316/milo/common/model/build_summary.go

Status: Fixed (was: Assigned)
The simplistic version of this is deployed on luci-milo.appspot.com (version 2288-96f9822). See crbug.com/780303 for non-simplistic implementation.

Comment 32 by efoo@chromium.org, Nov 8 2017

Labels: -REQBY-LUCI-M5-Migration -LUCI-M3-ClosedBeta REQBY-LUCI-M4a-MacWinPOC LUCI-M3-Beta

Comment 33 by efoo@chromium.org, Jan 31 2018

Labels: LUCI-Beta

Comment 34 by efoo@chromium.org, Jan 31 2018

Labels: -LUCI-Blocker-M4 -LUCI-M3-Beta luci-blocker-migration

Comment 35 by efoo@chromium.org, Feb 13 2018

Labels: -LUCI-blocker-migration LUCI-Chromium-CQSets LUCI-Blocker-Chromium-CQSets
Project Member

Comment 36 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/ae83dec4f0391f51c9bc253256086da71b841f2a

commit ae83dec4f0391f51c9bc253256086da71b841f2a
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Fri May 18 02:27:36 2018

[milo]: delete unused srcman package.

We will resurrect this module when we are ready to integrate it.
In the meantime, there is no reason to pay maintenance cost.

R=hinoka@chromium.org, nodir@chromium.org

Bug: 796317,  758007 
Change-Id: I44986046c39ed9aedc097df062e6edeabf968dda
Reviewed-on: https://chromium-review.googlesource.com/1065235
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[delete] https://crrev.com/846b808121fc9dfa4c17b3eee6a9b41442ab3c39/milo/srcman/blamelist.go
[delete] https://crrev.com/846b808121fc9dfa4c17b3eee6a9b41442ab3c39/milo/srcman/doc.go
[delete] https://crrev.com/846b808121fc9dfa4c17b3eee6a9b41442ab3c39/milo/srcman/get.go
[delete] https://crrev.com/846b808121fc9dfa4c17b3eee6a9b41442ab3c39/milo/srcman/get_test.go
[delete] https://crrev.com/846b808121fc9dfa4c17b3eee6a9b41442ab3c39/milo/srcman/model.go

Sign in to add a comment