New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758004 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 754527
issue 757517



Sign in to add a comment

[Findit] separate logic of submitting reverts to a service module

Project Member Reported by chanli@chromium.org, Aug 22 2017

Issue description

Move logic of submitting reverts to revert.py
 

Comment 1 by chanli@chromium.org, Aug 22 2017

Blocking: 757517
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/62d79af59cbfef16d6b2e0ef352f0c4da98e29be

commit 62d79af59cbfef16d6b2e0ef352f0c4da98e29be
Author: Chan <chanli@chromium.org>
Date: Fri Aug 25 21:50:19 2017

[Findit] separate logic of submitting a revert to revert.py

Bug:  758004 
Change-Id: I8e0a79e3a3f109533cff57dbc23d3daa08929e50
Reviewed-on: https://chromium-review.googlesource.com/629520
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/62d79af59cbfef16d6b2e0ef352f0c4da98e29be/appengine/findit/waterfall/create_revert_cl_pipeline.py
[modify] https://crrev.com/62d79af59cbfef16d6b2e0ef352f0c4da98e29be/appengine/findit/waterfall/test/send_notification_to_irc_pipeline_test.py
[modify] https://crrev.com/62d79af59cbfef16d6b2e0ef352f0c4da98e29be/appengine/findit/waterfall/send_notification_to_irc_pipeline.py
[modify] https://crrev.com/62d79af59cbfef16d6b2e0ef352f0c4da98e29be/appengine/findit/waterfall/test/submit_revert_cl_pipeline_test.py
[rename] https://crrev.com/62d79af59cbfef16d6b2e0ef352f0c4da98e29be/appengine/findit/services/revert.py
[modify] https://crrev.com/62d79af59cbfef16d6b2e0ef352f0c4da98e29be/appengine/findit/waterfall/test/revert_and_notify_culprit_pipeline_test.py
[modify] https://crrev.com/62d79af59cbfef16d6b2e0ef352f0c4da98e29be/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py
[modify] https://crrev.com/62d79af59cbfef16d6b2e0ef352f0c4da98e29be/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py
[delete] https://crrev.com/311fa3906acc03dbbec5c2a03b8186882d727616/appengine/findit/waterfall/test/revert_test.py
[modify] https://crrev.com/62d79af59cbfef16d6b2e0ef352f0c4da98e29be/appengine/findit/waterfall/test/create_revert_cl_pipeline_test.py
[add] https://crrev.com/62d79af59cbfef16d6b2e0ef352f0c4da98e29be/appengine/findit/services/test/revert_test.py
[modify] https://crrev.com/62d79af59cbfef16d6b2e0ef352f0c4da98e29be/appengine/findit/waterfall/submit_revert_cl_pipeline.py

Comment 3 by chanli@chromium.org, Aug 28 2017

Status: Fixed (was: Assigned)

Sign in to add a comment