New issue
Advanced search Search tips

Issue 757999 link

Starred by 1 user
Status: Started
Owner:
xingliu@chromium.org
Cc:
shaktisahu@chromium.org
xingliu@chromium.org
dtrainor@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug


Participants' hotlists:
Downloads-Framework-Service


Sign in to add a comment

Download service: Implement browser tests.

Project Member Reported by xingliu@chromium.org, Aug 22 2017 
Currently we only have unit tests for download service.

It would be good if we have end-to-end browser tests in native side.

The browser tests needs to spin up parts of real content/download logic. We can refer to chrome/browser/download/download_browsertest.cc or content/browser/download/download_browsertest.cc.

Comment 1 by xingliu@chromium.org, Sep 18 2017

Owner: xingliu@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3f6766bf5ca151176a1c1078646469c32fa0337

commit d3f6766bf5ca151176a1c1078646469c32fa0337
Author: Xing Liu <xingliu@chromium.org>
Date: Wed Sep 20 21:32:48 2017

Download Service: Move files to public test_support target.

components/download/internal/test:test_support contains internal test
support mocks and test classes only depend on
components/download/public.

This CL moves public only test classes to
components/download/public/test:test_support, so external tests can
depend on this instead of the internal one.

This is needed for download service browser test which lives in
//chrome/browser.

TBR=jianli@chromium.org

Bug: 757999
Change-Id: I5f591bc292b3bcbc2d71122744689d1070fdb2c8
Reviewed-on: https://chromium-review.googlesource.com/674129
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503255}
[modify] https://crrev.com/d3f6766bf5ca151176a1c1078646469c32fa0337/components/download/internal/BUILD.gn
[modify] https://crrev.com/d3f6766bf5ca151176a1c1078646469c32fa0337/components/download/internal/client_set_unittest.cc
[modify] https://crrev.com/d3f6766bf5ca151176a1c1078646469c32fa0337/components/download/internal/controller_impl_unittest.cc
[modify] https://crrev.com/d3f6766bf5ca151176a1c1078646469c32fa0337/components/download/internal/test/BUILD.gn
[add] https://crrev.com/d3f6766bf5ca151176a1c1078646469c32fa0337/components/download/public/test/BUILD.gn
[rename] https://crrev.com/d3f6766bf5ca151176a1c1078646469c32fa0337/components/download/public/test/empty_client.cc
[rename] https://crrev.com/d3f6766bf5ca151176a1c1078646469c32fa0337/components/download/public/test/empty_client.h
[rename] https://crrev.com/d3f6766bf5ca151176a1c1078646469c32fa0337/components/download/public/test/mock_client.cc
[rename] https://crrev.com/d3f6766bf5ca151176a1c1078646469c32fa0337/components/download/public/test/mock_client.h
[rename] https://crrev.com/d3f6766bf5ca151176a1c1078646469c32fa0337/components/download/public/test/mock_download_service.cc
[rename] https://crrev.com/d3f6766bf5ca151176a1c1078646469c32fa0337/components/download/public/test/mock_download_service.h
[rename] https://crrev.com/d3f6766bf5ca151176a1c1078646469c32fa0337/components/download/public/test/test_download_service.cc
[rename] https://crrev.com/d3f6766bf5ca151176a1c1078646469c32fa0337/components/download/public/test/test_download_service.h
[modify] https://crrev.com/d3f6766bf5ca151176a1c1078646469c32fa0337/components/offline_pages/core/prefetch/BUILD.gn
[modify] https://crrev.com/d3f6766bf5ca151176a1c1078646469c32fa0337/components/offline_pages/core/prefetch/prefetch_download_flow_unittest.cc
[modify] https://crrev.com/d3f6766bf5ca151176a1c1078646469c32fa0337/components/offline_pages/core/prefetch/prefetch_downloader_impl_unittest.cc
[modify] https://crrev.com/d3f6766bf5ca151176a1c1078646469c32fa0337/components/offline_pages/core/prefetch/test_download_client.h
►

Sign in to add a comment