New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757982 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Remove web view matchers that wait for web view containing an image

Project Member Reported by baxley@chromium.org, Aug 22 2017

Issue description

This includes ways to wait for a blocked or loaded image.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/1c3ce611f36cf651afc95dd87fa612f01bc7a343

commit 1c3ce611f36cf651afc95dd87fa612f01bc7a343
Author: Mike Baxley <baxley@google.com>
Date: Thu Aug 31 22:04:48 2017

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9570bc5a9444060b7bf4cec1899cb079b76bbc63

commit 9570bc5a9444060b7bf4cec1899cb079b76bbc63
Author: Mike Baxley <baxley@chromium.org>
Date: Mon Sep 11 23:20:30 2017

Delete matchers that wait for images.

Matchers should not wait, and have been replaced by methods in
ChromeEarlGrey.

Bug:  757982 
Change-Id: I68b1b5d9eb6f50cf80af3ef514c1ea43d080e926
Reviewed-on: https://chromium-review.googlesource.com/647805
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501088}
[modify] https://crrev.com/9570bc5a9444060b7bf4cec1899cb079b76bbc63/ios/chrome/test/earl_grey/chrome_matchers.h
[modify] https://crrev.com/9570bc5a9444060b7bf4cec1899cb079b76bbc63/ios/chrome/test/earl_grey/chrome_matchers.mm
[modify] https://crrev.com/9570bc5a9444060b7bf4cec1899cb079b76bbc63/ios/web/public/test/earl_grey/web_view_matchers.h
[modify] https://crrev.com/9570bc5a9444060b7bf4cec1899cb079b76bbc63/ios/web/public/test/earl_grey/web_view_matchers.mm

Comment 4 by baxley@chromium.org, Sep 12 2017

Status: Fixed (was: Started)

Sign in to add a comment