New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757974 link

Starred by 6 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Feature


Sign in to add a comment

Make Chrome able to run on top of ANGLE on OSX

Project Member Reported by cwallez@chromium.org, Aug 22 2017

Issue description

Tracking bug for efforts related to making Chrome use ANGLE and the passthrough command buffer on OSX.

 
Blockedon: -angleproject:1313 angleproject:1650
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba106ccc86fae17e528a076916c78c0ef433caab

commit ba106ccc86fae17e528a076916c78c0ef433caab
Author: Corentin Wallez <cwallez@chromium.org>
Date: Wed Oct 11 22:21:56 2017

Passthrough Cmd decoder: Handle TEXTURE_RECTANGLE

This is needed to make the passthrough command decoder able to be used
on Mac as IOSurfaces will be bound to rectangle textures.

BUG=757974

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id02f2ba6171841a1daebb5f987354f227b4c2f6a
Reviewed-on: https://chromium-review.googlesource.com/714117
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508145}
[modify] https://crrev.com/ba106ccc86fae17e528a076916c78c0ef433caab/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e934f77651be6f73736c54a69830dacc4259e70a

commit e934f77651be6f73736c54a69830dacc4259e70a
Author: Corentin Wallez <cwallez@chromium.org>
Date: Fri Oct 13 22:03:44 2017

GLImageIOSurface: Force creation through static method

This will make it easier to provide multiple implementations of
GLImageIOSurface when we'll make Chrome use ANGLE on Mac.

BUG=757974
TBR=hubbe@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I549606f903ad7a1b80186a04b454191ab5dad431
Reviewed-on: https://chromium-review.googlesource.com/713963
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508833}
[modify] https://crrev.com/e934f77651be6f73736c54a69830dacc4259e70a/gpu/command_buffer/tests/gl_manager.cc
[modify] https://crrev.com/e934f77651be6f73736c54a69830dacc4259e70a/gpu/ipc/service/gpu_memory_buffer_factory_io_surface.cc
[modify] https://crrev.com/e934f77651be6f73736c54a69830dacc4259e70a/media/gpu/vt_video_decode_accelerator_mac.cc
[modify] https://crrev.com/e934f77651be6f73736c54a69830dacc4259e70a/ui/accelerated_widget_mac/ca_layer_tree_unittest_mac.mm
[modify] https://crrev.com/e934f77651be6f73736c54a69830dacc4259e70a/ui/gl/gl_image_io_surface.h
[modify] https://crrev.com/e934f77651be6f73736c54a69830dacc4259e70a/ui/gl/gl_image_io_surface.mm
[modify] https://crrev.com/e934f77651be6f73736c54a69830dacc4259e70a/ui/gl/gl_image_io_surface_unittest.cc

Cc: julien.isorce@chromium.org
Cc: ccameron@chromium.org cwallez@chromium.org erikc...@chromium.org
 Issue 671290  has been merged into this issue.
Blockedon: 795353
Blockedon: angleproject:2287
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce3c8f596735b5e437eceaa69d65e41c56c6d9ee

commit ce3c8f596735b5e437eceaa69d65e41c56c6d9ee
Author: Corentin Wallez <cwallez@chromium.org>
Date: Wed Feb 07 07:48:20 2018

Support --use-gl=angle on macOS

This allows running Chrome on top of ANGLE's EGL and OpenGL ES2
implementation on macOS via the EGL_ANGLE_iosurface_client_buffer that
allows creating EGL pbuffers from iosurfaces and binding them to
textures.

A use_egl_on_mac flag is introduced that enables support for EGL on
macOS builds, and move the ANGLE libraries in the correct place in the
Chromium.app bundle. This flag is disabled by default.

GLImageIOSurfaceEGL is introduced that subclasses GLImageIOSurface and
has a new code path to bind IOSurfaces to textures using the ANGLE
extension.

The changes don't add support for Swiftshader as it doesn't implement
the EGL_ANGLE_iosurface_client_buffer extension yet.

BUG=chromium:757974

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2a819d1780415ac144d94e1fdad6030d64d6f8c5
Reviewed-on: https://chromium-review.googlesource.com/558810
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534948}
[modify] https://crrev.com/ce3c8f596735b5e437eceaa69d65e41c56c6d9ee/chrome/BUILD.gn
[modify] https://crrev.com/ce3c8f596735b5e437eceaa69d65e41c56c6d9ee/gpu/ipc/service/image_transport_surface_mac.mm
[modify] https://crrev.com/ce3c8f596735b5e437eceaa69d65e41c56c6d9ee/ui/gl/BUILD.gn
[modify] https://crrev.com/ce3c8f596735b5e437eceaa69d65e41c56c6d9ee/ui/gl/features.gni
[modify] https://crrev.com/ce3c8f596735b5e437eceaa69d65e41c56c6d9ee/ui/gl/gl_image_io_surface.h
[modify] https://crrev.com/ce3c8f596735b5e437eceaa69d65e41c56c6d9ee/ui/gl/gl_image_io_surface.mm
[add] https://crrev.com/ce3c8f596735b5e437eceaa69d65e41c56c6d9ee/ui/gl/gl_image_io_surface_egl.h
[add] https://crrev.com/ce3c8f596735b5e437eceaa69d65e41c56c6d9ee/ui/gl/gl_image_io_surface_egl.mm
[modify] https://crrev.com/ce3c8f596735b5e437eceaa69d65e41c56c6d9ee/ui/gl/gl_surface_egl.cc
[modify] https://crrev.com/ce3c8f596735b5e437eceaa69d65e41c56c6d9ee/ui/gl/init/BUILD.gn
[modify] https://crrev.com/ce3c8f596735b5e437eceaa69d65e41c56c6d9ee/ui/gl/init/gl_factory_mac.cc
[modify] https://crrev.com/ce3c8f596735b5e437eceaa69d65e41c56c6d9ee/ui/gl/init/gl_initializer_mac.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c43c96034c087c1a6e49a27f97a8b31bd22845e9

commit c43c96034c087c1a6e49a27f97a8b31bd22845e9
Author: Alexis Hetu <sugoi@google.com>
Date: Mon Mar 05 16:26:55 2018

texture2DRect support in gles2_cmd_copy_texture_chromium

Some support for GL_TEXTURE_RECTANGLE_ARB was implemented,
but many cases, including using proper GLSL sampling functions,
were missing. This fixes some WebGL conformance tests on MacOS.

Bug: chromium:757974
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I645dc545643c4cd0f392d8000550c098c7b109f6
Reviewed-on: https://chromium-review.googlesource.com/944185
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540836}
[modify] https://crrev.com/c43c96034c087c1a6e49a27f97a8b31bd22845e9/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/241806077286b6d59dc9a42ca3a204916c4db308

commit 241806077286b6d59dc9a42ca3a204916c4db308
Author: Corentin Wallez <cwallez@chromium.org>
Date: Wed Mar 07 15:28:30 2018

Allow rectangle textures to be sample with texture() in ESSL3

This makes them consistent with the other texture types. Also adds a
test for using texture(sampler2DRect, ...).

BUG=chromium:757974
BUG= angleproject:1650 

Change-Id: Ie966da928ae0c83850da1e530e72c0d501909394
Reviewed-on: https://chromium-review.googlesource.com/946675
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>

[modify] https://crrev.com/241806077286b6d59dc9a42ca3a204916c4db308/src/compiler/translator/SymbolTable_autogen.cpp
[modify] https://crrev.com/241806077286b6d59dc9a42ca3a204916c4db308/src/compiler/translator/builtin_function_declarations.txt
[modify] https://crrev.com/241806077286b6d59dc9a42ca3a204916c4db308/src/tests/gl_tests/TextureRectangleTest.cpp
[modify] https://crrev.com/241806077286b6d59dc9a42ca3a204916c4db308/src/compiler/translator/OutputGLSL.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/ba8726b8a33603b1352019123edb82ed199b26d2

commit ba8726b8a33603b1352019123edb82ed199b26d2
Author: angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Mar 07 19:47:40 2018

Roll skia/third_party/externals/angle2/ 7618eaf9a..2202680c6 (4 commits)

https://chromium.googlesource.com/angle/angle.git/+log/7618eaf9ad45..2202680c6a5d

$ git log 7618eaf9a..2202680c6 --date=short --no-merges --format='%ad %ae %s'
2018-03-05 brandon1.jones Add NPOT validation to copyTextureCHROMIUM
2018-03-02 jmadill Vulkan: Always use LOAD for RenderPass attachments.
2018-03-06 tobine Roll (1/2) LVL version forward and disable VANGLE
2018-03-02 cwallez Allow rectangle textures to be sample with texture() in ESSL3

Created with:
  roll-dep skia/third_party/externals/angle2
BUG=757974


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=fmalita@google.com

Change-Id: I94740d7eb994fd636d215d15b3528987935e4089
Reviewed-on: https://skia-review.googlesource.com/112760
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>

[modify] https://crrev.com/ba8726b8a33603b1352019123edb82ed199b26d2/DEPS

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2faeeb15178698f9bd50db3c334e1db4df03fc10

commit 2faeeb15178698f9bd50db3c334e1db4df03fc10
Author: angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Mar 07 20:42:32 2018

Roll src/third_party/angle/ 7618eaf9a..e4c5a23b1 (3 commits)

https://chromium.googlesource.com/angle/angle.git/+log/7618eaf9ad45..e4c5a23b1148

$ git log 7618eaf9a..e4c5a23b1 --date=short --no-merges --format='%ad %ae %s'
2018-03-02 jmadill Vulkan: Always use LOAD for RenderPass attachments.
2018-03-06 tobine Roll (1/2) LVL version forward and disable VANGLE
2018-03-02 cwallez Allow rectangle textures to be sample with texture() in ESSL3

Created with:
  roll-dep src/third_party/angle
BUG=757974


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: Iec15cbc5752aebe0c3da0b7788b784db67df6e85
Reviewed-on: https://chromium-review.googlesource.com/952961
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#541563}
[modify] https://crrev.com/2faeeb15178698f9bd50db3c334e1db4df03fc10/DEPS

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b0885d046c0460005e3fc0cdb33adee41b1bfc8

commit 9b0885d046c0460005e3fc0cdb33adee41b1bfc8
Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Mar 07 22:45:35 2018

Roll src/third_party/skia/ 461ef7af8..88df8d2e5 (22 commits)

https://skia.googlesource.com/skia.git/+log/461ef7af88cc..88df8d2e5a87

$ git log 461ef7af8..88df8d2e5 --date=short --no-merges --format='%ad %ae %s'
2018-03-07 stephana Test SKQP on Firebase Testlab and Upload
2018-03-07 csmartdalton ccpr: Combine GS triangle hulls and edges into a single draw
2018-03-07 bsalomon Make Vulkan testing-only backend textures have optimal layout
2018-03-07 bsalomon Rename wrap backend tex/rt methods on GrProxyProvider
2018-03-07 robertphillips Have GrGlyphCache and GrAtlasManager compute the atlas limits independently
2018-03-07 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 7618eaf9a..2202680c6 (4 commits)
2018-03-07 csmartdalton ccpr: Fix very small edges
2018-03-07 reed Revert "Revert "add tiler for SkDraw""
2018-03-07 robertphillips Revise Text & Small Path Atlas so instantiation failure is handled at flush time
2018-03-07 reed chop down huge rects before hairlining
2018-03-07 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 8a7ec86c0..da8c41528 (1 commit)
2018-03-07 bsalomon Initial texture data is never flipped when uploaded.
2018-03-07 herb Revert "Remove attach and detach glyph cache."
2018-03-07 bsalomon Remove abandon param from GrGpu::deleteTestingOnlyBackendTexture.
2018-02-27 mtklein Reland "Reland "make SkJumper stages normal Skia code""
2018-03-07 mtklein Revert "Reland "make SkJumper stages normal Skia code""
2018-03-05 herb Remove attach and detach glyph cache.
2018-02-27 mtklein Reland "make SkJumper stages normal Skia code"
2018-03-07 bungeman Remove dm excludes from public.bzl.
2018-03-07 mtklein Revert "make SkJumper stages normal Skia code"
2018-02-27 mtklein make SkJumper stages normal Skia code
2018-03-07 bsalomon Prefer kMixedSamples MSFBOType to multisampled-render-to-texture variants

Created with:
  roll-dep src/third_party/skia
BUG=757974


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=fmalita@chromium.org

Change-Id: I69907ba55222be9cd5691d6e009cc45cb259bbd3
Reviewed-on: https://chromium-review.googlesource.com/953170
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#541619}
[modify] https://crrev.com/9b0885d046c0460005e3fc0cdb33adee41b1bfc8/DEPS

Project Member

Comment 14 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2f61690f7a59a4c6ac7cc4b99dd92b44e810f23

commit c2f61690f7a59a4c6ac7cc4b99dd92b44e810f23
Author: Corentin Wallez <cwallez@chromium.org>
Date: Wed Mar 14 18:31:47 2018

Reuse use_egl instead of having use_egl_on_mac

Also addresses rsesek's comment on --use-gl=angle on Mac:
 - Put ANGLE libraries in Libraries/ instead of dumping them in
Contents.
 - Use a better name for the temporary copies of the libraries before
bundle_data.

Also fix a compile error for a newly introduced gfx::BufferFormat.

BUG=chromium:757974

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0f8ca4ed88ba45e97afce545982065699203a232
Reviewed-on: https://chromium-review.googlesource.com/959045
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543136}
[modify] https://crrev.com/c2f61690f7a59a4c6ac7cc4b99dd92b44e810f23/chrome/BUILD.gn
[modify] https://crrev.com/c2f61690f7a59a4c6ac7cc4b99dd92b44e810f23/ui/gl/BUILD.gn
[modify] https://crrev.com/c2f61690f7a59a4c6ac7cc4b99dd92b44e810f23/ui/gl/features.gni
[modify] https://crrev.com/c2f61690f7a59a4c6ac7cc4b99dd92b44e810f23/ui/gl/gl_image_io_surface_egl.mm
[modify] https://crrev.com/c2f61690f7a59a4c6ac7cc4b99dd92b44e810f23/ui/gl/init/gl_initializer_mac.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Mar 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20c7724eeb9e4f57f5398240654de89722a5902f

commit 20c7724eeb9e4f57f5398240654de89722a5902f
Author: Alexis Hetu <sugoi@google.com>
Date: Sat Mar 24 03:57:31 2018

GLImageIOSurfaceEGL::BindTexImageImpl implementation

This function is required for YUV decoding in Chromium
on MacOS using EGL. Fixes WebGL conformance test:
conformance/extensions/oes-texture-float-with-video.html

Bug: chromium:757974
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I143d69d30251b361daad13b4c0190e13f66795f8
Reviewed-on: https://chromium-review.googlesource.com/956247
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545667}
[modify] https://crrev.com/20c7724eeb9e4f57f5398240654de89722a5902f/ui/gl/BUILD.gn
[modify] https://crrev.com/20c7724eeb9e4f57f5398240654de89722a5902f/ui/gl/gl_context_cgl.cc
[modify] https://crrev.com/20c7724eeb9e4f57f5398240654de89722a5902f/ui/gl/gl_context_egl.cc
[modify] https://crrev.com/20c7724eeb9e4f57f5398240654de89722a5902f/ui/gl/gl_context_egl.h
[modify] https://crrev.com/20c7724eeb9e4f57f5398240654de89722a5902f/ui/gl/gl_image_io_surface_egl.h
[modify] https://crrev.com/20c7724eeb9e4f57f5398240654de89722a5902f/ui/gl/gl_image_io_surface_egl.mm
[modify] https://crrev.com/20c7724eeb9e4f57f5398240654de89722a5902f/ui/gl/yuv_to_rgb_converter.cc

Comment 16 by kbr@chromium.org, Mar 27 2018

Blocking: 826412
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/148f8c6decc123bb840a37b013caa8eed27759fd

commit 148f8c6decc123bb840a37b013caa8eed27759fd
Author: Alexis Hetu <sugoi@google.com>
Date: Wed Mar 28 00:58:31 2018

Disable YUV to RGB conversion for non surfaceless EGL contexts

Since YUVToRGBConverter objects can only be properly released
with a surfaceless EGL context currently, a check was added to
make sure we don't create these objects when surfaceless
contexts are not supported.

Note that this change is a noop effectively, since
YUVToRGBConverter objects are only ever requested from MacOS
specific .mm files, where surfaceless EGL context are always
supported, but it prevents future code on other platforms
from trying to use YUVToRGBConverter objects without being
able to properly release them later on.

R=piman@chromium.org

Bug: chromium:757974
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id31a3574a4a287b67744ab55bbdd9a9bdfd78daf
Reviewed-on: https://chromium-review.googlesource.com/982274
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546346}
[modify] https://crrev.com/148f8c6decc123bb840a37b013caa8eed27759fd/ui/gl/gl_context_egl.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f95a75118242531dac3bc190fb7501f05dbd1410

commit f95a75118242531dac3bc190fb7501f05dbd1410
Author: Alexis Hetu <sugoi@google.com>
Date: Thu Apr 12 19:03:40 2018

EGL libraries path fix for MacOS

Loading EGL libraries on MacOS works properly for chromium, but not for
running gl_tests. This change makes it work for both cases.

Bug: chromium:757974
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I14ad47e1f88270f5a1a1c83bd33c32373f57dc62
Reviewed-on: https://chromium-review.googlesource.com/1010032
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550294}
[modify] https://crrev.com/f95a75118242531dac3bc190fb7501f05dbd1410/ui/gl/init/gl_initializer_mac.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f95a75118242531dac3bc190fb7501f05dbd1410

commit f95a75118242531dac3bc190fb7501f05dbd1410
Author: Alexis Hetu <sugoi@google.com>
Date: Thu Apr 12 19:03:40 2018

EGL libraries path fix for MacOS

Loading EGL libraries on MacOS works properly for chromium, but not for
running gl_tests. This change makes it work for both cases.

Bug: chromium:757974
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I14ad47e1f88270f5a1a1c83bd33c32373f57dc62
Reviewed-on: https://chromium-review.googlesource.com/1010032
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550294}
[modify] https://crrev.com/f95a75118242531dac3bc190fb7501f05dbd1410/ui/gl/init/gl_initializer_mac.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f066ff5113bd9d348f0aaf7ac6adc1ca1d1cd31

commit 8f066ff5113bd9d348f0aaf7ac6adc1ca1d1cd31
Author: Alexis Hetu <sugoi@google.com>
Date: Wed Apr 18 22:45:17 2018

EGL on MacOS for Content Shell

Added similar logic for Content Shell to the logic used to enable EGL on MacOS
for Chrome, since it is also considered a bundled app.
Also made sure no EGL library bundling happens for official chrome builds.
Finally, fixed the EGL library path on MacOS. Not sure why this was working
for Chromium, but this path works properly for both Chromium and Content Shell.

Bug: chromium:757974
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If0ec821765906d4e868eab38945ed34cf4f6399f
Reviewed-on: https://chromium-review.googlesource.com/1014358
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551864}
[modify] https://crrev.com/8f066ff5113bd9d348f0aaf7ac6adc1ca1d1cd31/chrome/BUILD.gn
[modify] https://crrev.com/8f066ff5113bd9d348f0aaf7ac6adc1ca1d1cd31/content/shell/BUILD.gn
[modify] https://crrev.com/8f066ff5113bd9d348f0aaf7ac6adc1ca1d1cd31/ui/gl/BUILD.gn
[modify] https://crrev.com/8f066ff5113bd9d348f0aaf7ac6adc1ca1d1cd31/ui/gl/init/gl_initializer_mac.cc

Project Member

Comment 21 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/364833ccb7bdacb7e5db3188b76293bcd5f68a6c

commit 364833ccb7bdacb7e5db3188b76293bcd5f68a6c
Author: Alexis Hetu <sugoi@google.com>
Date: Thu May 03 18:54:27 2018

Mac EGL build fix

Changes related to libsync caused a build failure on MacOS when EGL is enabled.

Credit to zmo@ for this fix, which I cherry picked from:
https://chromium-review.googlesource.com/c/chromium/src/+/1005017/19..20

Bug: chromium:757974
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie4b38b3d0c782fea4e12f5d99e2f50add94ebf84
Reviewed-on: https://chromium-review.googlesource.com/1042488
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555832}
[modify] https://crrev.com/364833ccb7bdacb7e5db3188b76293bcd5f68a6c/ui/gl/BUILD.gn
[modify] https://crrev.com/364833ccb7bdacb7e5db3188b76293bcd5f68a6c/ui/gl/gl_fence.cc

Project Member

Comment 22 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b81ee294a0a77595aef6d7d16c57aea8d3b499f7

commit b81ee294a0a77595aef6d7d16c57aea8d3b499f7
Author: Alexis Hetu <sugoi@google.com>
Date: Mon May 14 18:20:51 2018

Half float fix

While running layout tests on MacOS, one of the tests failed within
CopyTextureCHROMIUM() because of an unsupported type. The origin of
the failure was wihtin canvas_color_params.cc, where GL_HALF_FLOAT
was used instead of GL_HALF_FLOAT_OES. The validators for this type
is initialized within gpu/command_buffer/service/feature_info.cc
and contains GL_HALF_FLOAT_OES, but not GL_HALF_FLOAT, which isn't
supported on GLES2 and unfortunately has a different value.

Bug: chromium:757974
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: If7a28c53db4a4f6acef035ee432153cec4f0acbb
Reviewed-on: https://chromium-review.googlesource.com/1057360
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558379}
[modify] https://crrev.com/b81ee294a0a77595aef6d7d16c57aea8d3b499f7/third_party/blink/renderer/platform/graphics/canvas_color_params.cc

@sugoi: In comment#20 you've added a hard-coded dependency on "Versions/Current/Libraries/" in gl_initializer_mac.cc. Based on https://crrev.com/8685feba05 it seems like you should instead add "Libraries" to the framework_contents list in various mac_framework_bundle GN targets. If I'm understanding correctly this should create a "Libraries" -> "Versions/Current/Libraries" symlink in the app bundle, and you can then use "Libraries/" instead of "Versions/Current/Libraries/" in gl_initializer_mac.cc.
Project Member

Comment 24 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a73f4b50b93b573123d54450127ab88dc1f14f63

commit a73f4b50b93b573123d54450127ab88dc1f14f63
Author: Alexis Hetu <sugoi@google.com>
Date: Fri May 18 17:44:24 2018

Turn EGL on on MacOS

In order to be able to use SwiftShader on the bots, use_egl must be true
so that the EGL codepath is compiled into the executable.

This increases the official build size by about 44KB.

Bug:chromium:757974  chromium:726075   chromium:549742 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I21c254a877eda89edb74de879a0c8d5c16ca16b3
Reviewed-on: https://chromium-review.googlesource.com/1005017
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559945}
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/content/test/gpu/gpu_tests/gpu_process_integration_test.py
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/animations/skew-notsequential-compositor-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/3d-corners-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/backface-visibility-transformed-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/backface-visibility/backface-visibility-non3d-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/composited-scaled-child-with-border-radius-parent-clip-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/composited-translated-child-with-border-radius-parent-clip-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/culling/filter-occlusion-alpha-large-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/culling/filter-occlusion-blur-large-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/culling/tile-occlusion-boundaries-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/flat-with-transformed-child-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/geometry/vertical-scroll-composited-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/lots-of-img-layers-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/lots-of-img-layers-with-opacity-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/opacity-with-mask-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-above-composited-subframe-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-composited-subframe-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-on-grandparent-composited-grandchild-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-on-parent-composited-grandchild-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-on-two-ancestors-composited-grandchild-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/overflow/grandchild-composited-with-border-radius-ancestor-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/overflow/grandchild-with-border-radius-ancestor-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/overflow/mask-with-filter-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/overflow/nested-render-surfaces-with-rotation-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/overflow/scaled-overflow-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/overflow/siblings-composited-with-border-radius-ancestor-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/overflow/siblings-composited-with-border-radius-ancestor-one-clipped-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/overflow/siblings-with-border-radius-ancestor-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/overflow/tiled-mask-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/perpendicular-layer-sorting-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/scaling/tiled-layer-recursion-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/compositing/scrollbars/nested-overlay-scrollbars-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/css3/filters/filter-change-repaint-composited-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/css3/filters/filter-change-repaint-expected.png
[delete] https://crrev.com/25871b94c5ceaab6f25b14087ef81c5c8956318d/third_party/WebKit/LayoutTests/fast/block/margin-collapse/103-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/fast/webgl/pixelated-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/fast/webgl/webgl-composite-modes-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/fast/webgl/webgl-composite-modes-repaint-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/fast/webgl/webgl-composite-modes-tabswitching-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/hdr/color-jpeg-with-color-profile-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/http/tests/preload/dynamic_remove_preload_href-expected.txt
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-header-same-origin-get-async-expected.txt
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/images/color-profile-layer-filter-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/media/color-profile-video-seek-filter-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/paint/invalidation/compositing/new-stacking-context-expected.png
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/paint/invalidation/compositing/should-invoke-deferred-compositing-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/linux/http/tests/inspector-protocol/target/target-browser-context-expected.txt
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/linux/http/tests/xmlhttprequest/origin-header-cross-origin-post-sync-expected.txt
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/linux/http/tests/xmlhttprequest/origin-header-same-origin-post-async-expected.txt
[rename] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/linux/media/color-profile-video-seek-filter-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/linux/media/controls/lazy-loaded-style-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/linux/media/controls/lazy-loaded-style-expected.txt
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/linux/virtual/incremental-shadow-dom/media/controls/lazy-loaded-style-expected.txt
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/linux/virtual/outofblink-cors/http/tests/xmlhttprequest/origin-header-cross-origin-get-sync-expected.txt
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/linux/virtual/outofblink-cors/http/tests/xmlhttprequest/origin-header-same-origin-post-async-expected.txt
[delete] https://crrev.com/25871b94c5ceaab6f25b14087ef81c5c8956318d/third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/scrollbars/short-scrollbar-expected.png
[copy] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/return-from-printing-mode-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/lazy-loaded-style-expected.txt
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-canvas-alpha-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.10/media/controls/lazy-loaded-style-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.10/media/track/track-cue-rendering-vertical-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/exotic-color-space/images/12-55-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/exotic-color-space/images/182-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/exotic-color-space/images/2-dht-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/exotic-color-space/images/23-55-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/exotic-color-space/images/55-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/exotic-color-space/images/color-profile-munsell-adobe-to-srgb-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/exotic-color-space/images/color-profile-munsell-srgb-to-srgb-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/exotic-color-space/images/jpeg-yuv-image-decoding-expected.png
[delete] https://crrev.com/25871b94c5ceaab6f25b14087ef81c5c8956318d/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-svg-fill-text-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/prefer_compositing_to_lcd_text/compositing/overflow/universal-accelerated-overflow-scroll-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/video-surface-layer/media/track/track-cue-rendering-vertical-expected.png
[copy] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.11/external/wpt/webrtc/protocol/video-codecs-expected.txt
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls/lazy-loaded-style-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/track/track-cue-rendering-vertical-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/exotic-color-space/images/12-55-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/exotic-color-space/images/182-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/exotic-color-space/images/2-dht-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/exotic-color-space/images/23-55-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/exotic-color-space/images/55-expected.png
[delete] https://crrev.com/25871b94c5ceaab6f25b14087ef81c5c8956318d/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu-rasterization/images/color-profile-image-filter-all-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/prefer_compositing_to_lcd_text/compositing/overflow/universal-accelerated-overflow-scroll-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/track/track-cue-rendering-vertical-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/css3/blending/background-blend-mode-overlapping-accelerated-elements-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/external/wpt/webrtc/protocol/video-codecs-expected.txt
[delete] https://crrev.com/25871b94c5ceaab6f25b14087ef81c5c8956318d/third_party/WebKit/LayoutTests/platform/mac-mac10.12/images/feature-policy-max-downscaling-image-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-after-reload-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-strict-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-styling-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-styling-strict-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-without-preload-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls/lazy-loaded-style-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/track/track-cue-rendering-horizontal-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-controls-rendering-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-display-toggle-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-no-audio-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-zoom-controls-expected.png
[delete] https://crrev.com/25871b94c5ceaab6f25b14087ef81c5c8956318d/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-styles-expected.txt
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/gpu-rasterization/images/color-profile-image-filter-all-expected.png
[delete] https://crrev.com/25871b94c5ceaab6f25b14087ef81c5c8956318d/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-expected.png
[delete] https://crrev.com/25871b94c5ceaab6f25b14087ef81c5c8956318d/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-resize-expected.png
[delete] https://crrev.com/25871b94c5ceaab6f25b14087ef81c5c8956318d/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-styles-expected.png
[delete] https://crrev.com/25871b94c5ceaab6f25b14087ef81c5c8956318d/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/gpu/fast/canvas/canvas-composite-shadow-expected.png
[delete] https://crrev.com/25871b94c5ceaab6f25b14087ef81c5c8956318d/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
[delete] https://crrev.com/25871b94c5ceaab6f25b14087ef81c5c8956318d/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/gpu/fast/canvas/fillrect_gradient-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/incremental-shadow-dom/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/incremental-shadow-dom/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-after-reload-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-strict-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-styling-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-styling-strict-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-without-preload-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls/paint-controls-webkit-appearance-none-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/track/track-cue-rendering-horizontal-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-controls-rendering-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-display-toggle-expected.png
[modify] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[add] https://crrev.com/a73f4b50b93b573123d54450127ab88dc1f14f63/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/protocol/video-codecs-expected.txt
[copy] https://crrev.com/a73f
Blockedon: 897573

Sign in to add a comment