As an experiment... complete plan here: go/chrome-omnibox-ui-experiments-eng-doc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8875a443dcee0ad641380469fa4320900939a224 commit 8875a443dcee0ad641380469fa4320900939a224 Author: Tommy C. Li <tommycli@chromium.org> Date: Wed Aug 23 00:10:59 2017 Omnibox UI Experiments: Add flag for suggestion favicons Bug: 757967 Change-Id: I863cb3dc5cc9d3e08dadaeef6ec064c16085b8b8 Reviewed-on: https://chromium-review.googlesource.com/627061 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#496516} [modify] https://crrev.com/8875a443dcee0ad641380469fa4320900939a224/chrome/browser/about_flags.cc [modify] https://crrev.com/8875a443dcee0ad641380469fa4320900939a224/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/8875a443dcee0ad641380469fa4320900939a224/chrome/browser/flag_descriptions.h [modify] https://crrev.com/8875a443dcee0ad641380469fa4320900939a224/components/omnibox/browser/omnibox_field_trial.cc [modify] https://crrev.com/8875a443dcee0ad641380469fa4320900939a224/components/omnibox/browser/omnibox_field_trial.h [modify] https://crrev.com/8875a443dcee0ad641380469fa4320900939a224/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dec3647a738678bfbe67200e92af8ef0e952d800 commit dec3647a738678bfbe67200e92af8ef0e952d800 Author: Tommy C. Li <tommycli@chromium.org> Date: Wed Aug 30 18:11:39 2017 Omnibox UI Mac: Remove leftover incognitoImage property. No longer needed since https://codereview.chromium.org/2082723002, so removing this property. Lays groundwork for implementing favicons on Cocoa. Bug: 757967 Change-Id: Icea1a6deb5c1a61360a187b30e7e3b0293df9c4c Reviewed-on: https://chromium-review.googlesource.com/642487 Reviewed-by: Rachel Blum <groby@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#498536} [modify] https://crrev.com/dec3647a738678bfbe67200e92af8ef0e952d800/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h [modify] https://crrev.com/dec3647a738678bfbe67200e92af8ef0e952d800/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm [modify] https://crrev.com/dec3647a738678bfbe67200e92af8ef0e952d800/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b9185c74c8a523c4b6aa36f2869cb1db6488502 commit 3b9185c74c8a523c4b6aa36f2869cb1db6488502 Author: Tommy C. Li <tommycli@chromium.org> Date: Wed Aug 30 18:40:32 2017 Omnibox UI Experiments: Add Views support for fetching favicons This is part of the experiment to show favicons next to URL suggestions in the Omnibox dropdown. This implements the Views version and embedder support. Bug: 757967 Change-Id: I2d56584a892763c1269793245aff8568f7206c49 Reviewed-on: https://chromium-review.googlesource.com/629839 Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#498546} [modify] https://crrev.com/3b9185c74c8a523c4b6aa36f2869cb1db6488502/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h [modify] https://crrev.com/3b9185c74c8a523c4b6aa36f2869cb1db6488502/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm [modify] https://crrev.com/3b9185c74c8a523c4b6aa36f2869cb1db6488502/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm [modify] https://crrev.com/3b9185c74c8a523c4b6aa36f2869cb1db6488502/chrome/browser/ui/omnibox/chrome_omnibox_client.cc [modify] https://crrev.com/3b9185c74c8a523c4b6aa36f2869cb1db6488502/chrome/browser/ui/omnibox/chrome_omnibox_client.h [modify] https://crrev.com/3b9185c74c8a523c4b6aa36f2869cb1db6488502/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc [modify] https://crrev.com/3b9185c74c8a523c4b6aa36f2869cb1db6488502/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h [modify] https://crrev.com/3b9185c74c8a523c4b6aa36f2869cb1db6488502/chrome/browser/ui/views/omnibox/omnibox_result_view.cc [modify] https://crrev.com/3b9185c74c8a523c4b6aa36f2869cb1db6488502/chrome/browser/ui/views/omnibox/omnibox_result_view.h [modify] https://crrev.com/3b9185c74c8a523c4b6aa36f2869cb1db6488502/components/omnibox/browser/omnibox_client.h [modify] https://crrev.com/3b9185c74c8a523c4b6aa36f2869cb1db6488502/components/omnibox/browser/omnibox_popup_model.cc [modify] https://crrev.com/3b9185c74c8a523c4b6aa36f2869cb1db6488502/components/omnibox/browser/omnibox_popup_model.h [modify] https://crrev.com/3b9185c74c8a523c4b6aa36f2869cb1db6488502/components/omnibox/browser/omnibox_popup_view.h [modify] https://crrev.com/3b9185c74c8a523c4b6aa36f2869cb1db6488502/ios/chrome/browser/ui/omnibox/omnibox_popup_view_ios.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/491455c7812b3e22080f281d61a2af020b6b44f7 commit 491455c7812b3e22080f281d61a2af020b6b44f7 Author: Tommy C. Li <tommycli@chromium.org> Date: Thu Sep 07 00:02:14 2017 Omnibox UI Experiments: Implement Favicons on Cocoa This required refactoring how the icons worked. Now they are stored within OmniboxPopupModel and consolidated with the extension-provided icons. This CL also de-duplicates some Views and Cocoa code as a side-effect. Bug: 757967 Change-Id: Iff5ef4f49d0ee68fd4771f7a61b4077a3b02fe51 Reviewed-on: https://chromium-review.googlesource.com/646642 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#500146} [modify] https://crrev.com/491455c7812b3e22080f281d61a2af020b6b44f7/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h [modify] https://crrev.com/491455c7812b3e22080f281d61a2af020b6b44f7/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h [modify] https://crrev.com/491455c7812b3e22080f281d61a2af020b6b44f7/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm [modify] https://crrev.com/491455c7812b3e22080f281d61a2af020b6b44f7/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h [modify] https://crrev.com/491455c7812b3e22080f281d61a2af020b6b44f7/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm [modify] https://crrev.com/491455c7812b3e22080f281d61a2af020b6b44f7/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm [modify] https://crrev.com/491455c7812b3e22080f281d61a2af020b6b44f7/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc [modify] https://crrev.com/491455c7812b3e22080f281d61a2af020b6b44f7/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h [modify] https://crrev.com/491455c7812b3e22080f281d61a2af020b6b44f7/chrome/browser/ui/views/omnibox/omnibox_result_view.cc [modify] https://crrev.com/491455c7812b3e22080f281d61a2af020b6b44f7/chrome/browser/ui/views/omnibox/omnibox_result_view.h [modify] https://crrev.com/491455c7812b3e22080f281d61a2af020b6b44f7/components/omnibox/browser/omnibox_popup_model.cc [modify] https://crrev.com/491455c7812b3e22080f281d61a2af020b6b44f7/components/omnibox/browser/omnibox_popup_model.h [modify] https://crrev.com/491455c7812b3e22080f281d61a2af020b6b44f7/components/omnibox/browser/omnibox_popup_view.h [modify] https://crrev.com/491455c7812b3e22080f281d61a2af020b6b44f7/ios/chrome/browser/ui/omnibox/omnibox_popup_view_ios.h
Feature is complete, addressing bugs in their separate issues.
Comment 1 by bugdroid1@chromium.org
, Aug 23 2017