New warning: "Ignoring invalid file v8_context_snapshot.bin" |
|||
Issue descriptionThis warning has appeared when launching app_shell: [6008:6290:0822/132430.999789:10598894497654:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file v8_context_snapshot.bin In https://chromium-review.googlesource.com/c/623287/, why was v8_context_snapshot added as a dependency only to the Mac build of app_shell? (For context, app_shell is a shell that runs Chrome apps without Chrome. LMK if you have questions.)
,
Aug 23 2017
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5338611c0a7ae76c19a4800f1d45aec943dbed2f commit 5338611c0a7ae76c19a4800f1d45aec943dbed2f Author: Hitoshi Yoshida <peria@chromium.org> Date: Wed Aug 23 08:29:03 2017 bindings: Bind v8_context_snapshot.bin to browser_tests Bug: 757956 Change-Id: I648e9d706bc9aa6582447c4b319e804f155a948e Reviewed-on: https://chromium-review.googlesource.com/627531 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#496625} [modify] https://crrev.com/5338611c0a7ae76c19a4800f1d45aec943dbed2f/content/test/BUILD.gn [modify] https://crrev.com/5338611c0a7ae76c19a4800f1d45aec943dbed2f/tools/v8_context_snapshot/BUILD.gn
,
Aug 25 2017
Michael, Thank you for reporting this. I think #3 works for browser_tests. But I can't reproduce the message in app_shell on MacOSX. Could you tell me which you think strange in .gn files? I think app_shell depends on app_shell_framework_bundle_data, and it has the bin file in source.
,
Aug 25 2017
app_shell on macOS specifically lists v8_context_snapshot.bin in its deps, but app_shell on Linux/Windows/CrOS do not. So the app_shell warning reproduces on Linux and, I assume, Windows and CrOS too. Shouldn't it be a dependency for every platform, not just Mac?
,
Aug 28 2017
Yes, app_shell on other platforms also need to depend on it. Lacking the deps parameter is my mistake.
,
Feb 6 2018
I'm not sure which CL actually works, but for now, the warning does not show up. So let me close this. If you think it is still going, please let me know. |
|||
►
Sign in to add a comment |
|||
Comment 1 by michae...@chromium.org
, Aug 23 2017Labels: -Pri-3 Pri-2