New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757955 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: 2019-07-09
OS: Windows
Pri: 3
Type: Bug-Regression



Sign in to add a comment

webkit_layout_tests failing on chromium.webkit/WebKit Win7 (dbg)

Project Member Reported by iclell...@chromium.org, Aug 22 2017

Issue description

webkit_layout_tests failing on chromium.webkit/WebKit Win7 (dbg)

Builders failed on: 
- WebKit Win7 (dbg): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29


Of the last 200 builds, 90 have failed due to layout test failures.

Surveying the last 25, 23 have failed, with these tests all flakily timing out:

( 2) animations/animations-parsing.html
( 7) animations/interpolation/svg-d-interpolation.html
(13) css3/filters/effect-reference-hw.html
( 1) external/wpt/css/css-shapes-1/spec-examples/shape-outside-019.html
( 1) external/wpt/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-errors-han.html
(17) external/wpt/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-errors-han.html
( 1) external/wpt/html/semantics/embedded-content/the-img-element/decode/image-decode.html
( 1) external/wpt/media-source/mediasource-detach.html
( 1) Failed due to executables not found
( 7) inspector/sources/debugger-pause/pause-on-elements-panel.html
( 1) inspector/tracing/timeline-paint/layer-tree.html
(10) media/color-profile-video-seek-filter.html
( 1) virtual/gpu/fast/canvas/canvas-strokeRect-alpha-shadow.html
( 1) virtual/mojo-loading/http/tests/inspector-protocol/audits/get-encoded-response.js
( 1) virtual/threaded/animations/composited-animations-rotate-zero-degrees.html
( 1) virtual/threaded/fast/scroll-behavior/smooth-scroll/main-thread-scrolling-reason-added.html
( 1) virtual/threaded/transitions/transition-end-event-transform.html

animations/animations-parsing.html and external/wpt/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-errors-han.html have alreday been marked as flaky. I'm going to mark the other ones which have times out more than once as flaky as well.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aea3b20431f778644a2ac2b9acc7a8396edf4473

commit aea3b20431f778644a2ac2b9acc7a8396edf4473
Author: Ian Clelland <iclelland@google.com>
Date: Tue Aug 22 22:02:15 2017

Disable flaky layout tests on Win7 builder

Several tests have been flaking, causing a 45% failure rate for the
WebKit Win7 dbg builder. Disabling those to green the bot again.

Bug: 757955
Change-Id: I8b4951380e68c9a043f3f2efcc4fe831e39c6b22
TBR: dpranke@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/627299
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496462}
[modify] https://crrev.com/aea3b20431f778644a2ac2b9acc7a8396edf4473/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by tapted@chromium.org, Aug 23 2017

Owner: tansell@chromium.org
Status: Assigned (was: Available)
This is persisting, but with a new error, since

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/10594

errors like

05:31:14.875 1964 Checking build ...
05:31:14.875 1964 Unable to find test driver
05:31:14.875 1964     at e:\b\swarm_slave\w\ir\out\Release\content_shell.exe
05:31:14.875 1964 Unable to find content_shell_crash_service.exe
05:31:14.875 1964     at e:\b\swarm_slave\w\ir\out\Release\content_shell_crash_service.exe
05:31:14.876 1964     Could not find crash service, unexpected crashes won't be symbolized.
05:31:14.876 1964     Did you build the target blink_tests?
05:31:14.876 1964 
05:31:14.876 1964 For complete Windows build requirements, please see:
05:31:14.876 1964 
05:31:14.876 1964     https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_instructions.md
05:31:14.876 1964 Build check failed
05:31:14.879 1964 
05:31:14.879 1964 Testing completed. Exit status: 255

I think it's due to r496264 -> https://chromium-review.googlesource.com/625539

`webkit_layout_tests` doesn't appear in the run prior, just `webkit_tests` - https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/10593
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb027fe65919314bbbdfb18acb35b8e41f0cf6d9

commit fb027fe65919314bbbdfb18acb35b8e41f0cf6d9
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Wed Aug 23 05:48:37 2017

buildbot: Adding --debug to WebKit Win7 (dbg) bot.

Should fix;
------------------------------------
22:11:25.948 2648 Found 13285 tests (total 66425); running 11471, skipping 1814.
22:11:25.948 2648 Checking build ...
22:11:25.948 2648 Unable to find test driver
22:11:25.949 2648     at e:\b\swarm_slave\w\ir\out\Release\content_shell.exe
22:11:25.949 2648 Unable to find content_shell_crash_service.exe
22:11:25.949 2648     at e:\b\swarm_slave\w\ir\out\Release\content_shell_crash_service.exe
22:11:25.949 2648     Could not find crash service, unexpected crashes won't be symbolized.
22:11:25.949 2648     Did you build the target blink_tests?
22:11:25.949 2648
22:11:25.949 2648 For complete Windows build requirements, please see:
22:11:25.949 2648
22:11:25.949 2648     https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_instructions.md
22:11:25.949 2648 Build check failed
22:11:25.952 2648
22:11:25.952 2648 Testing completed. Exit status: 255
------------------------------------

BUG= 717348 , 524758 ,757955
TBR=tapted@google.com
CC=​qyearsley@chromium.org,dpranke@chromium.org
NOTRY=true

Change-Id: I27047cca345ec367d70a7bfa486f459f596a2f90
Reviewed-on: https://chromium-review.googlesource.com/627551
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496592}
[modify] https://crrev.com/fb027fe65919314bbbdfb18acb35b8e41f0cf6d9/testing/buildbot/chromium.webkit.json

Status: Fixed (was: Assigned)
With https://chromium-review.googlesource.com/627551 now appears to be working properly.
Status: Started (was: Fixed)
That was a good catch, and seems to have been plaguing this bot for several runs, but the main issue seems to still be present --

That patch first landed on this bot with build 10603, which was red, and all subsequent runs have been red as well.

Still seeing failures on this bot in
(1) accessibility/element-role-mapping-normal.html
(2) css3/filters/effect-reference-colorspace-hw.html
(1) css3/filters/blur-filter-page-scroll-parents.html(3) storage/indexeddb/objectstore-cursor.html
(2) external/wpt/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-errors-han.html
(1) fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html
(1) inspector/sources/debugger-frameworks/frameworks-steppings.html
(2) inspector/tracing/frame-model-instrumentation.html
(1) inspector/tracing/timeline-paint/layer-tree.html
(2) storage/indexeddb/mozilla/cursors.html
(1) transforms/2d/transform-2d.html

I'll disable the new ones with multiple timeouts:
css3/filters/effect-reference-colorspace-hw.html
external/wpt/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-errors-han.html
inspector/tracing/frame-model-instrumentation.html
storage/indexeddb/mozilla/cursors.html

and see if we can't get a green run out of this bot.
(And storage/indexeddb/objectstore-cursor.html)
I am disabling css3/filters/effect-reference-colorspace-hw.html in https://chromium-review.googlesource.com/c/chromium/src/+/628736 (I did a similar analysis in  issue 758124 ).
Cc: vitaliii@chromium.org
 Issue 758124  has been merged into this issue.
My counts based on range 10570-10608

      1 * accessibility/element-role-mapping-normal.html
      1 * transforms/2d/transform-2d.html
      1 * inspector/tracing/frame-model-instrumentation.html
      1 * fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html
      1 * external/wpt/css/css-shapes-1/spec-examples/shape-outside-019.html
      1 * external/wpt/encoding/legacy-mb-japanese/shift_jis/sjis-encode-href-errors-han.html
      1 * external/wpt/html/semantics/embedded-content/the-img-element/decode/image-decode.html
      1 * external/wpt/media-source/mediasource-detach.html
      1 * virtual/gpu/fast/canvas/canvas-strokeRect-alpha-shadow.html
      1 * virtual/mojo-loading/http/tests/inspector-protocol/audits/get-encoded-response.js
      1 * virtual/threaded/animations/composited-animations-rotate-zero-degrees.html
      1 * blur-filter-page-scroll-parents.html
      1 * virtual/threaded/transitions/transition-end-event-transform.html
      2 * animations/animations-parsing.html
      2 * external/wpt/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-errors-han.html
      2 * inspector/tracing/timeline-paint/layer-tree.html
      2 * inspector/sources/debugger-frameworks/frameworks-steppings.html
      2 * storage/indexeddb/mozilla/cursors.html
      2 * css3/filters/effect-reference-colorspace-hw.html
      3 * storage/indexeddb/objectstore-cursor.html
 Issue 758164  has been merged into this issue.
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/876d6603bbbf6becd51afc77b2b851b9ca7478e1

commit 876d6603bbbf6becd51afc77b2b851b9ca7478e1
Author: Ian Clelland <iclelland@google.com>
Date: Wed Aug 23 14:58:24 2017

Mark several more tests as flaky on WebKit Win7 Dbg

Bug: 757955
Change-Id: I03cb104b61d69a567df155b0c43a68ac6129d018
TBR: vitaliii@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/628657
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496686}
[modify] https://crrev.com/876d6603bbbf6becd51afc77b2b851b9ca7478e1/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a36b372e3410131dfe2f327f13046f740fbe4c6a

commit a36b372e3410131dfe2f327f13046f740fbe4c6a
Author: Yoichi Osato <yoichio@chromium.org>
Date: Fri Aug 25 09:16:29 2017

Mark several more tests as flaky on WebKit Win7 Dbg

Bug: 757955
Change-Id: I3fe92d8aeb4e71bcc9dc50e66df1a954470d833e
TBR: vitaliii@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/635066
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497363}
[modify] https://crrev.com/a36b372e3410131dfe2f327f13046f740fbe4c6a/third_party/WebKit/LayoutTests/TestExpectations

Comment 13 by hbos@chromium.org, Aug 30 2017

Labels: -Sheriff-Chromium
Removing sheriff label since the tests have been marked as flaky.
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7bb9ad1050138687a6c70d7a4ef3aa3c295b616

commit b7bb9ad1050138687a6c70d7a4ef3aa3c295b616
Author: Ian Clelland <iclelland@google.com>
Date: Fri Sep 01 19:36:18 2017

Marking timeline-paint/layer-tree.html as failing

This test has an internal JS-based timeout, which is causing a failure
on the WebKit Win7 (dbg) bot before the test harness itself can time
out. Marking the test as [ Pass Failure Timeout ].

NOTRY=True

Bug:  761333 , 757955
Change-Id: I9e324e52129681ab88abfadd417bdbd2dcba8928
TBR: chenwilliam@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/647777
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499259}
[modify] https://crrev.com/b7bb9ad1050138687a6c70d7a4ef3aa3c295b616/third_party/WebKit/LayoutTests/TestExpectations

Cc: tansell@chromium.org
Owner: ----
Status: Untriaged (was: Started)
Project Member

Comment 16 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01984eb9aee29fa781bf48f807d3fffcec8dc614

commit 01984eb9aee29fa781bf48f807d3fffcec8dc614
Author: ericwilligers <ericwilligers@chromium.org>
Date: Thu Sep 07 12:56:04 2017

CSS Animation: Split SVG d interpolation test

The layout test svg-d-interpolation.html
sometimes times out.

The test is now sharded.

There is no change to the content of the test.

BUG= 726075 ,757955

Change-Id: Ic6c22afa3a0a5249554e1c59c8bd4e7ec4906528
Reviewed-on: https://chromium-review.googlesource.com/654403
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500284}
[modify] https://crrev.com/01984eb9aee29fa781bf48f807d3fffcec8dc614/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/01984eb9aee29fa781bf48f807d3fffcec8dc614/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/01984eb9aee29fa781bf48f807d3fffcec8dc614/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/01984eb9aee29fa781bf48f807d3fffcec8dc614/third_party/WebKit/LayoutTests/animations/interpolation/svg-d-interpolation-001.html
[add] https://crrev.com/01984eb9aee29fa781bf48f807d3fffcec8dc614/third_party/WebKit/LayoutTests/animations/interpolation/svg-d-interpolation-002.html
[add] https://crrev.com/01984eb9aee29fa781bf48f807d3fffcec8dc614/third_party/WebKit/LayoutTests/animations/interpolation/svg-d-interpolation-003.html
[add] https://crrev.com/01984eb9aee29fa781bf48f807d3fffcec8dc614/third_party/WebKit/LayoutTests/animations/interpolation/svg-d-interpolation-004.html
[delete] https://crrev.com/39f0671cabbdb389bc38d06249cadbe6453e5a54/third_party/WebKit/LayoutTests/animations/interpolation/svg-d-interpolation.html

Project Member

Comment 17 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3d19882cc685834c4e2be967f5fc87335864824

commit b3d19882cc685834c4e2be967f5fc87335864824
Author: Xida Chen <xidachen@chromium.org>
Date: Wed Sep 27 15:29:53 2017

color-profile-video-seek-filter.html times out on win release

TBR=vitaliii@chromium.org
NOTRY=true

Bug: 757955
Change-Id: I415435d5964d1ea50a5dc2a08d39cb3f1007fb5c
Reviewed-on: https://chromium-review.googlesource.com/687474
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504685}
[modify] https://crrev.com/b3d19882cc685834c4e2be967f5fc87335864824/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 18 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb22839ef13cf7fc5791d525290c1569357b1282

commit bb22839ef13cf7fc5791d525290c1569357b1282
Author: Alexis Hetu <sugoi@google.com>
Date: Thu Sep 28 23:58:35 2017

Adding flaky test to TestExpectations

This test is also flaky on Linux (dbg):
virtual/threaded/transitions/transition-end-event-transform.html

TBR=kbr@chromium.org

Bug: 757955
Change-Id: Iceed2eb7ec013dc396314b754ec4b0885f03876d
Reviewed-on: https://chromium-review.googlesource.com/691061
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505217}
[modify] https://crrev.com/bb22839ef13cf7fc5791d525290c1569357b1282/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 19 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3416b01ac665459fe278a807b6d8b9c4d8172d9

commit c3416b01ac665459fe278a807b6d8b9c4d8172d9
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Tue Oct 03 22:14:47 2017

Transition tests: enable transition-end-event test

transition-end-event tests are passing due to
https://chromium-review.googlesource.com/694702

BUG=757955, 763810 

Change-Id: I92646e115b70e45ced2c2dd042257b811edd4a8e
Reviewed-on: https://chromium-review.googlesource.com/696442
Reviewed-by: Walter Korman <wkorman@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506204}
[modify] https://crrev.com/c3416b01ac665459fe278a807b6d8b9c4d8172d9/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/c3416b01ac665459fe278a807b6d8b9c4d8172d9/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58388bc343a9e488217758a677655ff543fff5a9

commit 58388bc343a9e488217758a677655ff543fff5a9
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Mon Nov 06 22:05:58 2017

Improve flaky virtual/threaded/animations tests

Tolerate callbacks being delayed, for example when run under swarming.

To force numerous style recalculations, read offsetTop instead of
waiting for a rAF each time.

Wait for double rAF before capturing output.

BUG=248938,757955

Change-Id: I3c89129904df1be6c2468e8298cd0c264b712612
Reviewed-on: https://chromium-review.googlesource.com/724319
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514254}
[modify] https://crrev.com/58388bc343a9e488217758a677655ff543fff5a9/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/58388bc343a9e488217758a677655ff543fff5a9/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/58388bc343a9e488217758a677655ff543fff5a9/third_party/WebKit/LayoutTests/animations/animation-offscreen-to-onscreen.html
[modify] https://crrev.com/58388bc343a9e488217758a677655ff543fff5a9/third_party/WebKit/LayoutTests/animations/animation-paused-hardware.html
[modify] https://crrev.com/58388bc343a9e488217758a677655ff543fff5a9/third_party/WebKit/LayoutTests/animations/animation-shorthand-name-order.html
[modify] https://crrev.com/58388bc343a9e488217758a677655ff543fff5a9/third_party/WebKit/LayoutTests/animations/big-rotation.html
[modify] https://crrev.com/58388bc343a9e488217758a677655ff543fff5a9/third_party/WebKit/LayoutTests/animations/change-transform-style-during-animation.html
[modify] https://crrev.com/58388bc343a9e488217758a677655ff543fff5a9/third_party/WebKit/LayoutTests/animations/direction-and-fill/animation-direction-reverse-fill-mode-hardware.html
[modify] https://crrev.com/58388bc343a9e488217758a677655ff543fff5a9/third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js
[modify] https://crrev.com/58388bc343a9e488217758a677655ff543fff5a9/third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-animation-style-update.html

Labels: Pri-3
NextAction: 2019-07-09
Downgrading P2s that haven't been modified in more than 6 months, which have no component or owner.

Sign in to add a comment