New issue
Advanced search Search tips

Issue 757948 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

WebView fires accessibility events even when it's not focused

Project Member Reported by dmazz...@chromium.org, Aug 22 2017

Issue description

Chrome fires accessibility events on page load, and when the web page moves focus. This makes sense.

WebView shouldn't do this, because there may be more than one WebView on the page and they might all be fighting with each other.

There's already some code to avoid firing a focus event when the page loads, but we need to generalize that.

See b/33801661

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91cc2b77e3f79838a0178e8e27096132e64f17f3

commit 91cc2b77e3f79838a0178e8e27096132e64f17f3
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Wed Aug 23 05:29:16 2017

Avoid changing accessibility focus on page load for WebView (vs Chrome)

Chrome fires accessibility events on page load, and when the web page
moves focus. This makes sense.

WebView shouldn't do this, because there may be more than one WebView
on the page and they might all be fighting with each other.

We already had a boolean shouldFocusOnPageLoad that's false when we're
in a WebView, so we can avoid firing a focus event when the page loads,
but there were two more places that sometimes moved accessibility
focus on load, and those need to respect the preference too.

Bug:  757948 
Change-Id: I3c1b60ea5f81b3bb85776dfa950869a3e96c7cfa
Reviewed-on: https://chromium-review.googlesource.com/627166
Reviewed-by: Paul Miller <paulmiller@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496589}
[modify] https://crrev.com/91cc2b77e3f79838a0178e8e27096132e64f17f3/content/browser/accessibility/web_contents_accessibility_android.cc
[modify] https://crrev.com/91cc2b77e3f79838a0178e8e27096132e64f17f3/content/browser/accessibility/web_contents_accessibility_android.h
[modify] https://crrev.com/91cc2b77e3f79838a0178e8e27096132e64f17f3/content/public/android/java/src/org/chromium/content/browser/accessibility/WebContentsAccessibility.java

Status: Fixed (was: Assigned)

Sign in to add a comment