git cl format failing to format histograms.xml |
|||
Issue descriptionThis has happened recently to me. git cl format just produces no changes, regardless of the type of formatting issue. I've seen at least: - No alphabetical ordering - No line length enforcing (introducing newlines) - No indentation fixes This is happening for me at r496312
,
Aug 23 2017
Yeah, I definitely goofed in a previous CL. Fix here: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/627590
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/235b70db85e63d3ef32941991845997c58b940b8 commit 235b70db85e63d3ef32941991845997c58b940b8 Author: Ilya Sherman <isherman@chromium.org> Date: Tue Aug 29 00:30:04 2017 [git cl format] Actually format metrics XML files (fix an indentation error) I introduced an indentation error in [1] which caused "git cl format" to typically do nothing for histograms.xml and other metrics XML files. Oops. [1] https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/569105 R=dpranke@chromium.org Bug: 757939 Change-Id: Iab9975588156fca29e119e889ae634c5f77cb704 Reviewed-on: https://chromium-review.googlesource.com/627590 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> [modify] https://crrev.com/235b70db85e63d3ef32941991845997c58b940b8/git_cl.py
,
Sep 1 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by asvitk...@chromium.org
, Aug 22 2017Status: Assigned (was: Untriaged)