New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757938 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[SPv2] Missing frame scrollbars in painted result

Project Member Reported by wangxianzhu@chromium.org, Aug 22 2017

Issue description

For the following layout tests, scrollbars are missing in painted results:

Bug(none) paint/invalidation/background-image-paint-invalidation-large-abspos-div.html [ Failure ]
Bug(none) paint/invalidation/compositing/newly-composited-on-scroll.html [ Failure ]
Bug(none) paint/invalidation/compositing/newly-composited-repaint-rect.html [ Pass Failure ]
Bug(none) paint/invalidation/full-viewport-repaint-for-background-attachment-fixed.html [ Failure ]
Bug(none) paint/invalidation/inline-style-change-in-scrolled-view.html [ Failure ]
Bug(none) paint/invalidation/nested-fixed-iframe-scrolled.html [ Failure ]
Bug(none) paint/invalidation/repaint-during-scroll.html [ Failure ]
Bug(none) paint/invalidation/svg/repaint-in-scrolled-view.html [ Failure ]
Bug(none) paint/invalidation/svg/text-xy-updates-SVGList.xhtml [ Failure ]

 
Cc: chrishtr@chromium.org
Summary: [SPv2] Missing frame scrollbars in painted result (was: [SPv2] Missing scrollbars in painted result)
This happens for frame (including the main frame) scrollbars only. This doesn't happen with --root-layer-scrolls. We will not need to work on this bug after RootLayerScrolling ships.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb94e55a1c5c47b2f90177c43e92651d1ba9287d

commit eb94e55a1c5c47b2f90177c43e92651d1ba9287d
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Aug 22 22:54:38 2017

Add bug numbers for some SPv2 paint/invalidation layout test failures

BUG=757977, 738613 , 757938 , 648274 
TBR=pdr@chromium.org,chrishtr@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I163c04bddfd2922adf78b87cb18749b5f02e9b4a
Reviewed-on: https://chromium-review.googlesource.com/627024
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496480}
[modify] https://crrev.com/eb94e55a1c5c47b2f90177c43e92651d1ba9287d/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2

Owner: wangxianzhu@chromium.org
Status: Started (was: Available)
Cc: trchen@chromium.org jbroman@chromium.org
Issue 589279 has been merged into this issue.
Status: Fixed (was: Started)
Now we paint scrollbars for frames, but we still need to implement composited scrollbar painted in the compositor thread. Bug 589279 and other bugs track that.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/911016dfdf920d3f911508d83216136e2968bccd

commit 911016dfdf920d3f911508d83216136e2968bccd
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Sep 28 17:21:41 2017

[SPv2] Paint frame scrollbars (non-RLS)

1. Disable composited layers for frame scrollbars in PaintLayerCompositor
   for SPv2.
2. Issue DrawingRecorder for scrollbar backgrounds.

This is mainly to reduce spv2 test failures. We still need a solution of
scrollbar painting during composited scrolling for spv2.

Bug:  757938 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: If5885cfb9a7e3b5dacbac0d26b0b59dd89f42a79
Reviewed-on: https://chromium-review.googlesource.com/685267
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505073}
[modify] https://crrev.com/911016dfdf920d3f911508d83216136e2968bccd/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[delete] https://crrev.com/5551119d425e01a440c59870650de1aa03147cf9/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/animated-gif-transformed-offscreen-expected.txt
[modify] https://crrev.com/911016dfdf920d3f911508d83216136e2968bccd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/outline-change-scrollable-expected.txt
[modify] https://crrev.com/911016dfdf920d3f911508d83216136e2968bccd/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/outline-change-vertical-rl-expected.txt
[delete] https://crrev.com/5551119d425e01a440c59870650de1aa03147cf9/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/repaint-overlay/layers-expected.txt
[delete] https://crrev.com/5551119d425e01a440c59870650de1aa03147cf9/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/svg/animated-svg-as-image-transformed-offscreen-expected.txt
[delete] https://crrev.com/5551119d425e01a440c59870650de1aa03147cf9/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/window-resize-vertical-writing-mode-expected.txt
[delete] https://crrev.com/5551119d425e01a440c59870650de1aa03147cf9/third_party/WebKit/LayoutTests/virtual/spv2/paint/invalidation/animated-gif-transformed-offscreen-expected.txt
[modify] https://crrev.com/911016dfdf920d3f911508d83216136e2968bccd/third_party/WebKit/Source/core/paint/FramePainter.cpp
[modify] https://crrev.com/911016dfdf920d3f911508d83216136e2968bccd/third_party/WebKit/Source/core/paint/compositing/PaintLayerCompositor.cpp

Sign in to add a comment