New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757925 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Distracting brightness slider animation when turning screen on or off on convertible device

Project Member Reported by derat@chromium.org, Aug 22 2017

Issue description

(Reported by Tony over email.)

On a convertible Chromebook:

1. Turn off the automatic-screen-lock setting (or start a guest session).
2. Put the device into tablet mode.
3. Open the system tray and see the screen brightness slider.
4. Tap the power button to turn the screen off.
5. Tap the power button again to turn the screen back on.

After step 5, you can see the brightness slider animating from 0% back to its original level.

This makes sense given how things work. powerd notifies Chrome about backlight brightness changes via BrightnessChanged D-Bus signals, and Chrome depends on receiving these. The signals include a "user_initiated" bool argument (see chromeos::PowerManagerClient::Observer::BrightnessChanged in Chrome), and Chrome uses this to avoid popping up the onscreen brightness bubble when an automated change is received while in laptop mode. It still animates the slider in the system tray, though.

I agree that it's distracting, though. Maybe Chrome should avoid animating the slider when the brightness changes to or from 0% in response to an automated change. This seems like it'd be easy to handle within ash/system/brightness/tray_brightness.cc, but I'm not sure there's any way to tell views::Slider to avoid animating when SetValue is called.
 

Comment 1 by tbroch@chromium.org, Aug 25 2017

Owner: derat@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by derat@chromium.org, Aug 25 2017

Owner: abodenha@chromium.org
Over to Albert to see if there's anyone on the UI side with time to look at this.
Owner: jen...@chromium.org

Comment 4 by derat@chromium.org, Apr 19 2018

Cc: warx@chromium.org minch@chromium.org
Status: WontFix (was: Assigned)
I'm not able to reproduce this anymore. It looks like tapping the power button dismisses the system tray now.

Sign in to add a comment