This is a re-filing of http://b/64839775 in the chromium tracker.
The repository https://quickoffice-internal.googlesource.com/ was recently migrated to use Commit Queue (CQ).
After starting to use the commit queue, it appears that the tryjobs triggered by the commit queue for a CL run against the base revision of the CL, but do not apply any of the patches from the CL.
I discussed this with tandrii@ and he suggested that this was due to git.checkout() not understanding Gerrit patchset properties set by CQ and that I should file a bug under Infra>Codereview>Gerrit to get this fixed.
The original report of the problem came from the vendor team that is actually using the repository for development (we just maintain and support them). The original report is the following:
----
Looks like the tryjob with new approach is not running on the code changes from patch but simply running on the master code.
Try job run over CL-23390 (https://quickoffice-internal-review.googlesource.com/c/23390) should fail, as the code change contains compilation errors.
But, when tryjob run using new approach of scoring +1 (Dry Run) on the Commit Queue, the build is successful.
Whereas when run using old approach of scoring +1 (Approved for try server) on the Tryjob Request and writing '!tryjob' in the comment box, the build fails as expected.
Comment 1 by aga...@chromium.org
, Aug 28 2017Components: -Infra>Codereview>Gerrit Infra>Client Infra>Platform>Recipes