New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757904 link

Starred by 1 user

Issue metadata

Status: Closed
Owner: ----
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

quickoffice try recipe doesn't know how to check out gerrit change ref

Project Member Reported by sdoerner@google.com, Aug 22 2017

Issue description

This is a re-filing of http://b/64839775 in the chromium tracker.

The repository https://quickoffice-internal.googlesource.com/ was recently migrated to use Commit Queue (CQ).

After starting to use the commit queue, it appears that the tryjobs triggered by the commit queue for a CL run against the base revision of the CL, but do not apply any of the patches from the CL.

I discussed this with tandrii@ and he suggested that this was due to git.checkout() not understanding Gerrit patchset properties set by CQ and that I should file a bug under Infra>Codereview>Gerrit to get this fixed.

The original report of the problem came from the vendor team that is actually using the repository for development (we just maintain and support them). The original report is the following:

----

Looks like the tryjob with new approach is not running on the code changes from patch but simply running on the master code.

Try job run over CL-23390 (https://quickoffice-internal-review.googlesource.com/c/23390) should fail, as the code change contains compilation errors.
But, when tryjob run using new approach of scoring +1 (Dry Run) on the Commit Queue, the build is successful.
Whereas when run using old approach of scoring +1 (Approved for try server) on the Tryjob Request and writing '!tryjob' in the comment box, the build fails as expected.
 

Comment 1 by aga...@chromium.org, Aug 28 2017

Cc: aga...@chromium.org
Components: -Infra>Codereview>Gerrit Infra>Client Infra>Platform>Recipes
Yes, git.checkout has never supported checking out gerrit change refs -- it is dumb/simple by design, and only checks out exactly what you tell it to. You need to update your recipe to either do the checkout directly, or to use bot_update.ensure_checkout().

Comment 2 by aga...@chromium.org, Aug 28 2017

Summary: quickoffice try recipe doesn't know how to check out gerrit change ref (was: git.checkout() doesn't understand Gerrit patchset properties set by CQ)

Comment 3 by s...@google.com, Aug 31 2017

Status: Available (was: Untriaged)
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 31

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Closed (was: Untriaged)
This seems unlikely to be fixed as per comment #1 and isn't causing any active trouble atm. Hence closing this.

Sign in to add a comment