New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757899 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

force overlay video for ATV

Project Member Reported by liber...@chromium.org, Aug 22 2017

Issue description

ATV requires that video is played via overlay.  this used to be |force_video_overlays_| in wmpi, but that now means "allow video overlays".

add back the old functionality.

marking M-63, but need by 8/31.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8d574722c215b1d16aa716edafb36d4623ed4c8

commit c8d574722c215b1d16aa716edafb36d4623ed4c8
Author: liberato@chromium.org <liberato@chromium.org>
Date: Wed Aug 30 20:53:43 2017

Make kForceVideoOverlays force video overlays.

This CL causes kForceVideoOverlays to once again require overlays
in AVDA, rather than simply allowing them.  This was its original.
and intended, behavior needed for ATV.

This CL also propagates kForceVideoOverlays to the renderer and
GPU processes.

Bug:  757899 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I10dad2d16f2280d670bd7982d15cc24c4b02b033
Reviewed-on: https://chromium-review.googlesource.com/630100
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498603}
[modify] https://crrev.com/c8d574722c215b1d16aa716edafb36d4623ed4c8/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/c8d574722c215b1d16aa716edafb36d4623ed4c8/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/c8d574722c215b1d16aa716edafb36d4623ed4c8/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/c8d574722c215b1d16aa716edafb36d4623ed4c8/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/c8d574722c215b1d16aa716edafb36d4623ed4c8/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/c8d574722c215b1d16aa716edafb36d4623ed4c8/media/gpu/android_video_decode_accelerator.h

Status: Fixed (was: Assigned)

Sign in to add a comment