New issue
Advanced search Search tips

Issue 757882 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Security



Sign in to add a comment

Unknown exception in C:\windows\SYSTEM32\KERNELBASE.dll

Project Member Reported by ClusterFuzz, Aug 22 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4535738460012544

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Unknown exception
Crash Address: 0x0570bf8c
Crash State:
  C:\windows\SYSTEM32\KERNELBASE.dll
  sw::allocate
  sw::Surface::lockInternal
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=480776:480824

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4535738460012544

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Components: Internals>GPU>SwiftShader
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 23 2017

Labels: M-61
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 23 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 23 2017

Labels: Pri-1

Comment 5 by gov...@chromium.org, Aug 23 2017

Cc: awhalley@chromium.org
+awhalley@(Security TPM)

Comment 6 by awhalley@google.com, Aug 25 2017

Owner: sugoi@chromium.org
Mind taking a look or helping to route this, sugoi@?  Thanks!
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 25 2017

Status: Assigned (was: Untriaged)

Comment 8 by sugoi@chromium.org, Aug 29 2017

Cc: sugoi@chromium.org
Owner: capn@chromium.org

Comment 9 by capn@chromium.org, Aug 29 2017

Cc: capn@chromium.org
Labels: -Pri-1 -Security_Severity-High -ReleaseBlock-Stable Security_Severity-Low ReleaseBlock-NA Pri-2
This is just a regular out-of-memory situation. We could use nothrow to silence the exception, but then we'd probably just crash on accessing the null buffer. We have no immediate intention to harden against every possible OOM. Crashing the GPU process is reasonable under exceptional situations like these. OOMs caused by leaks or allocating too much memory are a different story of course.

So I'm inclined to close this as Won't Fix.
Project Member

Comment 10 by sheriffbot@chromium.org, Sep 6 2017

Labels: -Security_Impact-Beta Security_Impact-Stable
Project Member

Comment 11 by sheriffbot@chromium.org, Oct 18 2017

Labels: -M-61 M-62
Project Member

Comment 12 by ClusterFuzz, Oct 24 2017

ClusterFuzz has detected this issue as fixed in range 510178:510722.

Detailed report: https://clusterfuzz.com/testcase?key=4535738460012544

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Unknown exception
Crash Address: 0x00ccceac
Crash State:
  C:\windows\SYSTEM32\KERNELBASE.dll
  sw::allocate
  sw::Surface::lockInternal
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=480776:480824
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=510178:510722

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4535738460012544

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, Oct 24 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4535738460012544 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 14 by sheriffbot@chromium.org, Oct 24 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -M-62 M-64
Project Member

Comment 16 by sheriffbot@chromium.org, Jan 30 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment